Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Archived workspace chats are missing in the LHN #17363

Closed
1 of 6 tasks
kavimuru opened this issue Apr 12, 2023 · 23 comments
Closed
1 of 6 tasks

[$1000] Archived workspace chats are missing in the LHN #17363

kavimuru opened this issue Apr 12, 2023 · 23 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Apr 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Log in to an account which has archived chats (workspace chat and rooms)
  2. Check the LHN for the archived chats

Expected Result:

Chats show in the LHN

Actual Result:

Archived chats are not shown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.99-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-12.at.3.11.29.AM.mov
Recording.216.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681251564874039

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0191725cd85b03eb45
  • Upwork Job ID: 1646458110710317056
  • Last Price Increase: 2023-04-13
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 12, 2023
@MelvinBot
Copy link

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny mountiny self-assigned this Apr 13, 2023
@mountiny
Copy link
Contributor

Taking this one cc @BeeMargarida

@mountiny
Copy link
Contributor

@BeeMargarida I have tested locally before and it seems that even after log out and log in back you still get the archived chats data but for some reason they do not appear in the LHN, there is a chance something about the data is wrong (backend bug), which is causing it not do display. Could you have a look at what data we get when the archived chats are not showing and what is causing it? I think this needs to be fixed in the backend but narrowing down whats wrong will be helpful. Thank you

@BeeMargarida
Copy link
Contributor

Hi, Ana from Callstack, I'll be investigating this 🔎

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Apr 13, 2023
@melvin-bot melvin-bot bot changed the title Archived workspace chats are missing in the LHN [$1000] Archived workspace chats are missing in the LHN Apr 13, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0191725cd85b03eb45

@MelvinBot
Copy link

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 13, 2023
@MelvinBot
Copy link

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 13, 2023
@MelvinBot
Copy link

📣 @BeeMargarida You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@BeeMargarida
Copy link
Contributor

@mountiny Recent findings: As you mentioned, the archived data is being returned when opening the app, but they are being filtered out in this function due to having an empty participants list (even if before being archived it had several participants). Is this something that changed recently?

@mountiny
Copy link
Contributor

thank you, checking, related PR #16839

@mountiny
Copy link
Contributor

Ok I have confirmed by reverting this backend change that it had this sideeffect which we did not want https://github.com/Expensify/Auth/pull/7690 cc @jasperhuangg I will check what we can do about this.

@mountiny
Copy link
Contributor

This will be fixed once deployed, closing the Upwork job

@mountiny
Copy link
Contributor

Actually @slafortune can you please pay $250 to @parasharrajat for reporting this bug?

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@MelvinBot
Copy link

@slafortune, @BeeMargarida, @mountiny, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor

Stevie is ooo asking for help with the payment here.

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2023
@mountiny mountiny assigned michaelhaxhiu and unassigned slafortune Apr 17, 2023
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 17, 2023
@MelvinBot
Copy link

Current assignee @michaelhaxhiu is eligible for the Bug assigner, not assigning anyone new.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

@parasharrajat offer sent my @michaelhaxhiu

@michaelhaxhiu
Copy link
Contributor

Still waiting on Rajat to accept. We will prob pay and close tomorrow at this point.

@michaelhaxhiu
Copy link
Contributor

Will close out today

@michaelhaxhiu
Copy link
Contributor

Paid, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants