[HOLD for payment 2023-06-23] [$2000] IOS - Connect Bank - User cannot fill out forms in the 'Connect BA' flow in Offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate to the add bank account modal in Workspace settings
2. Start and follow the flow for adding a fully verified bank account
3. User is on 'Company Info' or 'Personal Info' or 'Beneficial Info' page
4. Go to Offline Mode and fill out the forms

Expected Result:

User is able to fill out the forms on 'Company Info' or 'Personal Info' or 'Beneficial Info' page in offline. Note this should apply to any step of the Connect Bank Account flow, there were 2 duplicates created that focused on each page of the flow having this same problem so lets make sure they all work.

Actual Result:

User is NOT able to fill out the forms on 'Company Info' or 'Personal Info' or 'Beneficial Info' page in offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.4

Reproducible in staging?: Yes

Reproducible in production?: not able to check production

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6056588_iOS-personal-info-page-offline.mp4

Bug6056588_iOS-company-info-form-offline.mp4

Bug6056588_iOS-beneficial-form-offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014610ed3ac7406765
• Upwork Job ID: 1665836259727785984
• Last Price Increase: 2023-06-06

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

@kbecciv where do you get credentials to enter into the boxes in Plaid? I don't see anything in 1Password.

[kbecciv]

@mallenexpensify QA team keeps it on separate file https://docs.google.com/spreadsheets/d/1b9Mbn9eZB3mBTJG9G_G1VXWnUwYYreGCbZwuSmuutX8/edit#gid=1193570092

[melvin-bot]

@mallenexpensify, @kbecciv Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Requested access to the sheet above @kbecciv

[mallenexpensify]

Checking in #QA https://expensify.slack.com/archives/C9YU7BX5M/p1684882975458849

[mallenexpensify]

@kbecciv having trouble reproducing.
Are you using plaid to connect or connecting manually?
When I try using Plaid and my expensifail account, I get First Platypus Bank and they want to text a number to me, where last four is 1111

[kbecciv]

Hello @mallenexpensify! I'm using the option Connect online with Plaid. Don't worry about text a number to your phone, simply tap Get code under Verify your identity and tap Submit under Verification page.
Sending you a fresh video. Please let me know if you have more questions about the flow. Thank you

RPReplay_Final1685373537.MP4

[melvin-bot]

@mallenexpensify @kbecciv this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mallenexpensify]

Thanks @kbecciv , the issue was that I didn't just click through the steps, I assumed I needed a phone number or code.

For the expected behaviour:

User is able to fill out the forms on 'Company Info' or 'Personal Info' or 'Beneficial Info' page in offline

I don't think it's expected that a user will be able to complete all bank account, Plaid or OnFido steps while offline. I would think the expected behaviour is that you wouldn't be able to complete the steps until you're online. @trjExpensify , do you happen to know about this? For some reason I think you do.

[trjExpensify]

@MariaHCD will be best to confirm! I believe you should be able to fill out the form, but you can't submit it while offline because we need to make a third party API call.

[MariaHCD]

I believe you should be able to fill out the form, but you can't submit it while offline because we need to make a third party API call.

Yes, agreed. When offline, you can fill out the form but the Save & Continue button will be disabled until you are back online (pattern C)

We shouldn't be showing the full page offline screen if you go offline at any of the steps.

[mallenexpensify]

Thanks @trjExpensify and @MariaHCD

@MariaHCD if a user goes offline in the middle of the process should we

1. show this -

2. Allow them to fill out the form but have the Save & Continue button disabled?

If it's 1. I'll close the issue, if 2, my plan is to assign an engineer to review then confirm if it can be External

[MariaHCD]

2. Allow them to fill out the form but have the Save & Continue button disabled?

I believe this is how it was originally working as well perhaps something changed in the code. On the RequestorStep and CompanyStep, a user should still be able to fill out those fields and the Save & continue button will be disabled.

As an additional note, if the user has begun the Onfido verification process and goes offline, we should show them the full page offline view.

[MariaHCD]

Fwiw, I do think this can be external

[akinwale]

@alex-mechler @parasharrajat I have applied for the Upwork job and the PR is ready for review. Thanks.

[parasharrajat]

I agree ComponentDidUpdate does not prevent rerender. It is called after the render has happened.

[mallenexpensify]

@akinwale and @parasharrajat hired in Upwork! @parasharrajat , please accept
https://www.upwork.com/jobs/~014610ed3ac7406765

[akinwale]

@akinwale and @parasharrajat hired in Upwork!

Accepted, thanks.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @akinwale got assigned: 2023-06-09 15:12:40 Z
• when the PR got merged: 2023-06-14 16:22:16 UTC
• days elapsed: 4

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.28-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: allow filling out forms while offline in the Connect Bank Account Plaid flow #20559

If no regressions arise, payment will be issued on 2023-06-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[michaelhaxhiu]

🧇 I'm removing AlexM's assignment. Seems this doesn't need a new CME since we are just doing payment and BZ checklist now!

[akinwale]

@mallenexpensify Just checking in here. I'm guessing that this is eligible for the speed bonus since it still falls within 3 business days, correct? Assigned on Friday and merged Wednesday. Thanks.

[mallenexpensify]

@akinwale , that's how I see/read it as well, I wonder why it says 4 days in the auto-post above, maybe it has to do with timezones? (which isn't clear)
Paid @akinwale and @parasharrajat $3000, no bug reporter.

@parasharrajat can you fill out the BZ checklist plz?
#18990 (comment)

[akinwale]

@akinwale , that's how I see/read it as well, I wonder why it says 4 days in the auto-post above, maybe it has to do with timezones? (which isn't clear) Paid @akinwale and @parasharrajat $3000, no bug reporter.

@parasharrajat can you fill out the BZ checklist plz? #18990 (comment)

Payment received, thanks!

I think it calculates 72 hours, and then any hour above that is counted as another day.

[parasharrajat]

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: It is technically a new change. The loader was added initially in #13236 **
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: ** As this is not a bug, there is no need to comment anywhere.

[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #18990 (comment)

[parasharrajat]

Regression Test Steps

1. Navigate to the Bank account in the Workspace settings.
2. Start a new flow if one is already in progress. Choose "Connect online with Plaid".
3. Follow the Plaid flow to connect an account. Select the "Regions Bank" institution, and use "user_good" / "pass_good" (without quotes) as the credentials.
4. Finish up with the Plaid flow which should redirect back to the app.
5. Select any of the accounts and click Save & Continue.
6. Fill out any of the forms in steps 2, 3, or 4 (which come after Onfido verification).
7. Go offline.
8. Verify that the full-page offline view is not displayed and the current form can still be filled while offline. (Note: There are a few fields which are locked once submitted).

Do you agree 👍 or 👎 ?

[mallenexpensify]

Thanks for the steps @parasharrajat, Regression test step update GH created
https://github.com/Expensify/Expensify/issues/295146