[HOLD for payment 2023-06-19] [$1000] Desktop - Console log appears when clicking "continue" in sign in page and creating new task page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #19639

Action Performed:

Scenario1:

1. Logout if already logged in
2. Enter new email and click Continue button
3. Verify that no console errors appear on magic code input page

Scenario 2:

1. Login any account
2. Create new task (Open FAB > Assign task > Enter title > Select assignee > Confirm task)

Expected Result:

There should be no console error

Actual Result:

Console error appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.20.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/e61633511efab782d91f07a9e36c0dccd54fca6a4b21af7e7fae4b2bf8bde0ff
https://platform.applause.com/services/links/v1/external/9d382627ef1173c0ff7f656503f0245073df957cdf011d91eb4710076895d402

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014a37a60d035a3de7
• Upwork Job ID: 1663930257949224960
• Last Price Increase: 2023-05-31

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Regression from #19579

[lschurr]

Slack convo: https://expensify.slack.com/archives/C049HHMV9SM/p1685441927670609

[lschurr]

@eVoloshchak @puneetlath looks like you worked on the PRs (#19639 and #19579)

Should we add External here to start a new fix or is this being fixed somewhere else already?

[puneetlath]

I'm not aware of it being fixed anywhere else, so if you're still seeing the issue on staging, I'd go ahead and mark external.

[lschurr]

I don't see this on web, but I'm asking for more info here - https://expensify.slack.com/archives/C049HHMV9SM/p1685546610952849?thread_ts=1685441927.670609&cid=C049HHMV9SM

Multiple contributors have reproduced in that thread ^

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014a37a60d035a3de7

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @robertjchen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[eVoloshchak]

This is a regression from #19579 that was just deployed to staging, I don't think this should be external, we should fix this in a follow-up PR
The main issue currently is that both me and @tienifr can't reproduce this, this could be a Linux-only problem.
I'll get my hands on a Linux machine and try to reproduce this

[rushatgabhane]

@eVoloshchak sounds good! all yours

[melvin-bot]

📣 @eVoloshchak You have been assigned to this job by @lschurr!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[priya-zha]

@rushatgabhane According to the slack conversation here https://expensify.slack.com/archives/C049HHMV9SM/p1685441927670609

I reported this bug on May 30. It would be great if you could let me know If I'm the initial reporter for this bug or not . Thanks.

[kavimuru]

@rushatgabhane Same console error appears in the following pages in desktop:

1. Adding a new secondary contact
2. Adding a paypal account
3. Picking emoji and hit enter

[melvin-bot]

@robertjchen, @eVoloshchak, @lschurr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@robertjchen, @eVoloshchak, @lschurr Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: autofill is not a valid selector #19890

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@robertjchen @eVoloshchak - who are we paying for this one? It was a regression that we didn't make external? But it looks like @tienifr worked on the PR, correct?

[eVoloshchak]

@lschurr, this was a regression from another PR @tienifr worked on
So there's only a reporting bonus to be paid (if any) to the person who reported this

[priya-zha]

@eVoloshchak It would be great if you could look at this comment . I reported the same issue on May 30. Can you please confirm whether I am the initial reporter of this issue or not?

[mountiny]

@lschurr Seems like @priya-zha has reported this after noon

and this issue was created in the evening so I believe the only payment here should be $250 to @priya-zha

[lschurr]

Great thanks @mountiny! @priya-zha - could you apply for the job here? https://www.upwork.com/jobs/~014a37a60d035a3de7

[priya-zha]

@Ischurr Proposal submitted. Thanks.

[lschurr]

Paid!