[$2000] Web - Login - Non-clickable LHN instead of "Abracadabra, you're logged in" page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Scenario 1

1. Log out of NewDot and request a new magic link
2. Navigate to email and locate the magic link - change to staging if needed
3. Open an new tab and navigate to the staging link

Scenario 2

1. Log out of NewDot and request a new magic link
2. Navigate to email and locate the magic link - change to staging if needed
3. Open an new tab and navigate to the staging link
4. Verify the 2FA required page is displayed. Should have a message similar to "Please enter the two-factor authentication code where you are trying to sign in."
5. Navigate back to the original tab - Keep the second tab open
6. Verify the log in flow is now asking the user to enter the 2FA code
7. Enter the 2FA code
8. Verify the user can log in
9. Navigate to the secondary tab
10. Verify the "Abracadabra, you're logged in" page is displayed

Scenario 3:

1. Log out of NewDot and request a new magic link
2. Navigate to email and locate the magic link - change to staging if needed
3. Open an new INCOGNITO window and navigate to the staging link

Scenario 4:

1. Log out of the account
2. Enter the email on the email field and continue
3. Verify the there's a message below that says "Not [Email]?" and a link to "Go back"
4. Click on "Go Back"
5. Verify the email is still displayed in the email field
6. Continue with the log in flow
7. Navigate to the email inbox and look for the magic link email
8. Change the link to staging if needed
9. Open a new tab and paste the link in the URL

Scenario 5:

1. On the log in screen, enter a new account email
2. Navigate to the email inbox and open the validate email and copy the link
3. Modify the last portion of the link by a character, i.e.
   In a text box - Formulate the URL by using the path obtained from step 3 http://staging.new.expensify.com/v/

• E.g if the original link was https://stagin.new.expensify.com/v/7453760/123884
  change a single character > https://staging.new.expensify.com/v/7453760/12388**8**

4. Navigate to the compiled link
5. Verify you're redirected the "Magic code expired" page
6. Click on the "Request new magic code here"
7. Verify the user receives a new magic link
8. Change the link to staging, open a new tab and navigate to the link

Expected Result:

For both scenarios: "Abracadabra, you're logged in" page should be displayed

Actual Result:

For both scenarios: Non-clickable LHN (logged in pp) is displayed instead of "Abracadabra, you're logged in"" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.25.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:
https://expensify.testrail.io/index.php?/tests/view/3490257
https://expensify.testrail.io/index.php?/tests/view/3490091
https://expensify.testrail.io/index.php?/tests/view/3490191
https://expensify.testrail.io/index.php?/tests/view/3490257
https://expensify.testrail.io/index.php?/tests/view/3490256

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Scenario 1

Bug6084047_video_04.1.mp4

Scenario 2

Bug6084047_video_64__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @Natnael-Guchima

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0154116efc17a0ee13
• Upwork Job ID: 1666593984300412928
• Last Price Increase: 2023-07-01

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Taking this over from @joelbettner

[roryabraham]

Wasn't able to reproduce w/ scenario 1 in dev, but was able to reproduce on staging. I think the difference was that the desktop deeplink was making it not work as expected?

[roryabraham]

Was able to reproduce this in dev by removing this dev environment check

[roryabraham]

So it seems like what's happening here is that we're redirecting to new-expensify://URL here, and that's causing the request to the transition page w/ the correct exitTo to be cancelled:

and that seems to be why the flow is failing?

[roryabraham]

I reproduced this on production. Demoting it from deploy blocker to regular bug.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0154116efc17a0ee13

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Current assignees @puneetlath and @roryabraham are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[WoLewicki]

Is it connected to the navigation refactor in a way that I can help you anyhow?

[hoangzinh]

@WoLewicki according to my proposal above, I don't think it's related to navigation refactor recently.

[melvin-bot]

@puneetlath @abdulrahuman5196 @roryabraham this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@puneetlath, @abdulrahuman5196, @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abdulrahuman5196]

We already have one proposal. But it needs some dive deep and more testing time since whenever we repro this bug, it is making the local web non-actionable after that. Will try to complete the review before tomorrow.

[abdulrahuman5196]

Sorry for the delay @hoangzinh . It seems whenever i try to reproduce this issue, the local gets messed up and blocking me to focus on other priority issues as well. Will close it out this weekend by spending more time on it.

[hoangzinh]

Thanks for heads up. No worries.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Taking a look now.

[abdulrahuman5196]

@hoangzinh Could you kindly check if you able to reproduce the issue with the slack tests you mentioned currently? It is only leading to this bug #21258

Not of the steps is reproducible currently

[hoangzinh]

Yes I can. This bug #21258 has same kind of error, but with different expectation (In our case, we would like to see "You're logged in" screen, in that bug we would like to see "Here is your magic code" screen)

This is my recording in latest main branch

Screen.Recording.2023-06-27.at.06.49.05.mp4

[melvin-bot]

@puneetlath @abdulrahuman5196 @roryabraham this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[puneetlath]

Just to make sure I understand. The bug is still happening? Or it's working as expected now?

[roryabraham]

Requested a retest by Applause: https://expensify.slack.com/archives/C9YU7BX5M/p1688079598241329

[abdulrahuman5196]

Just to make sure I understand. The bug is still happening? Or it's working as expected now?

@puneetlath The bug was transforming into different cases for sometime(since there where multiple scenarios in OP), could be due to external changes. As of now, the bug is transformed into a relatable state of this bug #21258, where the view is frozen but the content is shown. (which is also fixed and recently deployed)
So I doubt this will be reproducible but not entirely sure if all related scenarios are fixed, so its a good thing we have requested for a re-test - #20410 (comment)

[hoangzinh]

Could we also request to test the steps here to ensure we won't miss any cases https://expensify.slack.com/archives/C049HHMV9SM/p1686903317694329? I think we won't have the Non-clickable LHN issue anymore, but I think it would show the Magic code page instead of "Abracadabra, you're logged in" page

Screen.Recording.2023-06-30.at.23.59.32.mp4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[puneetlath]

@hoangzinh please report this as a new bug in #expensify-bugs as it seems different from what this issue was originally about.