Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-28] [$1000] Email is missing in "Invite new members to workspace" page #20803

Closed
6 tasks
Beamanator opened this issue Jun 15, 2023 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@Beamanator
Copy link
Contributor

Beamanator commented Jun 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. go to Settings >Workspaces > Members
    2.click on invite

Expected Result:

email showing for all members

Actual Result:

email is missing for all members

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: main
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan / @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686828770758129

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0131ca05869a50a814
  • Upwork Job ID: 1670861674705686528
  • Last Price Increase: 2023-06-19
@Beamanator Beamanator added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Beamanator
Copy link
Contributor Author

@tjferriss I don't know if we need an engineer on this - @fedirjh made the PR & i merged it - technically @fedirjh is a C+ but they didn't do C+ duties, they fixed the bug 😅 👍

@tjferriss
Copy link
Contributor

@Beamanator thanks. It sounds like we should @fedirjh as the contributor and you're the reviewer.

As for the reporting bounty, I see the bug was first reported by @gadhiyamanan so I would assume we give them the reporting bonus over @priya-zha.

@tjferriss tjferriss added the External Added to denote the issue can be worked on by a contributor label Jun 19, 2023
@melvin-bot melvin-bot bot changed the title Email is missing in "Invite new members to workspace" page [$1000] Email is missing in "Invite new members to workspace" page Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0131ca05869a50a814

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

@tjferriss tjferriss assigned Beamanator and unassigned sonialiap Jun 19, 2023
@priya-zha
Copy link

priya-zha commented Jun 19, 2023

@Beamanator thanks. It sounds like we should @fedirjh as the contributor and you're the reviewer.

As for the reporting bounty, I see the bug was first reported by @gadhiyamanan so I would assume we give them the reporting bonus over @priya-zha.

@tjferriss I reported the same bug on June 12 whereas this issue was reported on June 15. Here's the slack convo: https://expensify.slack.com/archives/C049HHMV9SM/p1686588133599859

Also here in this convo

It would be great if you could look at this and let me know your thoughts on this. 😀 😀

Thanks

@gadhiyamanan
Copy link
Contributor

@priya-zha you reported that bug for PR testing which was fixed and for that reporting bonus will be handled here and i reported after it merged with main

@priya-zha
Copy link

It's still reproducible, so was it really fixed? If a bug has been reported for a specific build, do we need to create the same bug report again and again if the PR merges with the main or hits the staging ? Actually, i don't have much idea on this , so if someone could clarify. I'll leave this on the team. Whatever the team decides , I'm okay with it. 😄😄😄😄

Also a related conversation here https://expensify.slack.com/archives/C049HHMV9SM/p1686659432203249?thread_ts=1686648377.836269&cid=C049HHMV9SM

@gadhiyamanan
Copy link
Contributor

It's still reproducible, so was it really fixed?

I am not able to reproduce, are you?

@priya-zha
Copy link

@gadhiyamanan No not today. It was reproducible when the PR merged with the main. If it was already solved before the PR merged with the main , then why did the issue appear again? Also, I have a question, Can you please let me know if we create different bug reports for the same bug if it gets reproduced on a different build? I'm sorry I don't know much about this. Or is it like we just create a single bug report for a specific bug no matter what the build is? Here's where my doubt is. It would be great if you could answer this. 😃 😃

If we create different bug reports for the same bug which depends on the build/platform we use , then no doubt, you should be the one to be the reporter for this bug. But, according to this slack convo, I felt no multiple bug reports are created for the same issue. I don't know what's the procedure here. 😕 ❓ Confused totally.

@gadhiyamanan
Copy link
Contributor

according to this slack convo, I felt no multiple bug reports are created for the same issue

the above bug which you mention is general bug which was reproducible in staging and not related to PR according to this. the bug which was reported by you is related to PR and which was solver according to this

the bug which was reported by me and created in GitHub was reported after merged with main

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 21, 2023
@melvin-bot melvin-bot bot changed the title [$1000] Email is missing in "Invite new members to workspace" page [HOLD for payment 2023-06-28] [$1000] Email is missing in "Invite new members to workspace" page Jun 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
  • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@fedirjh] Determine if we should create a regression test for this bug.
  • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 30, 2023

@Beamanator, @tjferriss, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Beamanator
Copy link
Contributor Author

Ready for payment 👍

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2023

@Beamanator, @tjferriss, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Beamanator
Copy link
Contributor Author

Bump @tjferriss

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 7, 2023
@Beamanator
Copy link
Contributor Author

Bump again @tjferriss :D

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2023
@tjferriss
Copy link
Contributor

Sorry for the delay here. I meant to re-assign before heading out on vacation. Offers have been sent to @fedirjh and @gadhiyamanan for the reporting bonus.

@gadhiyamanan
Copy link
Contributor

@tjferriss accepted, thanks!

@tjferriss
Copy link
Contributor

Payments have been sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants