-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-28] [$1000] Email is missing in "Invite new members to workspace" page #20803
Comments
Triggered auto assignment to @tjferriss ( |
Bug0 Triage Checklist (Main S/O)
|
@tjferriss I don't know if we need an engineer on this - @fedirjh made the PR & i merged it - technically @fedirjh is a C+ but they didn't do C+ duties, they fixed the bug 😅 👍 |
@Beamanator thanks. It sounds like we should @fedirjh as the contributor and you're the reviewer. As for the reporting bounty, I see the bug was first reported by @gadhiyamanan so I would assume we give them the reporting bonus over @priya-zha. |
Job added to Upwork: https://www.upwork.com/jobs/~0131ca05869a50a814 |
Triggered auto assignment to @sonialiap ( |
Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new. |
@tjferriss I reported the same bug on June 12 whereas this issue was reported on June 15. Here's the slack convo: https://expensify.slack.com/archives/C049HHMV9SM/p1686588133599859 Also here in this convo It would be great if you could look at this and let me know your thoughts on this. 😀 😀 Thanks |
@priya-zha you reported that bug for PR testing which was fixed and for that reporting bonus will be handled here and i reported after it merged with main |
It's still reproducible, so was it really fixed? If a bug has been reported for a specific build, do we need to create the same bug report again and again if the PR merges with the main or hits the staging ? Actually, i don't have much idea on this , so if someone could clarify. I'll leave this on the team. Whatever the team decides , I'm okay with it. 😄😄😄😄 Also a related conversation here https://expensify.slack.com/archives/C049HHMV9SM/p1686659432203249?thread_ts=1686648377.836269&cid=C049HHMV9SM |
I am not able to reproduce, are you? |
@gadhiyamanan No not today. It was reproducible when the PR merged with the main. If it was already solved before the PR merged with the main , then why did the issue appear again? Also, I have a question, Can you please let me know if we create different bug reports for the same bug if it gets reproduced on a different build? I'm sorry I don't know much about this. Or is it like we just create a single bug report for a specific bug no matter what the build is? Here's where my doubt is. It would be great if you could answer this. 😃 😃 If we create different bug reports for the same bug which depends on the build/platform we use , then no doubt, you should be the one to be the reporter for this bug. But, according to this slack convo, I felt no multiple bug reports are created for the same issue. I don't know what's the procedure here. 😕 ❓ Confused totally. |
the above bug which you mention is general bug which was reproducible in staging and not related to PR according to this. the bug which was reported by you is related to PR and which was solver according to this the bug which was reported by me and created in GitHub was reported after merged with main |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-28. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@Beamanator, @tjferriss, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Ready for payment 👍 |
@Beamanator, @tjferriss, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Bump @tjferriss |
Bump again @tjferriss :D |
Sorry for the delay here. I meant to re-assign before heading out on vacation. Offers have been sent to @fedirjh and @gadhiyamanan for the reporting bonus. |
@tjferriss accepted, thanks! |
Payments have been sent. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
2.click on invite
Expected Result:
email showing for all members
Actual Result:
email is missing for all members
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number:
main
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan / @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686828770758129
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: