[HOLD for payment 2023-07-06] [$1000] Error not displayed for invalid phone number in New Contact Method section

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Profile > Contact Methods
2. Click "New Contact Method"
3. Enter an invalid phone number (e.g. +1-212-456ww7890)
4. No error is displayed

Expected Result:

The app should display an error for invalid phone numbers to ensure consistency

Actual Result:

The app does not display an error for invalid phone numbers in the New Contact Method section.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture - 2023-06-15T014547.796.webm

Recording.1051.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686819848909279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0193d5a8ad70190344
• Upwork Job ID: 1671812275847946240
• Last Price Increase: 2023-06-22

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[getusha]

I think numbers which have letters in them are in fact valid phone numbers like +1-800-FLOWERS or some letters between. i learned this the hard way after i spent time on this but this may help https://www.quora.com/Why-do-many-public-American-telephone-numbers-have-letters-in-them

[conorpendergrast]

@getusha Maybe, but we don't translate +1-212-456ww7890 into +1-212-456997890. Either way, that's incorrect!

So there are two potential solutions: reject non-numeric phone numbers (ie: show an error when you enter +1-212-456ww7890) or translate the letters into numbers (ie: translate +1-212-456ww7890 into +1-212-456997890`.

I think we can safely use the first solution by validating that field. we seem to reject it on the back-end, as we initially allow that phone number to be entered, and then we silently remove it from the Contact Method list.

[conorpendergrast]

This may have a similar solution to #21230, also reported by @tewodrosGirmaA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0193d5a8ad70190344

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error is not displayed for phone numbers letters between them

What is the root cause of that problem?

The library we are using awesome-phonenumber detects the number as possible/valid phone number since it is a valid email address according to them.

#21247 (comment)

What changes do you think we should make in order to solve the problem?

We can use Str.isValidPhone() from expensify/common by replacing the + and - between the numbers

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Line 88 in 9bef507

if (!_.isEmpty(values.phoneOrEmail) && !(parsePhoneNumber(phoneLogin).possible || Str.isValidEmail(values.phoneOrEmail))) {

// phoneLogin will be pure number and will be validated by the Str utils.
Str.isValidPhone(phoneLogin)

What alternative solutions did you explore? (Optional)

N/A

cc @conorpendergrast @mananjadhav

[mananjadhav]

Thanks for the proposal @getusha. This looks good to me. As you rightly said, letters is phone numbers is acceptable but as mentioned earlier we don't convert them to digits.

@conorpendergrast We can use @getusha's solution. The linked issue is related to email and not necessarily the same solution.

C+ reviewed  🎀👀🎀

[alexxxwork]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The form validates telephone numbers with letters in them on add new contact page

What is the root cause of that problem?

The root cause of the problem is that we use awsome-phonenumber lib to check telephone number validity. And this lib uses Google's libphonenumber.
And libphonenumber lib allows using letters instead of numbers in a phone number, as seen here:

https://github.com/google/libphonenumber/blob/b30f7d90154b3148ee7b162f0e236a9cd1fa2229/javascript/i18n/phonenumbers/phonenumberutil.js#L560-L567

and here's the recoding table:
https://github.com/google/libphonenumber/blob/b30f7d90154b3148ee7b162f0e236a9cd1fa2229/javascript/i18n/phonenumbers/phonenumberutil.js#L315-L342

What changes do you think we should make in order to solve the problem?

We could check if the input number contains letters and replace the number using awsome-phonenumbers methods. We already do it before sending info to backend here:

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Lines 71 to 73 in 9bef507

	if (parsedPhoneNumber.possible) {
	return parsedPhoneNumber.number.e164 + CONST.SMS.DOMAIN;
	}

So we could update number in the form after successful check for validity

[Babur171]

Firstly, a regex pattern should be defined to validate phone numbers. This pattern should cover the acceptable format and any specific requirements for phone numbers in your system. For example, it might include rules for country codes, area codes, and number length.

Once the regex pattern is defined, it can be applied to the phone number input field in the "New Contact Method" section. This can be done during the form validation process. When the user submits the form or moves to the next field, the phone number should be checked against the regex pattern.

[melvin-bot]

📣 @Babur171! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[conorpendergrast]

@mananjadhav Can you do that thang and post to accept the solution? That'll auto-assign the engineer to review and confirm the solution, and assign @getusha. Thank you!

[mananjadhav]

@conorpendergrast Sorry I missed that, I updated the comment, will it assign then?

[mananjadhav]

Thanks for the proposal @getusha. This looks good to me. As you rightly said, letters is phone numbers is acceptable but as mentioned earlier we don't convert them to digits.

🎀 👀 🎀 C+ reviewed

[mananjadhav]

@conorpendergrast Am I doing something wrong? It looks like it didn't assign an engineer.

[conorpendergrast]

Ah, that won't work for me anyway because I'm C+ (I checked where we interact with GitHub's webhook on this).

@mananjadhav I don't think it works on comment edits, I think. Can you try posting with just :ribbon: :eyes: :ribbon: which is what we're looking for

[slafortune]

Will the fix in this issue address any invalid field - phone or email? Would you like me to close this as a duplicate?

[mananjadhav]

I think this will just fix the phone. We can add email here, but I think better to have a separate issue?

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

📣 @getusha You have been assigned to this job by @jasperhuangg!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[getusha]

PR is up! @mananjadhav @jasperhuangg

[conorpendergrast]

I see the PR has been reviewed and approved by @mananjadhav, currently waiting for review by @jasperhuangg 👍

[melvin-bot]

🎯 ⚡️ Woah @mananjadhav / @getusha, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @getusha got assigned: 2023-06-23 17:22:53 Z
• when the PR got merged: 2023-06-27 17:08:35 UTC

On to the next one 🚀

[conorpendergrast]

Contracts sent for all three (bug, C and C+), including the 50% urgency bonus for C and C+

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix error not displayed for invalid phone number in New Contact Method #21442

If no regressions arise, payment will be issued on 2023-07-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/299038

[jasperhuangg]

cc @conorpendergrast it's past 07/06, let's get people paid!

[conorpendergrast]

I agree, everyone got paid!

@mananjadhav We just need the checklist now please

[mananjadhav]

Here's the offending PR, which I think caused the bug when resolving merge conflicts here? I've posted a comment here.

I do think it makes sense to add a regression test here so that we don't end up looking at this case again. @conorpendergrast The test steps from the PR are good enough for the regression test.

[conorpendergrast]

Those steps would be:

1. Go to Settings > Profile > Contact Methods
2. Click "New Contact Method"
3. Enter an invalid phone number (e.g. +1-212-456ww7890)
4. Try to add the phone number
5. Verify that invalid phone number error is shown.
6. Verify that no errors appear in the JS console

I'll create a regression test for that today

[conorpendergrast]

Regression test created: https://github.com/Expensify/Expensify/issues/299038

And we're all done!