[HOLD #22332] Web - In-consistent right margin after avatar on the request money chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the App and Login.
2. Request money from a workspace.
3. Open the created chat report.

Expected Result:

The spacing between avatar and user's email / name should be consistent.

Actual Result:

The spacing between avatar and user's email / name is more for the subscript avatar.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Sibtain Ali
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687152667921079

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Spacing between avatar and name is inconsistent

What is the root cause of that problem?

The root cause of this issue is that SubscriptAvatar component by default adds a margin right. This causes an extra margin to appear.

What changes do you think we should make in order to solve the problem?

We need to add noMargin prop here.

What alternative solutions did you explore? (Optional)

None
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[thienlnam]

We're updating the headers here #20844, so let's hold on any updates to this for now

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abekkala]

@Christinadobrzyn Reassigning for Sabbatical

---

CURRENT STATUS:

• Issue Reported By: @allroundexperts
• Assigned for Fix: TBD, may not be needed
• Assigned C+: TBD, may not be needed

On HOLD as 20844 may resolve this one!

[Christinadobrzyn]

Moving to weekly since this is on Hold for #20844

[Christinadobrzyn]

Still on hold for #20844

[thienlnam]

Holding PR has been deployed to production - can we see if this is still reproducible?

[Christinadobrzyn]

The screenshot in the OP doesn't show where the spacing is inconsistent. I don't know if this is fixed or now, asking qa if they can help - https://expensify.slack.com/archives/C9YU7BX5M/p1689363050971649

[melvin-bot]

@thienlnam @Christinadobrzyn this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[allroundexperts]

This is still an issue.

[allroundexperts]

On localhost, here's how it looks:

Notice that the spacing between name and icon is still not consistent with other pages.

[thienlnam]

Actually, this will be resolved in these PRs

#22484 / #22562

[thienlnam]

Appears we had an issue for this here #22332

[Christinadobrzyn]

I'm ooo till July 31st so going to add another coach to monitor this until I'm back.

We're currently watching these PRs to see if it resolves this.

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tjferriss]

Thanks @Christinadobrzyn. I'll keep an eye on those PRs.

[melvin-bot]

@tjferriss, @thienlnam, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tjferriss]

@thienlnam it looks like the linked PRs have been merged. I'm having a hard time seeing the difference in the spacing from the original issue, but I think this might be fixed now. What do you think?

[thienlnam]

Yeah I think this is probably fixed now