[HOLD for payment 2023-08-14] [$1000] Web - Appropriate message is not shown when drag&drop a folder. #22306

kbecciv · 2023-07-05T20:27:09Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open any chat.
Drag & drop a folder a size less than 24MB and Greater than 240bytes.

Expected Result:

We should show an error message that uploading folders is not supported.

Actual Result:

We show the error: The attachment size must be greater than 240 bytes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.36-4
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test58_Dragdropfolder-1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688504637490979

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012e40ccd48a35f18f
Upwork Job ID: 1678535202129506304
Last Price Increase: 2023-07-17

The text was updated successfully, but these errors were encountered:

melvin-bot · 2023-07-05T20:27:15Z

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-05T20:27:17Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

PrashantMangukiya · 2023-07-06T06:50:09Z

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

Appropriate message is not shown when drag&drop a folder.

What is the root cause of that problem?

When we drag file it will have file object info as shown here in debug.

When we drag folder it will have file object info as shown here in debug.

As we can see for the folder type property is empty string and size belongs to folder size.

So when we drop content, we just check size but we do not have any checking to detect that given item is folder or file, so it will just check size and show message accordingly.

Here is the code we are checking for file size etc.

App/src/components/AttachmentModal.js

Lines 172 to 202 in f08ab19

    
           const isValidFile = useCallback( 
        
               (_file) => { 
        
                   const {fileExtension} = FileUtils.splitExtensionFromFileName(lodashGet(_file, 'name', '')); 
        
                   if (_.contains(CONST.API_ATTACHMENT_VALIDATIONS.UNALLOWED_EXTENSIONS, fileExtension.toLowerCase())) { 
        
                       const invalidReason = props.translate('attachmentPicker.notAllowedExtension'); 
        
                       setIsAttachmentInvalid(true); 
        
                       setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.wrongFileType')); 
        
                       setAttachmentInvalidReason(invalidReason); 
        
                       return false; 
        
                   } 
        
                   if (lodashGet(_file, 'size', 0) > CONST.API_ATTACHMENT_VALIDATIONS.MAX_SIZE) { 
        
                       setIsAttachmentInvalid(true); 
        
                       setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.attachmentTooLarge')); 
        
                       setAttachmentInvalidReason(props.translate('attachmentPicker.sizeExceeded')); 
        
                       return false; 
        
                   } 
        
                   if (lodashGet(_file, 'size', 0) < CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE) { 
        
                       setIsAttachmentInvalid(true); 
        
                       setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.attachmentTooSmall')); 
        
                       setAttachmentInvalidReason(props.translate('attachmentPicker.sizeNotMet')); 
        
                       return false; 
        
                   } 
        
                   return true; 
        
               }, 
        
               // eslint-disable-next-line react-hooks/exhaustive-deps 
        
               [props.translate], 
        
           );

What changes do you think we should make in order to solve the problem?

We need to add checking that dropped item is folder or not. So if dropped item is folder it will have file.type as empty, so we can put condition as shown code below:

const isValidFile = useCallback( 
     (_file) => { 
        // *** ADD THIS CONDITION ***
        // If dropped item is folder then show error.
        if (_file.type === '') {
            setIsAttachmentInvalid(true);
            setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.folderNotAllowed'));
            setAttachmentInvalidReason(props.translate('attachmentPicker.folderNotAllowedMessage'));
            return false;
        }
        ...
     }, 
     // eslint-disable-next-line react-hooks/exhaustive-deps 
     [props.translate], 
 );

We have to also add corresponding translation for en and es.

en.js

attachmentPicker: {
    ...
    folderNotAllowed: 'Folder not allowed.', // *** ADD THIS ***
    folderNotAllowedMessage: 'Uploading folders is not allowed.', // *** ADD THIS ***
},

es.js

attachmentPicker: {
    ...
    folderNotAllowed: 'Carpeta no permitida.',
    folderNotAllowedMessage: 'No se permite subir carpetas.',
},

Note: We can adjust the message text copy as per need. At present I put folder not allowed message for explanation purpose.

What alternative solutions did you explore? (Optional)

None

Result

22306-FolderNotAllowed.mov

sakluger · 2023-07-10T22:42:24Z

I agree that this is a bug, we do not support folder upload and should return an error if a user tries uploading a folder via drag and drop.

melvin-bot · 2023-07-10T22:42:34Z

Job added to Upwork: https://www.upwork.com/jobs/~012e40ccd48a35f18f

melvin-bot · 2023-07-10T22:42:37Z

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-07-10T22:42:43Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

alitoshmatov · 2023-07-11T06:17:40Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Appropriate message is not shown when drag&drop a folder

What is the root cause of that problem?

We are not checking for file if it is a folder or not.
Folders have type as an empty string

What changes do you think we should make in order to solve the problem?

There are also other files where type is empty, for example: .c files.

if type is empty the backend also rejects this file, and sends an error.

So there is no point of sending files where type is empty. We can add additional condition !lodashGet(_file, 'type') here to check if type is empty:

App/src/components/AttachmentModal.js

Line 186 in acf9ced

    
           if (_.contains(CONST.API_ATTACHMENT_VALIDATIONS.UNALLOWED_EXTENSIONS, fileExtension.toLowerCase())) {

This way, we can prevent folders and any other files which backend would respond with an error.
Also we can update this error string to be something like: This attachment type is not allowed, this way we mean all file types as well as folders.

App/src/languages/en.js

Line 168 in cd741fb

notAllowedExtension: 'This filetype is not allowed',

What alternative solutions did you explore? (Optional)

Charan-hs · 2023-07-11T20:03:26Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Appropriate message is not shown when drag&drop a folder

What is the root cause of that problem?

The issue was caused due to "IsValidFile" function not checking the file type before checking for other attributes.

What changes do you think we should make in order to solve the problem?

Found some viable solutions.

Basic check of file with type checking. We are getting file details through props, now we can apply a check i.e. if the type property is empty then we can rise an error that "Is file is Not Supported". But this can block any file without any type property for example, the User wants to upload a raw image file but this file doesn't have a type property so this file can't be uploaded. In this hypothetical scenario, it can rise a concerning Issue.
Advanced solution is to check the file type with a inbuilt function i.e. "webkitGetAsEntry". This function returns an object with these properties

{ 
  fullPath : "string",
  isDirectory:boolean,
  isFile:boolean,
  name: "string"
}

so with the help of this object, we can easily distinguish files uploaded, whether it's a folder or image, or a file without any type.

Here are some example file uploaded and type checking.

Image file uploaded

{ 
  fullPath : "/Screenshot 2023-04-16 at 11.48.02 AM.png",
  isDirectory: false,
  isFile: true,
  name: "Screenshot 2023-04-16 at 11.48.02 AM.png"
}

Folder uploaded

{ 
  fullPath : "/test folder",
  isDirectory: true,
  isFile: false,
  name: "test folder"
}

File without type property

{ 
  fullPath : "/sample.c",
  isDirectory: false,
  isFile: true,
  name: "sample.c"
}

so using this Method we can check file type if it's a folder we can rise a Error to the user "Folder can't be Uploaded" and If it's a File without a type property then we can add a type to that file then Upload***

Detailed steps

1. Changes in Drag and Drop Component.

Adding webkitdirectory attribute to that doumentElement.
Current File

App/src/components/DragAndDrop/index.js

Lines 93 to 109 in acf9ced

    
           addEventListeners() { 
        
               this.dropZone = document.getElementById(this.props.dropZoneId); 
        
               this.dropZoneRect = this.calculateDropZoneClientReact(); 
        
               document.addEventListener('dragover', this.dropZoneDragListener); 
        
               document.addEventListener('dragenter', this.dropZoneDragListener); 
        
               document.addEventListener('dragleave', this.dropZoneDragListener); 
        
               document.addEventListener('drop', this.dropZoneDragListener); 
        
               window.addEventListener('resize', this.throttledDragNDropWindowResizeListener); 
        
           } 
        
           removeEventListeners() { 
        
               document.removeEventListener('dragover', this.dropZoneDragListener); 
        
               document.removeEventListener('dragenter', this.dropZoneDragListener); 
        
               document.removeEventListener('dragleave', this.dropZoneDragListener); 
        
               document.removeEventListener('drop', this.dropZoneDragListener); 
        
               window.removeEventListener('resize', this.throttledDragNDropWindowResizeListener); 
        
           }

changes needed i.e adding webkitdirectory attribute to Entire Document

   addEventListeners() {
        this.dropZone = document.getElementById(this.props.dropZoneId);
        document.documentElement.setAttribute('webkitdirectory',"")
        this.dropZoneRect = this.calculateDropZoneClientReact();
        document.addEventListener('dragover', this.dropZoneDragListener);
        document.addEventListener('dragenter', this.dropZoneDragListener);
        document.addEventListener('dragleave', this.dropZoneDragListener);
        document.addEventListener('drop', this.dropZoneDragListener);
        window.addEventListener('resize', this.throttledDragNDropWindowResizeListener);
        
    }

    removeEventListeners() {
        document.documentElement.removeAttribute('webkitdirectory')
        document.removeEventListener('dragover', this.dropZoneDragListener);
        document.removeEventListener('dragenter', this.dropZoneDragListener);
        document.removeEventListener('dragleave', this.dropZoneDragListener);
        document.removeEventListener('drop', this.dropZoneDragListener);
        window.removeEventListener('resize', this.throttledDragNDropWindowResizeListener);
    }

2. OnDropChanges

Currently

App/src/pages/home/report/ReportActionCompose.js

Lines 1131 to 1134 in b9508b6

    
           const file = lodashGet(e, ['dataTransfer', 'files', 0]); 
        
           displayFileInModal(file);

Changes
Here we will get items from dataTransfer object then pass it on to displayFileInModal
we can get File from calling data.getAsFile()

 const data = lodashGet(e, ['dataTransfer', 'items', 0]);                                                
displayFileInModal(data);

3. IsValidFile

here we can Check File type then throw an Error "File Type Not Supported"

 if (typeof _data.webkitGetAsEntry === 'function') {
                const entry = _data.webkitGetAsEntry();
                checkFileorFolder(entry);
               // entry Object has isDirectory property
            }

What alternative solutions did you explore? (Optional)

One more suggestion is rather than adding EventListeners to entire document and then narrowing down to upload section. just add EventListeners to that View.

melvin-bot · 2023-07-11T20:03:29Z

📣 @Charan-hs! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Charan-hs · 2023-07-12T06:16:24Z

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01a9705854f8d26ed1

melvin-bot · 2023-07-12T06:16:27Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

abdulrahuman5196 · 2023-07-14T14:07:05Z

Will check on this in morning

abdulrahuman5196 · 2023-07-15T07:38:37Z

On @PrashantMangukiya 's proposal here #22306 (comment), the root cause is correct but I am not aligned with the solution to check and consider empty file type as a folder, since there could be file with empty file type.

abdulrahuman5196 · 2023-07-15T07:41:40Z

@alitoshmatov 's proposal #22306 (comment) here mentions to block all empty file types since backend doesn't allow it. I don't think we should block files without extension, I think should be raised as a separate bug on why backend doesn't allow it, maybe we can confirm the same with internal engineer on if this is the expected behaviour.

abdulrahuman5196 · 2023-07-15T07:43:03Z

@Charan-hs 's proposal here #22306 (comment) uses webkitGetAsEntry which provides way of checking if the drop item is a file or folder which seems good IMO. Could you provide information on how you would implement the same in expensify app codebase?

Charan-hs · 2023-07-15T09:56:11Z

@abdulrahuman5196

Hi, we can implement proposed changes i.e using webkitGetAsEntry.

1. Changes in Drag and Drop Component (with two different ways).

Considering the suggested changes i.e adding eventListeners to dropZone rather than to entire document and then adding webkitdirectory attribute to that dropZone.
Current File

App/src/components/DragAndDrop/index.js

Lines 93 to 109 in acf9ced

    
           addEventListeners() { 
        
               this.dropZone = document.getElementById(this.props.dropZoneId); 
        
               this.dropZoneRect = this.calculateDropZoneClientReact(); 
        
               document.addEventListener('dragover', this.dropZoneDragListener); 
        
               document.addEventListener('dragenter', this.dropZoneDragListener); 
        
               document.addEventListener('dragleave', this.dropZoneDragListener); 
        
               document.addEventListener('drop', this.dropZoneDragListener); 
        
               window.addEventListener('resize', this.throttledDragNDropWindowResizeListener); 
        
           } 
        
           removeEventListeners() { 
        
               document.removeEventListener('dragover', this.dropZoneDragListener); 
        
               document.removeEventListener('dragenter', this.dropZoneDragListener); 
        
               document.removeEventListener('dragleave', this.dropZoneDragListener); 
        
               document.removeEventListener('drop', this.dropZoneDragListener); 
        
               window.removeEventListener('resize', this.throttledDragNDropWindowResizeListener); 
        
           }

With suggested changes.

addEventListeners() {
        
        this.dropZone = document.getElementById(this.props.dropZoneId);
        this.dropZone.setAttribute("webkitdirectory","")
        this.dropZoneRect = this.calculateDropZoneClientReact();
        this.dropZone.addEventListener('dragover', this.dropZoneDragListener);
        this.dropZone.addEventListener('dragenter', this.dropZoneDragListener);
        this.dropZone.addEventListener('dragleave', this.dropZoneDragListener);
        this.dropZone.addEventListener('drop', this.dropZoneDragListener);
        window.addEventListener('resize', this.throttledDragNDropWindowResizeListener);
        
    }

    removeEventListeners() {
        this.dropZone = document.getElementById(this.props.dropZoneId);
        this.dropZone.removeAttribute("webkitdirectory")
        this.dropZone.removeEventListener('dragover', this.dropZoneDragListener);
        this.dropZone.removeEventListener('dragenter', this.dropZoneDragListener);
        this.dropZone.removeEventListener('dragleave', this.dropZoneDragListener);
        this.dropZone.removeEventListener('drop', this.dropZoneDragListener);
        window.removeEventListener('resize', this.throttledDragNDropWindowResizeListener);
    }

without suggested changes i.e adding webkitdirectory attribute to Entire Document

   addEventListeners() {
        this.dropZone = document.getElementById(this.props.dropZoneId);
        document.documentElement.setAttribute('webkitdirectory',"")
        this.dropZoneRect = this.calculateDropZoneClientReact();
        document.addEventListener('dragover', this.dropZoneDragListener);
        document.addEventListener('dragenter', this.dropZoneDragListener);
        document.addEventListener('dragleave', this.dropZoneDragListener);
        document.addEventListener('drop', this.dropZoneDragListener);
        window.addEventListener('resize', this.throttledDragNDropWindowResizeListener);
        
    }

    removeEventListeners() {
        document.documentElement.removeAttribute('webkitdirectory')
        document.removeEventListener('dragover', this.dropZoneDragListener);
        document.removeEventListener('dragenter', this.dropZoneDragListener);
        document.removeEventListener('dragleave', this.dropZoneDragListener);
        document.removeEventListener('drop', this.dropZoneDragListener);
        window.removeEventListener('resize', this.throttledDragNDropWindowResizeListener);
    }

2. OnDropChanges

Currently

App/src/pages/home/report/ReportActionCompose.js

Lines 1131 to 1134 in b9508b6

    
           const file = lodashGet(e, ['dataTransfer', 'files', 0]); 
        
           displayFileInModal(file);

Changes
Here we will get items from dataTransfer object then pass it on to displayFileInModal
we can get File from calling data.getAsFile()

 const data = lodashGet(e, ['dataTransfer', 'items', 0]);                                                
displayFileInModal(data);

3. IsValidFile

here we can Check File type then throw an Error "File Type Not Supported"

 if (typeof _data.webkitGetAsEntry === 'function') {
                const entry = _data.webkitGetAsEntry();
                checkFileorFolder(entry);
               // entry Object has isDirectory property
            }

In near future we can get files from the folder then Upload using

const entryContent = await readEntryContentAsync(entry);

Charan-hs · 2023-07-21T10:22:56Z

@abdulrahuman5196 @luacmartins Created a PR #23321
Tested All the scenarios in Chrome, and Safari for Drag and drop and Add attachments from + icon.

alitoshmatov · 2023-07-22T06:26:53Z

I think should be raised as a separate bug on why backend doesn't allow it, maybe we can confirm the same with internal engineer on if this is the expected behaviour.

@abdulrahuman5196
Can you raise an issue for this or should I report it in slack?

melvin-bot · 2023-07-26T20:27:57Z

Triggered auto assignment to @LLPeckham (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

luacmartins · 2023-07-26T20:28:27Z

@LLPeckham can you please review the copy below? This is an error message we'll display to users when they try to upload an entire folder in NewDot

Uploading folder is not allowed.

LLPeckham · 2023-07-27T13:13:21Z

@luacmartins -- What about: Uploading a folder is not allowed. Try a different file. -- LMK if it's too long adding the "try a different file" line - just thought it could be good to give them a next step after we tell them a folder is not allowed.

luacmartins · 2023-07-27T15:42:57Z

Sounds good! Thank you!

sakluger · 2023-08-01T15:53:07Z

Looks like the PR is continuing to make progress.

luacmartins · 2023-08-02T20:25:50Z

PR is in review

melvin-bot · 2023-08-03T16:40:05Z

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

when @Charan-hs got assigned: 2023-07-20 18:59:25 Z
when the PR got merged: 2023-08-03 16:40:05 UTC
days elapsed: 9

On to the next one 🚀

sakluger · 2023-08-09T00:05:11Z

Hey @luacmartins I'm a bit confused with the PR, why is it showing the deploy messages twice?

abdulrahuman5196 · 2023-08-09T11:05:18Z

@sakluger I think there has been some issue with melvin. This change was pushed to production on Aug 7 #23321 (comment). This issue should be made to hold for payment on Aug 14. Can we kindly change it manually?

abdulrahuman5196 · 2023-08-12T19:02:16Z

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. Folder uploaded was not supported and we wheren't showing proper message from implementation itself.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Minor bug to show proper error mesage in case of folders, so a regression test won't be beneficial.

Charan-hs · 2023-08-13T02:13:31Z

@abdulrahuman5196 Error message has been approved here #22306 (comment)

sakluger · 2023-08-14T20:15:21Z

All paid up! Thanks everyone.

kbecciv added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 5, 2023

melvin-bot bot assigned sakluger Jul 5, 2023

melvin-bot bot added the Overdue label Jul 10, 2023

melvin-bot bot removed the Overdue label Jul 10, 2023

sakluger added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Jul 10, 2023

melvin-bot bot changed the title ~~Web - Appropriate message is not shown when drag&drop a folder.~~ [$1000] Web - Appropriate message is not shown when drag&drop a folder. Jul 10, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 10, 2023

melvin-bot bot assigned abdulrahuman5196 Jul 10, 2023

melvin-bot bot added the Overdue label Jul 13, 2023

melvin-bot bot removed the Overdue label Jul 14, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 21, 2023

luacmartins added the Waiting for copy User facing verbiage needs polishing label Jul 26, 2023

melvin-bot bot assigned LLPeckham Jul 26, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 26, 2023

sakluger removed the Waiting for copy User facing verbiage needs polishing label Aug 1, 2023

sakluger changed the title ~~[$1000] Web - Appropriate message is not shown when drag&drop a folder.~~ [HOLD for payment 2023-08-14] [$1000] Web - Appropriate message is not shown when drag&drop a folder. Aug 10, 2023

sakluger added Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2 and removed Reviewing Has a PR in review Daily KSv2 labels Aug 10, 2023

sakluger added Daily KSv2 and removed Weekly KSv2 labels Aug 14, 2023

sakluger closed this as completed Aug 14, 2023

alitoshmatov mentioned this issue Aug 22, 2023

[$1000] uploading EPS extension file throws an error #24497

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-08-14] [$1000] Web - Appropriate message is not shown when drag&drop a folder. #22306

[HOLD for payment 2023-08-14] [$1000] Web - Appropriate message is not shown when drag&drop a folder. #22306

kbecciv commented Jul 5, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023 •

edited by sakluger

Loading

PrashantMangukiya commented Jul 6, 2023 •

edited

Loading

sakluger commented Jul 10, 2023

melvin-bot bot commented Jul 10, 2023

melvin-bot bot commented Jul 10, 2023

melvin-bot bot commented Jul 10, 2023

alitoshmatov commented Jul 11, 2023

Charan-hs commented Jul 11, 2023 •

edited

Loading

melvin-bot bot commented Jul 11, 2023

Charan-hs commented Jul 12, 2023

melvin-bot bot commented Jul 12, 2023

abdulrahuman5196 commented Jul 14, 2023

abdulrahuman5196 commented Jul 15, 2023

abdulrahuman5196 commented Jul 15, 2023

abdulrahuman5196 commented Jul 15, 2023

Charan-hs commented Jul 15, 2023

Charan-hs commented Jul 21, 2023

alitoshmatov commented Jul 22, 2023

melvin-bot bot commented Jul 26, 2023

luacmartins commented Jul 26, 2023

LLPeckham commented Jul 27, 2023

luacmartins commented Jul 27, 2023

sakluger commented Aug 1, 2023

luacmartins commented Aug 2, 2023

melvin-bot bot commented Aug 3, 2023

sakluger commented Aug 9, 2023

abdulrahuman5196 commented Aug 9, 2023 •

edited

Loading

abdulrahuman5196 commented Aug 12, 2023

Charan-hs commented Aug 13, 2023

sakluger commented Aug 14, 2023

[HOLD for payment 2023-08-14] [$1000] Web - Appropriate message is not shown when drag&drop a folder. #22306

[HOLD for payment 2023-08-14] [$1000] Web - Appropriate message is not shown when drag&drop a folder. #22306

Comments

kbecciv commented Jul 5, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023 • edited by sakluger Loading

Bug0 Triage Checklist (Main S/O)

PrashantMangukiya commented Jul 6, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

sakluger commented Jul 10, 2023

melvin-bot bot commented Jul 10, 2023

melvin-bot bot commented Jul 10, 2023

melvin-bot bot commented Jul 10, 2023

alitoshmatov commented Jul 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Charan-hs commented Jul 11, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Detailed steps

1. Changes in Drag and Drop Component.

2. OnDropChanges

3. IsValidFile

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jul 11, 2023

Charan-hs commented Jul 12, 2023

melvin-bot bot commented Jul 12, 2023

abdulrahuman5196 commented Jul 14, 2023

abdulrahuman5196 commented Jul 15, 2023

abdulrahuman5196 commented Jul 15, 2023

abdulrahuman5196 commented Jul 15, 2023

Charan-hs commented Jul 15, 2023

1. Changes in Drag and Drop Component (with two different ways).

2. OnDropChanges

3. IsValidFile

Charan-hs commented Jul 21, 2023

alitoshmatov commented Jul 22, 2023

melvin-bot bot commented Jul 26, 2023

luacmartins commented Jul 26, 2023

LLPeckham commented Jul 27, 2023

luacmartins commented Jul 27, 2023

sakluger commented Aug 1, 2023

luacmartins commented Aug 2, 2023

melvin-bot bot commented Aug 3, 2023

sakluger commented Aug 9, 2023

abdulrahuman5196 commented Aug 9, 2023 • edited Loading

abdulrahuman5196 commented Aug 12, 2023

Charan-hs commented Aug 13, 2023

sakluger commented Aug 14, 2023

kbecciv commented Jul 5, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 5, 2023 •

edited by sakluger

Loading

PrashantMangukiya commented Jul 6, 2023 •

edited

Loading

Charan-hs commented Jul 11, 2023 •

edited

Loading

abdulrahuman5196 commented Aug 9, 2023 •

edited

Loading