[HOLD for payment 2023-08-08] [$1000] Android - User icons overlapping in the group header and outline is not showing perfectly.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open App and Go offline
2. Press FAB > New Group
3. Select 8 participants > Press Create Group
4. Observe the page Header where one avatar of the user and +7 are written & also observe the 8 Avatars in the Chat Header

Expected Result:

Chat header icons should be like the ios where we can not see the avatar of another user from semi-transparent background.

Actual Result:

Chat header icons should be like the ios where icons do not overlap another icon.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230715_154037_Expensify.Chat.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689364266408539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194b561dccf84201f
• Upwork Job ID: 1681461212925595648
2023-07-19
• Automatic offers:
• s77rt | Reviewer | 25762373
• jayeshmangwani | Contributor | 25762376
• jayeshmangwani | Reporter | 25762379

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

from: @jayeshmangwani

Please re-state the problem that we are trying to solve in this issue.

User icons overlapping in the group header and outline is not showing perfectly.

What is the root cause of that problem?

On Android, when we apply opacity to a parent, all of its children will inherit the opacity; context is here in the issue

What changes do you think we should make in order to solve the problem?

We need to pass needsOffscreenAlphaCompositing prop to the OfflineWithFeedback parent Of the Group page Header and Chat header Components here so that Android can align with other platforms and child does not inherit the opacity

At these two places, we need to add the needsOffscreenAlphaCompositing prop to OfflineWithFeedback

1. For Report screen header

App/src/pages/home/ReportScreen.js

Lines 330 to 333 in 0b00e1c

	<OfflineWithFeedback
	pendingAction={addWorkspaceRoomOrChatPendingAction}
	errors={addWorkspaceRoomOrChatErrors}
	shouldShowErrorMessages={false}

2. For Chat Header where 8 users Avatar is visible

App/src/pages/home/report/ReportActionItemCreated.js

Lines 58 to 62 in 0b00e1c

	<OfflineWithFeedback
	pendingAction={lodashGet(props.report, 'pendingFields.addWorkspaceRoom') || lodashGet(props.report, 'pendingFields.createChat')}
	errors={lodashGet(props.report, 'errorFields.addWorkspaceRoom') || lodashGet(props.report, 'errorFields.createChat')}
	errorRowStyles={[styles.ml10, styles.mr2]}
	onClose={() => Report.navigateToConciergeChatAndDeleteReport(props.report.reportID)}

This Same Issue happens at a few places on the Android

1. Workspace Thread header

2. LHN OptionsList

We also need to add the needsOffscreenAlphaCompositing prop to parent OfflineWithFeedback.

App/src/components/OptionRow.js

Lines 148 to 151 in 0b00e1c

	<OfflineWithFeedback
	pendingAction={this.props.option.pendingAction}
	errors={this.props.option.allReportErrors}
	shouldShowErrorMessages={false}

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 134 to 137 in 0b00e1c

	<OfflineWithFeedback
	pendingAction={optionItem.pendingAction}
	errors={optionItem.allReportErrors}
	shouldShowErrorMessages={false}

Note: We will test all the overlapping icons offline on Android in part of this issue so that those can be fixed in this single issue

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User icons overlapping in the group header and outline is not showing perfectly.

What is the root cause of that problem?

On Android, when we apply opacity to a parent, all of its children will inherit the opacity; context is here in the issue

What changes do you think we should make in order to solve the problem?

We need to pass needsOffscreenAlphaCompositing prop to the OfflineWithFeedback parent Of the Group page Header and Chat header Components here so that Android can align with other platforms and child does not inherit the opacity

At these two places, we need to add the needsOffscreenAlphaCompositing prop to OfflineWithFeedback

1. For Report screen header

App/src/pages/home/ReportScreen.js

Lines 330 to 333 in 0b00e1c

	<OfflineWithFeedback
	pendingAction={addWorkspaceRoomOrChatPendingAction}
	errors={addWorkspaceRoomOrChatErrors}
	shouldShowErrorMessages={false}

2. For Chat Header where 8 users Avatar is visible

App/src/pages/home/report/ReportActionItemCreated.js

Lines 58 to 62 in 0b00e1c

	<OfflineWithFeedback
	pendingAction={lodashGet(props.report, 'pendingFields.addWorkspaceRoom') || lodashGet(props.report, 'pendingFields.createChat')}
	errors={lodashGet(props.report, 'errorFields.addWorkspaceRoom') || lodashGet(props.report, 'errorFields.createChat')}
	errorRowStyles={[styles.ml10, styles.mr2]}
	onClose={() => Report.navigateToConciergeChatAndDeleteReport(props.report.reportID)}

This Same Issue happens at a few places on the Android

1. Workspace Thread header

2. LHN OptionsList

We also need to add the needsOffscreenAlphaCompositing prop to parent OfflineWithFeedback.

App/src/components/OptionRow.js

Lines 148 to 151 in 0b00e1c

	<OfflineWithFeedback
	pendingAction={this.props.option.pendingAction}
	errors={this.props.option.allReportErrors}
	shouldShowErrorMessages={false}

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 134 to 137 in 0b00e1c

	<OfflineWithFeedback
	pendingAction={optionItem.pendingAction}
	errors={optionItem.allReportErrors}
	shouldShowErrorMessages={false}

Note: We will test all the overlapping icons offline on Android in part of this issue so that those can be fixed in this single issue

[melvin-bot]

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0194b561dccf84201f

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[michaelhaxhiu]

reproduced!

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - User icons overlapping in the group header and outline is not showing perfectly.

What is the root cause of that problem?

On Android, when we apply opacity to a parent, all of its children will inherit the opacity
https://twitter.com/kzzzf/status/1075450650975195136

In the first PR where needsOffscreenAlphaCompositing was introduced. In that issue their focus was only to fix IOU previews opacity so they passed the prop to set needsOffscreenAlphaCompositing but this issue is bigger than just IOU preview.

These are 3 checks they were using to set needsOffscreenAlphaCompositing

1. For Android platform only
2. If needsOpacity of OfflineWithFeedback is true
3. IOUPreview component only (by passing prop)

What changes do you think we should make in order to solve the problem?

There's no need to pass props to set needsOffscreenAlphaCompositing

App/src/components/OfflineWithFeedback.js

Line 113 in ee2d4fd

needsOffscreenAlphaCompositing={shouldRenderOffscreen ? needsOpacity && props.needsOffscreenAlphaCompositing : undefined}

With the first check, we ensure that it is only applied on Android, as this issue exists only on Android. With the second check, we verify if the component needsOpacity. If it is true, we can set needsOffscreenAlphaCompositing.

needsOffscreenAlphaCompositing={shouldRenderOffscreen ? needsOpacity : undefined}

By making this change this issue will be fixed across app.

What alternative solutions did you explore? (Optional)

[s77rt]

Started a Slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1689793295080599

[s77rt]

Not overdue. Based on the latest discussion on the slack thread, the use of needsOffscreenAlphaCompositing may cause some "incompatibilities". In this case the global fix seems less favorable but I think it's still worth it as those incompatibilities can be fixed. I have bumped the thread for more 👀.

[s77rt]

Not overdue, Melvin. No activity on that Slack thread yet but we will probably go with a solution this week

[s77rt]

From the Slack discussion we want to move with the "Only apply the fix when needed" approach. In that case we can move with @jayeshmangwani's proposal.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[jayeshmangwani]

@s77rt PR is ready for Review

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @jayeshmangwani, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @jayeshmangwani got assigned: 2023-07-26 11:44:54 Z
• when the PR got merged: 2023-07-28 11:44:54 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed offline Android overlapping icons #23710

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @jayeshmangwani requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: None. This is an Android thing
• The offending PR has been commented on: n/a
• A discussion in #expensify-bugs has been started: We have this (#expensify-open-source) https://expensify.slack.com/archives/C01GTK53T8Q/p1689793295080599
• Determine if we should create a regression test for this bug: No

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[michaelhaxhiu]

Note: I'm preparing to go OOO for ~2 weeks and need a BZ buddy to watch over this in the meantime. 🙏

Next steps:

Wait for 8/8 to arrive. After that's done, we'll process payments as follows (assuming no regressions 🤞):

• Bug reporter & Contributor that fixed it $1750 ($1500 + $250) for @jayeshmangwani
• C+ $1500 for @s77rt

I'll take this over when I return if it's not complete. Thanks in advance @kadiealexander

[kadiealexander]

https://www.upwork.com/ab/applicants/1681461212925595648/hired

[kadiealexander]

Everyone is paid! 🎉