[HOLD for payment 2023-09-29] [$1000] Android - Sign in background image is missing

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Sign out if you are signed in

Expected Result:

There is a background image

Actual Result:

No background image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.57-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

0-02-01-cf6e67ca431b3629d763c0a1ca4406c405616e076cd67231faa69c96c42d7bfc_c413990cbea152b7.mp4

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692337365083379

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad21987d10429685
• Upwork Job ID: 1696343238604079104
• Last Price Increase: 2023-09-05
• Automatic offers:
• hoangzinh | Contributor | 26515059
• bernhardoj | Reporter | 26515062

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Sign in background image is missing

What is the root cause of that problem?

In the Background image for Android platform, we just export a SVG component

App/src/pages/signin/SignInPageLayout/BackgroundImage/index.android.js

Lines 1 to 3 in bd81e8c

	import backgroundImage from '../../../../../assets/images/home-background--android.svg';
	export default backgroundImage;

We haven't added width/style for it as same as other platforms

App/src/pages/signin/SignInPageLayout/BackgroundImage/index.js

Lines 18 to 22 in bd81e8c

	<MobileBackgroundImage
	pointerEvents={props.pointerEvents}
	width={props.width}
	style={styles.signInBackground}
	/>

What changes do you think we should make in order to solve the problem?

We need to add width & style & pointerEvents props same as other platforms for this SVG component of Android platform

App/src/pages/signin/SignInPageLayout/BackgroundImage/index.android.js

Lines 1 to 3 in bd81e8c

	import backgroundImage from '../../../../../assets/images/home-background--android.svg';
	export default backgroundImage;

Results:

[jliexpensify]

I can't repro this on Android Chrome (v57-3):

[jliexpensify]

Android app is on 58-1, and I can reproduce!

[jliexpensify]

Also, on the Android app, you can scroll down - this definitely looks off. Not sure what's happening here, I've never seen this before:

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad21987d10429685

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[jliexpensify]

Wow sorry, huge delays from GH! Removed Miroslav, sorry!

[hamzasaleem2]

### Potential issue

Background image is connected through both index.js and SignInPageContent

Will have to fix it by doing following tests:

Add a static test image or background color to the BackgroundImage component to see if the problem is with the image file itself or the way it's being rendered.

Use console logging or debugging tools to inspect the values of dynamic variables or props like shouldShowSmallScreen or variables.signInHeroBackgroundWidth.

Log the scrollViewRef and props to ensure they are being set as expected.

If these of above doesn't pin point the issue then simply will have to isolate the component and test it on a simpler layout.

src/pages/signin/SignInPageLayout/index.js

src/pages/signin/SignInPageLayout/SignInPageContent.js

Waiting for assign and access! Already have account on expensify.

This is my First potential assignment for expensify.
Applied on Upwork

[melvin-bot]

📣 @hamzasaleem2! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[hamzasaleem2]

Contributor details
Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/hamzasaleem

### Potential issue

Background image is connected through both index.js and SignInPageContent

Will have to fix it by doing following tests:

Add a static test image or background color to the BackgroundImage component to see if the problem is with the image file itself or the way it's being rendered.

Use console logging or debugging tools to inspect the values of dynamic variables or props like shouldShowSmallScreen or variables.signInHeroBackgroundWidth.

Log the scrollViewRef and props to ensure they are being set as expected.

If these of above doesn't pin point the issue then simply will have to isolate the component and test it on a simpler layout.

src/pages/signin/SignInPageLayout/index.js

src/pages/signin/SignInPageLayout/SignInPageContent.js

Waiting for assign and access! Already have account on expensify.

This is my First potential assignment for expensify. Applied on Upwork

[mananjadhav]

I am afk, but I'll have these reviewed later today.

[mananjadhav]

@hoangzinh's proposal looks good to me.

🎀 👀 🎀 C+ reviewed.

[roryabraham]

Actually, I changed my mind. When we made the announcement we said it wouldn't affect existing jobs so I'll set this back to $1000

[hoangzinh]

@mananjadhav @roryabraham Thanks for accepting my proposal. The PR is ready here #26923. Please help me review it. Thanks

[hoangzinh]

@roryabraham could you help to update the Offer link here? #26069 (comment). It's only 500$. Thanks in advance.

[jliexpensify]

@hoangzinh - I'll handle payments and will do a payment summary before any payouts, so this will be manually adjusted later.

[mananjadhav]

PR Reviewed and approved. I am not sure if we want to merge this within the merge freeze.

[jliexpensify]

It's probably up to the discretion of @roryabraham as the Engineer, but I would imagine not, as it's not related to SmartScan or distance requests.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hoangzinh got assigned: 2023-09-05 20:55:31 Z
• when the PR got merged: 2023-09-20 01:02:51 UTC
• days elapsed: 10

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix background image is missing in Android native app #26923

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @hoangzinh requires payment offer (Contributor)
• @bernhardoj requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav / @hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav / @hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav / @hoangzinh] Determine if we should create a regression test for this bug.
• [@mananjadhav / @hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment Summary:

• Bug Reporter: @bernhardoj $250
• Contributor: @hoangzinh $1000
• C+: @mananjadhav $1000 - request on New.Dot

Upwork job

@roryabraham - we're not penalising anyone due to the merge freeze right?

[roryabraham]

Correct, no penalties here

[jliexpensify]

Sorry everyone! I was OOO, paying now.

[jliexpensify]

Paid out in Upworks and closed the job.

@mananjadhav still awaiting for you to complete the checklist, thanks!

[mananjadhav]

We added the component in this PR. I've added a comment here.

But I don't think we need a regression test here.

[jliexpensify]

Cool, closing this one - @mananjadhav here is the payment summary

[JmillsExpensify]

$1,000 payment approved for @mananjadhav based on BZ summary.