-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-13] [$250] [Distance] - Next button hidden and unable to complete distance money request #26737
Comments
Triggered auto assignment to @alexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Distance - Next button hidden and unable to complete distance money request What is the root cause of that problem?In our DistanceRequest page, we have difference view with difference What changes do you think we should make in order to solve the problem?We should wrap the content (except the < >
<View style={[styles.flex1, styles.overflowHidden]}>
{/** All the content */}
</View >
<FixedFooter style={[styles.w100, styles.ph4, styles.flexShrink0]}>
<Button
success
onPress={() => IOU.navigateToNextPage(iou, iouType, reportID, report)}
isDisabled={_.size(validatedWaypoints) < 2}
text={translate('common.next')}
/>
</FixedFooter >
What alternative solutions did you explore? (Optional)N/A ResultScreen.Recording.2023-09-05.at.10.32.29.mov |
oh found out it's dupe of: #26541 |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @Gonals ( |
PR being cherry picked to staging |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-12. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
PR is being CPed |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.64-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-13. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-15. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@alexpensify Just checking in here. My PR for this was initially deployed to production on 2023-09-06 (reference), so it looks like the correct payment date is 2023-09-13, and the bot got a little carried away. @mountiny Do I need to do anything with the checklist here? |
I think we dont need the cheklist here as it was a new feature for the conference so not really regressions |
@akinwale - sorry, I was OOO the past two days and still catching up. I thought the payment date was on September 15, so that's why I didn't reassign. Can you please apply for the job here: https://www.upwork.com/jobs/~0166ea6d21ec0ea15e? Tomorrow, I'll complete the payment process. Thanks! |
@alexpensify Applied. Thanks! |
Thanks, I've continued the process in Upwork and need you to accept @akinwale. |
@alexpensify Accepted, thanks. |
Awesome, I've completed the process in Upwork. Thanks for your help here! |
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~0166ea6d21ec0ea15e *If applicable, the bonuses will be applied on the final payment Extra Notes regarding payment: N/A |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #26601
Action Performed:
Expected Result:
Next Button visible to select or page scrollable to select Next button
Actual Result:
Next button hidden and unable to scroll the page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.63-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: