[HOLD for payment 2023-09-29] [$500] Mweb-IOU- In distance request money, the address suggessions are fetched in forced offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap profile icon
   3.Tap Preferences
   4.Toggle on Forced offline
   5.Navigate to LHN
   6.Tap FAB
3. Tap request Money
   8.Tap Distance
   9.Tap Start
   10.Enter few characters of an address
   11.Turn off mobile data
   12.Enter few characters of an address

Expected Result:

In distance request money, If we turn off mobile data, the address suggestions are not fetched.
Similarly, the address suggessions must not be fetched in forced offline.

Actual Result:

In distance request money, If we turn off mobile data, the address suggestions are not fetched.
But, the address suggessions are fetched in forced offline.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.64-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6189884_app.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:@

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01718c850ed1cc7d9c
• Upwork Job ID: 1700229247184764928
• Last Price Increase: 2023-09-08
• Automatic offers:
• akinwale | Contributor | 26694110

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In distance request money, the address suggessions are fetched in forced offline

What is the root cause of that problem?

The AddressSearch component uses the React Native Google Places Autocomplete module which implements its own logic and request handling for fetching data from a different API URL.

What changes do you think we should make in order to solve the problem?

Update AddressSearch by conditionally setting the url for the requestUrl object which the GooglePlacesAutocomplete component uses to null or an empty string when the should force offline option is enabled.

requestUrl={{
    useOnPlatform: 'all',
    url: props.network.shouldForceOffline ? null : ApiUtils.getCommandURL({command: 'Proxy_GooglePlaces&proxyUrl='}),
}}

Since shouldForceOffline being true also causes isOffline to be true, we can also use this to prevent requests from being processed.

requestUrl={{
    useOnPlatform: 'all',
    url: props.network.isOffline ? null : ApiUtils.getCommandURL({command: 'Proxy_GooglePlaces&proxyUrl='}),
}}

Since this approach leads to a console error when trying to search for addresses, I also propose implementing a change in the upstream module (Google Places Autocomplete) to add a condition to specifically not send requests if requestUrl.url has been explicitly set to null, undefined or an empty string. Since Expensify maintains a fork of this module (https://github.com/Expensify/react-native-google-places-autocomplete), we can make the following change in the _request method in GooglePlacesAutoComplete.js.

const _request = (text) => {
  _abortRequests();
+  if (!url) {
+    return;
+  }
  if (supportedPlatform() && text && text.length >= props.minLength) {
// ...

What alternative solutions did you explore? (Optional)

None.

[mountiny]

The forced offline is mainly staging feature, I dont think this is a deploy blocker

[Christinadobrzyn]

I think this is similar - #26478 (comment) - asking

[Christinadobrzyn]

This issue is different and I think it can be external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01718c850ed1cc7d9c

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In distance request money, the address suggessions are fetched in forced offline

What is the root cause of that problem?

In forced offlined, we only prevent making API from the App repository. But we still can call the API from libraries. In this case
https://github.com/Expensify/react-native-google-places-autocomplete/blob/4324dd7b156075d1817fea60b007584fa73b08ea/GooglePlacesAutocomplete.js#L546-L552

We are making requests in react-native-google-places-autocomplete library. So that the API still can executed

What changes do you think we should make in order to solve the problem?

I suggest that we should pass isOffline props to GooglePlacesAutocomplete and in GooglePlacesAutocomplete we will prevent making API if isOffline is true

In here
https://github.com/Expensify/react-native-google-places-autocomplete/blob/4324dd7b156075d1817fea60b007584fa73b08ea/GooglePlacesAutocomplete.js#L502C1-L502C1

we should update like this

if (supportedPlatform() && text && text.length >= props.minLength && !props.isOffline)

[Christinadobrzyn]

hey @allroundexperts can you let me know what you think of #26869 (comment)

[allroundexperts]

Thanks for your proposal @DylanDylann. I think your proposal is having essentially the same concept as what @akinwale proposed earlier. Since they were first to propose the working solution, I think we should go with @akinwale's proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @nkuoch is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[akinwale]

@nkuoch @allroundexperts My main PR is ready for review.

I have also created the dependency PR in the Google Places Autocomplete repo. There are currently no reviewers assigned, but it will require a review as well before merging.

[melvin-bot]

🎯 ⚡️ Woah @allroundexperts / @akinwale, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @akinwale got assigned: 2023-09-15 14:10:22 Z
• when the PR got merged: 2023-09-19 09:57:41 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent fetching address suggestions in forced offline mode #27542

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment offer (Contributor)
• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

@allroundexperts do we want to regression test for this?

Payouts due:

Issue Reporter: NA
Contributor: $500 + $250 bonus @akinwale (paid in Upwork)
Contributor+: $500 + $250 bonus @allroundexperts (paid in NewExpensify)

Eligible for 50% #urgency bonus? Y - #26869 (comment)

Upwork job is here.

[allroundexperts]

Not really. This was a dev only feature which doesn't affect end users.

[Christinadobrzyn]

Sounds good! Thank you! I've paid this out.

Closing, feel free to reopen if needed!

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.