Timezone - Dropdown is selectable when the "Set my time zone" bottom checkbox is checked

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Expected Result:

Dropdown should be disabled if the bottom checkbox is checked

Actual Result:

Dropdown is selectable when the "Set my time zone" bottom checkbox is checked

Action Performed:

1. Go to https://staging.expensify.cash
2. Log in with any account
3. Go to Setting - Profile
4. Scroll down to Time zone field
5. Set my time zone automatically should be selected
6. Try to chose other time zone

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.42-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5063900_Recording__76.mp4

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/163784

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @Dal-Papa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @marklouisdeshaun (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[marklouisdeshaun]

Upwork job posting

[MelvinBot]

Triggered auto assignment to @marcaaron (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dklymenk]

While I can see that you pass disabled prop to Picker in src/pages/settings/Profile/ProfilePage.js, you don't actually pass it to RNPickerSelect in src/components/Picker/index.js.

So the fix is simply to add disabled to the list of destructed props of Picker component and pass it to RNPickerSelect.

[marcaaron]

Nice catch @dklymenk. Can we please also update the propTypes here so that it's clear we are passing this prop -> https://github.com/Expensify/Expensify.cash/blob/3fad8d181165842897e7259ecfbfe591976cf381/src/components/Picker/PickerPropTypes.js#L3

[marcaaron]

@marklouisdeshaun the solution from @dklymenk LGTM

[dklymenk]

Actually reproduced the issue on both web and android, so the issue is not web only.

I submitted a draft PR with a fix #2824 , I'll test tomorrow for regressions on iOS and desktop app and remove draft label.

Thank you.

[dklymenk]

Confirm the fix works on all platforms. PR is ready for review