[HOLD for payment 2023-10-23] Send Money - Arrow is missing on date and merchant field

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.81.5
Reproducible in staging?: y
Reproducible in production?: no ( send money just implemented)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697005474290679

Action Performed:

1. Click on FAB and select send money
2. Enter amount and select user
3. Click on show more

Expected Result:

It should show arrow icon beside date and merchant

Actual Result:

It does not show arrow icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-11.at.11.52.26.AM.mov

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017f1148f05a8f4e87
• Upwork Job ID: 1712176568336138240
• Last Price Increase: 2023-10-11

[Nathan-Mulugeta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want to hide the merchant and date fields. As per this comment

If in the manual send money flow, yeah, I think we can hide the merchant and date fields.

What is the root cause of that problem?

The root cause of this problem is here on these two lines:

App/src/components/MoneyRequestConfirmationList.js

Line 552 in 07b9924

{shouldShowSmartScanFields && (

and

App/src/components/MoneyRequestConfirmationList.js

Line 574 in 07b9924

{shouldShowSmartScanFields && (

We are not checking if it is a request type before rendering the merchant and date fields.

What changes do you think we should make in order to solve the problem?

We can add a check if it is a request type and render the fields only when it is a request type not when it is a send money flow by changing this line of code:

 {shouldShowSmartScanFields && (

To:

{shouldShowSmartScanFields && isTypeRequest && (

What alternative solutions did you explore? (Optional)

NA

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We have to hide the Merchant and Date Fields in Send Money Flow according to the Slack Conversation.

What is the root cause of that problem?

Logic missing to hide the Merchant and Date Fields in MoneyRequestConfirmationList

What changes do you think we should make in order to solve the problem?

We should add a variable isTypeSend and use it to hide the Merchant and Date fields.

const isTypeSend = props.iouType === CONST.IOU.MONEY_REQUEST_TYPE.SEND;

Only show the Merchant and Date fields if isTypeSend is not true:

{!isTypeSend &&
	...
}

[mountiny]

Taking this internally

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017f1148f05a8f4e87

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[parasharrajat]

Let me when PR is ready.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix couple of bugs in the Send money flow #29358

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix couple of bugs in the Send money flow #29358

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

@alexpensify only $50 needed for @gadhiyamanan for reportinga

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix couple of bugs in the Send money flow #29358

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix couple of bugs in the Send money flow #29358

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[mountiny]

No need for the checklist, deploy blocker was clear

#29330 (comment)

[melvin-bot]

@alexpensify, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

@alexpensify only need to pay $50 to @gadhiyamanan

[alexpensify]

Here is the payment summary:

• External issue reporter @gadhiyamanan $50
• Contributor that fixed the issue N/A
• Contributor+ that helped on the issue and/or PR N/A

Upwork Job: https://www.upwork.com/jobs/~017f1148f05a8f4e87

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: Payment was confirmed here #29330 (comment)

[alexpensify]

@gadhiyamanan - please accept in Upwork and I can complete the process. Thanks!

[gadhiyamanan]

@alexpensify offer accepted, thanks!

[alexpensify]

All set and paid in Upwork!