[HOLD for payment 2023-12-18] [$500] Web - FAB Menu - FAB menu is overlapping with FAB icon

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.1.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to Staging.new.expensify.com
2. Enter email address in 'Phone or email' input field & click on 'Continue' button
3. Open 'Gmail' app
4. Open email from Expensify and copy magic code
5. Open the tab where you are signing in
6. Paste the magic code in magic code input field

Expected Result:

FAB menu shouldn't overlap with FAB icon

Actual Result:

FAB menu overlaps with FAB icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2251be8f45d0652
• Upwork Job ID: 1726981704515780608
• Last Price Increase: 2023-11-21

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2251be8f45d0652

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[erquhart]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The fab menu is overlapping the fab button.

What is the root cause of that problem?

The fab button was made larger within the last week, but the menu position was not changed. No special steps are required, the fab button is now always overlapped by the fab menu on desktop/web.

A week ago:

Today:

What changes do you think we should make in order to solve the problem?

Update the menu position to account for the larger fab button.

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Web - FAB Menu - FAB menu is overlapping with FAB icon

What is the root cause of that problem?

This is due to the createMenuPositionSidebar function returning height based on screen height, which supplies position to anchorPosition for PopoverMenu.

What changes do you think we should make in order to solve the problem?

Change createMenuPositionSidebar to (height can be fine-tuned later)

createMenuPositionSidebar: (windowHeight: number) =>
            ({
                horizontal: 18,
                vertical: windowHeight - 80,
            } satisfies AnchorPosition),

What alternative solutions did you explore? (Optional)

[tienifr]

This PR #27660 makes that change, so I think it's changed on purpose

[situchan]

This should be handled as regression.
cc: @WojtekBoman as you fixed FAB size in #31310

[shubham1206agra]

cc @stitesExpensify

[WojtekBoman]

This should be handled as regression. cc: @WojtekBoman as you fixed FAB size in #31310

I will prepare a fix for this issue

[WojtekBoman]

#31679 - fix for this issue

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jasperhuangg]

PR still under review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix createMenuPositionSidebar style #31679

If no regressions arise, payment will be issued on 2023-12-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/357331

[akinwale]

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

#31310
The size of the FAB menu was changed, but the position was not adjusted. No additional steps need to be taken since this was an omission where styles were not updated.

• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Launch the Expensify app on desktop or web, and login if not currently signed in.
2. Click on the FAB icon.
3. Verify that the FAB menu does not overlap the FAB icon.

Do we agree 👍 or 👎?

[melvin-bot]

@akinwale, @jasperhuangg, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@akinwale, @jasperhuangg, @muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@akinwale, @jasperhuangg, @muttmuure Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@akinwale, @jasperhuangg, @muttmuure 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

@akinwale, @jasperhuangg, @muttmuure 12 days overdue. Walking. Toward. The. Light...

[jasperhuangg]

Bump @muttmuure! I think we just need to create the issue for the regression test and we should be good to close this out!

[akinwale]

@muttmuure It looks like I haven't received payment for this yet. Searched through allcontracts on Upwork.

[muttmuure]

@akinwale I've invited you to a new job:

https://www.upwork.com/jobs/~01916842f8437112a1

[akinwale]

@akinwale I've invited you to a new job:

https://www.upwork.com/jobs/~01916842f8437112a1

@muttmuure I can't access it. It still shows up as a private listing.

[akinwale]

@muttmuure I finally got the invite. I have submitted my proposal.

[muttmuure]

Paid up