[HOLD for payment 2024-01-25] [$500] BA - Animation in "One moment" page is smaller than other environments

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open Expensify app and log in
2. Go to Settings > Workspaces > Select a workspace > Bank account
3. Initiate the add bank account process until your reach "Company information" form
4. Fill out the form
5. Tap Save & continue, soy the "One moment" page is displayed

Expected Result:

The animation in "One moment" page should be bigger, like on mWeb covering a larger portion of the screen

Actual Result:

Animation in "One moment" page is smaller than other environments

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ab3b40d6502f686
• Upwork Job ID: 1735477945321639936
• Last Price Increase: 2023-12-15
• Automatic offers:
• alitoshmatov | Contributor | 28066410
• yh-0218 | Contributor | 28091490

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

We don't need to block deploy on this, but we should probably fix this + provide a new animation that matches the light theme.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015ab3b40d6502f686

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jasperhuangg]

@grgia assigning you since it looks like we'd also need a new animation to match the light theme.

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

BA - Animation in "One moment" page is smaller than other environments

What is the root cause of that problem?

incorrect style for Animation.

App/src/components/ReimbursementAccountLoadingIndicator.js

Lines 42 to 43 in 4592a7c

	style={styles.loadingVBAAnimation}
	webStyle={styles.loadingVBAAnimationWeb}

What changes do you think we should make in order to solve the problem?

loadingVBAAnimation reset width and height
loadingVBAAnimationWeb is not defined.

What alternative solutions did you explore? (Optional)

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Animation in "One moment" page is smaller than other environments

What is the root cause of that problem?

Incorrect styling being used here

App/src/components/ReimbursementAccountLoadingIndicator.js

Lines 42 to 43 in addfa88

	style={styles.loadingVBAAnimation}
	webStyle={styles.loadingVBAAnimationWeb}

What changes do you think we should make in order to solve the problem?

We can use same styling method that we are using here in SignInHeroImage

App/src/pages/signin/SignInHeroImage.js

Lines 44 to 45 in addfa88

	style={[styles.alignSelfCenter, imageSize]}
	webStyle={{...styles.alignSelfCenter, ...imageSize}}

App/src/pages/signin/SignInHeroImage.js

Lines 44 to 45 in addfa88

	style={[styles.alignSelfCenter, imageSize]}
	webStyle={{...styles.alignSelfCenter, ...imageSize}}

App/src/pages/signin/SignInHeroImage.js

Lines 21 to 37 in addfa88

	let imageSize;
	if (props.isSmallScreenWidth || props.shouldShowSmallScreen) {
	imageSize = {
	height: variables.signInHeroImageMobileHeight,
	width: variables.signInHeroImageMobileWidth,
	};
	} else if (props.isMediumScreenWidth) {
	imageSize = {
	height: variables.signInHeroImageTabletHeight,
	width: variables.signInHeroImageTabletWidth,
	};
	} else {
	imageSize = {
	height: variables.signInHeroImageDesktopHeight,
	width: variables.signInHeroImageDesktopWidth,
	};
	}

What alternative solutions did you explore? (Optional)

N/A

[yh-0218]

Hello, @alitoshmatov PR is ready for review. Thanks.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix animation in One moment #34243

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Contributor)
• @yh-0218 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alitoshmatov]

• The PR that introduced the bug has been identified. Link to the PR: Add confirmation page #13744

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/13744/files#diff-8ab8ba45ab927f1430b8d1209d187e003a9cdfe476f809e4483ef64cdba253ebR541-R542
  (Note: Was not able to comment on that PR, context)

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a

• Determine if we should create a regression test for this bug: I am 50/50 on this, provided regression test steps below if others want a regression test

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

• Go to any workspace
• Go to Bank account
• Start entering data manually
• Complete steps until you complete company information
• When One moment animation appears, make sure animation is not too small or too big

Do we agree 👍 or 👎

[alitoshmatov]

@grgia This one is ready for payment.

[alitoshmatov]

@grgia Kind bump

[yh-0218]

hi, @alitoshmatov How about my payment?

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[grgia]

@johncschuster

could you help with payment for this issue?

C+/Contributor owed $500

[melvin-bot]

@johncschuster, @grgia, @alitoshmatov, @yh-0218 Huh... This is 4 days overdue. Who can take care of this?

[johncschuster]

Sorry I missed your ping, @grgia! I'll work on payment now!

[johncschuster]

Payment has been issued! Thanks, @alitoshmatov and @yh-0218!