Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme Switching] 🐛 Android - Scan - Capture error and camera access pop-ups are not in dark mode #33138

Closed
1 of 6 tasks
lanitochka17 opened this issue Dec 15, 2023 · 5 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.13-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • App is in light mode
  • Camera settings permission is not allowed
  1. Launch New Expensify app
  2. Go to FAB > Request money > Scan
  3. Tap on the capture button
  4. Tap Continue button

Expected Result:

The pop-ups in Step 3 and 4 are in light mode

Actual Result:

The capture error and camera access pop-ups in Step 3 and 4 respectively remain in dark mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313917_1702605474626.Screen_Recording_20231215_093943_New_Expensify.mp4

Bug6313917_1702605474660!Screenshot_2023-12-15_095617

Bug6313917_1702605474612!Screenshot_2023-12-15_095634

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 15, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 15, 2023

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jasperhuangg
Copy link
Contributor

This seems to be the same issue as #33120 (the same component), and we're not blocking deploy on that one so I don't think we should block deploy here either.

@jasperhuangg jasperhuangg assigned grgia and unassigned jasperhuangg Dec 15, 2023
@grgia grgia changed the title Android - Scan - Capture error and camera access pop-ups are not in dark mode [Theme Switching] 🐛 Android - Scan - Capture error and camera access pop-ups are not in dark mode Dec 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

@grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@grgia
Copy link
Contributor

grgia commented Dec 18, 2023

Closing this in favor of #33235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants