Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme Switching] 🧼 Update Android modals to use native system modal #33235

Closed
grgia opened this issue Dec 18, 2023 · 11 comments
Closed

[Theme Switching] 🧼 Update Android modals to use native system modal #33235

grgia opened this issue Dec 18, 2023 · 11 comments
Assignees
Labels

Comments

@grgia
Copy link
Contributor

grgia commented Dec 18, 2023

Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1702657731582819

If this is a system dialog (which it is as it uses Roboto and San Francisco fonts), then I say they shouldn't have any additional customization as that means it'll get proper light/dark mode based on the system.

Relevant issues:
#33120
#33138
#33136

@grgia
Copy link
Contributor Author

grgia commented Jan 4, 2024

I need to get aligned on where we're at with this post holidays

@grgia
Copy link
Contributor Author

grgia commented Jan 17, 2024

Haven't had a chance to update this issue, but I am planning to open this externally once we center on intended behavior with design

@melvin-bot melvin-bot bot removed the Overdue label Jan 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@grgia
Copy link
Contributor Author

grgia commented Jan 30, 2024

back from OOO, I'll update this later this week- making daily so I dont forget

@melvin-bot melvin-bot bot removed the Overdue label Jan 30, 2024
@grgia grgia added Daily KSv2 and removed Weekly KSv2 labels Jan 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 1, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@grgia, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Feb 6, 2024

@grgia, @situchan Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Feb 8, 2024

@grgia, @situchan Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@grgia
Copy link
Contributor Author

grgia commented Feb 8, 2024

Still havent gotten to update this one

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@JmillsExpensify JmillsExpensify moved this from In Progress to Todo in Theme Switching / Light Mode Feb 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

@grgia, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Feb 14, 2024

@grgia, @situchan Eep! 4 days overdue now. Issues have feelings too...

@grgia grgia added Weekly KSv2 and removed Daily KSv2 labels Feb 14, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@grgia
Copy link
Contributor Author

grgia commented Feb 28, 2024

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 7, 2024
@grgia
Copy link
Contributor Author

grgia commented Mar 26, 2024

Closing this out for now

@grgia grgia closed this as completed Mar 26, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants