[HOLD for payment 2024-01-31] [$500] Android - IOU-App crashes on request money with new user on deleting request.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap fab---request money---manual
3. Enter an amount
4. Tap next
5. Select a new user
6. Tap request
7. Tap on IOU created to open IOU details page
8. Tap 3 dots on top right and note header is greyed out
9. Tap delete request and confirm delete

Expected Result:

App must not crash on request money with new user on deleting request.

Actual Result:

App crashes on request money with new user on deleting request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6328968_1703921841380.crash.mp4

log crash.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017ebef5d4acfc8b7d
• Upwork Job ID: 1741172356572065792
• Last Price Increase: 2023-12-30
• Automatic offers:
• aimane-chnaif | Reviewer | 28101997
• abzokhattab | Contributor | 28101998

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017ebef5d4acfc8b7d

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

📣 @rashidkarim11! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes on request money with new user on deleting request.

What is the root cause of that problem?

the parentReportActions object below is undefined when deleting a request for new users:

App/src/components/ReportActionItem/MoneyRequestView.js

Lines 344 to 352 in f2b74e8

	}),
	withOnyx({
	transaction: {
	key: ({report, parentReportActions}) => {
	const parentReportAction = parentReportActions[report.parentReportActionID];
	const transactionID = lodashGet(parentReportAction, ['originalMessage', 'IOUTransactionID'], 0);
	return `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`;
	},
	},

Here is the error log:

What changes do you think we should make in order to solve the problem?

Inside the transaction object, we need to add a default value for the parentReportActions to prevent accessing an undefined value

App/src/components/ReportActionItem/MoneyRequestView.js

Line 347 in f2b74e8

key: ({report, parentReportActions}) => {

to

            key: ({report, parentReportActions = {}}) => {

OR alternativly we can use lodashGet to safely access the parentReportActions object same as we do in the MoneyRequestHeader:

App/src/components/MoneyRequestHeader.js

Lines 179 to 186 in 9208c95

	withOnyx({
	transaction: {
	key: ({report, parentReportActions}) => {
	const parentReportAction = lodashGet(parentReportActions, [report.parentReportActionID]);
	return `${ONYXKEYS.COLLECTION.TRANSACTION}${lodashGet(parentReportAction, 'originalMessage.IOUTransactionID', 0)}`;
	},
	},
	}),

POC

Screen.Recording.2023-12-31.at.12.13.53.AM.mov

[rashidkarim11]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0150aa8a8cbde87533

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[sakluger]

This looks like a duplicate of #33295 so I am going to close in favor of that one. The only difference is the platform, but the behavior is exactly the same.

@abzokhattab if you think your proposal will solve the other issue, could you please repost your proposal on #33295? Thanks!

[abzokhattab]

@sakluger I am not able to reproduce the other issue

#33295 (comment)

lets see if it's fixed we can open this one again ..

but the behavior is exactly the same.

not really .. the attached video there shows "hmm it's not here" page not a compiler error as it's currently happening in android

[abzokhattab]

@sakluger @aimane-chnaif Hey again, the other issue is not reproducible anymore and got closed ...

#33295 (comment)

however the current issue is still reproducible

again i believe the two issues are different, here we have a compiler error in anrdroid not hmm its not here which is a different error

[abzokhattab]

@sakluger @aimane-chnaif @izarutskaya

Just a reminder, the other issue is closed and still, this one is reproducible on the latest build (v1.4.22-3):

Screen.Recording.2024-01-08.at.5.17.45.PM.mov

[aimane-chnaif]

@sakluger let's re-open

[abzokhattab]

@sakluger kindly reminder!

cc. @mountiny

[aimane-chnaif]

@abzokhattab I have one more case of crash (check video for repro step). Happening on ReportScreen.
Let's fix this as well. Solution is same as in MoneyRequestView.

Proposal: #33800 (comment)

Screen.Recording.2024-01-15.at.3.31.12.PM.mov

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[cristipaval]

Thanks @aimane-chnaif for flagging the other crash as well!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix accessing undefined parentReportActions object when loading the transactions #34648

If no regressions arise, payment will be issued on 2024-01-31. 🎊

For reference, here are some details about the assignees on this issue:

• @abzokhattab requires payment automatic offer (Contributor)
• @aimane-chnaif requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Hey @aimane-chnaif, can you please complete the BZ checklist so I can close the issue out after payment tomorrow? Thanks!

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: Get the parent report action using withOnyx for the money request view #32446
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Get the parent report action using withOnyx for the money request view #32446 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. N/A as caught by QA team
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[sakluger]

All paid out, thanks everyone!