Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - No "Show x of y" at the end of Search list #36033

Closed
6 tasks done
lanitochka17 opened this issue Feb 7, 2024 · 10 comments
Closed
6 tasks done

Search - No "Show x of y" at the end of Search list #36033

lanitochka17 opened this issue Feb 7, 2024 · 10 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4-38.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: User is logged into account that has more than 500 contacts

  1. Go to staging.new.expensify.com
  2. Click on the search bar
  3. Scroll to the end of the list

Expected Result:

The Search list will show the first 500 contacts, and the rest will be hidden with "Show x of y" button

Actual Result:

The Search list displays all the contacts in one list without "Show x of y" button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370412_1707314932275.bandicam_2024-02-07_21-23-20-611__1_.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@rlinoz
Copy link
Contributor

rlinoz commented Feb 7, 2024

I think this might be intended behavior, asking on slack

@rlinoz
Copy link
Contributor

rlinoz commented Feb 7, 2024

asked here

@Julesssss
Copy link
Contributor

Not a blocker. Removing the label to unblock the deploy and our big VSB-VIP announcement.

@Julesssss Julesssss added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 8, 2024
@cristipaval
Copy link
Contributor

Let's hold this one on #36121

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Feb 12, 2024

@cristipaval maybe we can close this one in favor of the #36121 ?

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@cristipaval
Copy link
Contributor

yes I think we could close it 👍

@rlinoz
Copy link
Contributor

rlinoz commented Feb 12, 2024

Great, closing because #36033 (comment)

@rlinoz rlinoz closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants