[C+ Checklist Needs Completion] [$500] Distance - Unable to unselect default category from confirmation page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v.1.4-38.2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has set up default category for Distance request.

1. Go to workspace chat.
2. Start distance request flow.
3. Proceed to confirmation page.
4. Click Category.
5. Click on the selected default category.
6. Note that user cannot unselect the default category.
7. Create the distance request.
8. Go to details page of the created distance request.
9. Click Category.
10. Click on the selected category.
11. Now user can unselect the category.

Expected Result:

In Step 4, user should be able to unselect the default distance category.

Actual Result:

In Step 4, user is unable to unselect the default distance category.
Only after the distance request is created, user can unselect it from the request details page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6371628_1707391850643.20240208_102412.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165ec95398a746481
• Upwork Job ID: 1755567118652162048
• Last Price Increase: 2024-02-08
• Automatic offers:
• situchan | Contributor | 28150761

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0165ec95398a746481

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-vsb
CC @quinthar

[paultsimura]

This is a regression from #33388
cc: @situchan @tienifr

We need to use a ref to check if the default category was set on the page load:

    const defaultCategoryHasBeenSet = useRef(false);
    ...
    useEffect(() => {
        if (requestType !== CONST.IOU.REQUEST_TYPE.DISTANCE || !_.isEmpty(transaction.category) || !!defaultCategoryHasBeenSet.current) {
            return;
        }
        IOU.setMoneyRequestCategory_temporaryForRefactor(transactionID, defaultCategory);
        defaultCategoryHasBeenSet.current = true;
    }, [transactionID, transaction.category, requestType, defaultCategory]);

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Lines 136 to 141 in a068ac5

	useEffect(() => {
	if (requestType !== CONST.IOU.REQUEST_TYPE.DISTANCE || !_.isEmpty(transaction.category)) {
	return;
	}
	IOU.setMoneyRequestCategory_temporaryForRefactor(transactionID, defaultCategory);
	}, [transactionID, transaction.category, requestType, defaultCategory]);

[situchan]

@tienifr can you raise quick PR?

[situchan]

 useEffect(() => { 
     if (requestType !== CONST.IOU.REQUEST_TYPE.DISTANCE || !_.isEmpty(transaction.category)) { 
         return; 
     } 
     IOU.setMoneyRequestCategory_temporaryForRefactor(transactionID, defaultCategory); 
- }, [transactionID, transaction.category, requestType, defaultCategory]); 
+ }, [transactionID, requestType, defaultCategory]); 

I think this solution is better

[situchan]

PR is up

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] prevent resetting to default when unselect category #36150

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @aimane-chnaif requires payment (Needs manual offer from BZ)
• @situchan requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @aimane-chnaif / @situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @aimane-chnaif / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @aimane-chnaif / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @aimane-chnaif / @situchan] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @aimane-chnaif / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] prevent resetting to default when unselect category #36150

If no regressions arise, payment will be issued on 2024-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @aimane-chnaif requires payment (Needs manual offer from BZ)
• @situchan requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @aimane-chnaif / @situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @aimane-chnaif / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @aimane-chnaif / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @aimane-chnaif / @situchan] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @aimane-chnaif / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Okay so reviewing this ... this is a regression from #33388. That PR was implemented by @tienifr and reviewed by @situchan. Both were paid $500 - it doesn't seem like there was a regression penalty applied? Not sure.

This issue resulted in a PR that was CP'd to resolve the regression, which was implemented by @situchan and reviewed by @aimane-chnaif.

@rushatgabhane was assigned to this issue as C+ via automation, but I don't think he participated in the review as this was a deploy blocker that was implemented very quickly.

---

With that said, I think the payments for this issue should just be:

$500 to @aimane-chnaif

Please let me know if I got any of this incorrect.

[greg-schroeder]

Paid. One of the 3 C+ assigned to this can hopefully take care of the checklist. :)

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: Set default category for distance request #34012
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/34012/files#r1493746272
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A as this was caught in staging by QA
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[Julesssss]

Quiet melvin.

I think we're good now, right @greg-schroeder

[aimane-chnaif]

I think we can close this

[melvin-bot]

@Julesssss @greg-schroeder @aimane-chnaif @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@Julesssss, @greg-schroeder, @aimane-chnaif, @situchan Huh... This is 4 days overdue. Who can take care of this?

[greg-schroeder]

Oops, sorry, closing and taking care of final steps!