[PAY 5th MARCH][$500] Tapping on Workspace avatar, app crashes

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Launch app
2. Tap on Workspace chat
3. Tap on Workspace avatar

Expected Result:

Tapping on Workspace avatar, app must not crash.

Actual Result:

Tapping on Workspace avatar, app crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385249_1708397497892.az_recorder_20240220_074307.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0122621393ead12452
• Upwork Job ID: 1759796779453788160
• Last Price Increase: 2024-02-20
• Automatic offers:
• situchan | Reviewer | 0
• tienifr | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0122621393ead12452

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kavimuru]

We think this bug might be related to #vip-vsb
cc @quinthar

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping on Workspace avatar, app crashes

What is the root cause of that problem?

source can be function (e.g., SVG) while Str.isVideo allows string only.

App/src/components/Attachments/AttachmentView/index.js

Line 103 in 1806422

const isVideo = Str.isVideo(source);

What changes do you think we should make in order to solve the problem?

Add type check string for source before passing to isVideo.

What alternative solutions did you explore? (Optional)

We can add the type check in expensify-common's isVideo so it applies to every usage.

[jliexpensify]

I updated my Android app, but am still on .42-5.

My Chrome is .43 but I can't reproduce this.

[situchan]

Reproduced. @jliexpensify workspace avatar should be default svg avatar.
This came from video player PR - #30829

[situchan]

@tienifr's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[techievivek]

@tienifr Can you please push a PR for this ASAP, thanks.

[tienifr]

Sure.

[tienifr]

PR ready for review #36842.

[tienifr]

@jliexpensify PR hit production. Melvin is malfunctioning. Please add HOLD for payment label.

[jliexpensify]

Thanks @tienifr - bump on @situchan to complete the checklist, looks like payment is due in 2 days!

[situchan]

Offending PR: #30829
Commented there: https://github.com/Expensify/App/pull/30829/files#r1514802751

No need regression test as caught during regression test in staging.

[jliexpensify]

Sorry, here is a Payment Summary

• Contributor: @tienifr $500
• C+: @situchan $500

Upwork job

[jliexpensify]

Closed and paid!