[Hold for Payment 13th August] Deselect attendees when splitting a bill in group DM.

[rushatgabhane]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to a group.
2. Split a bill in the group.
3. Enter amount, go next.
4. Unselect attendees.

Expected Result:

Should be able to unselect attendees.

Actual Result:

Can't unselect attendees.

Workaround:

User can split the bill from outside the group.

Platform:

Where is this issue occurring?

Web ✔
iOS ✔
Android ✔
Desktop App ✔
Mobile Web ✔

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @MitchExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[rushatgabhane]

Proposal

In IOUConfirmationList.js
Modify OptionsList props, getSplits(), getSections(), define toggleOption() etc to get the desired behaviour.

Split with the selected attendees only.
Disable button when no attendee is selected.

[trjExpensify]

Thanks, @rushatgabhane! So a couple of additional things we'll want to consider in the proposal for this:

• when you deselect the attendee, that attendee isn't removed from the list completely, but rather the checkmark is removed from the radio button and the amount is updated to %0
• The amounts for the attendees still selected are then increased to the new even split values
• We still add the split comment to the group DM you actioned on this from with all members, it's just modified to only include the attendees that were selected for the split.

CC: @shawnborton @Julesssss @kevinksullivan

[rushatgabhane]

Yes, definitely!
That is how it'll be implemented

[MitchExpensify]

Reproduced as triager, labelling engineering! Looks like a good external issue but will let an engineer make that call (I can create the Upwork job once thats confirmed!)

[MelvinBot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

Yup, writeup looks good to me, and was also able to reproduce it.

[MelvinBot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jliexpensify]

Assigning back to @MitchExpensify so he can create the Upworks job.

[Julesssss]

We still add the split comment to the group DM you actioned on this from with all members, it's just modified to only include the attendees that were selected for the split.

FYI, we'll require some backend changes here. The CreateIOUSplit API simply takes a reportID. So without modifications, the message would include all members of that group. We would probably need to pass a list of participant emails to make this change.

[trjExpensify]

Got it, so shall we create a separate E/E issue for that? I don't think we can move forward with this solution if we're including participants who weren't there in the split comment.

[Julesssss]

@trjExpensify yep, let's do that and hold this issue. I'd take it but I'm about to go OOO.

[rushatgabhane]

@trjExpensify Frontend is almost ready, I'm keeping track of the selected and unselected participants.
Yeah, the api will have to change so I can send the list of selected participants.
We'll also need to create a new func in IOU.js which doesn't create new chat report.

[trjExpensify]

Awesome! I've created the back-end issue, and popped a [Hold] on this until we've completed that. 👍

[MitchExpensify]

Just a note to say I'll keep an eye on the PR and process the payment to you in Upwork @rushatgabhane once its been merged for 7 days

[Luke9389]

I'll be out of office all of next week so I'll be able to come back to this after that.

[rushatgabhane]

Just waiting for merge approval. All tasks are done

[MelvinBot]

@rushatgabhane, @MitchExpensify, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Luke9389]

Just merged 👍

[MelvinBot]

@rushatgabhane, @MitchExpensify, @Luke9389 it looks like no one is assigned to work on this job.
Please double the price or add a comment stating why the job isn't being doubled.

[rushatgabhane]

PR already merged.
Ignore the bot.

[MelvinBot]

@rushatgabhane, @MitchExpensify, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Updated the issue title with the payment date, @MitchExpensify.

[Luke9389]

Not sure why the Overdue label is still on this. We're investigating a potentially related issue to determine if it's a regression. More updates on that coming soon.

[MelvinBot]

@rushatgabhane, @MitchExpensify, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

Paid!

[MelvinBot]

@rushatgabhane, @MitchExpensify, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!