-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split bill - Deselecting an attendee in confirmation screen not retained #5242
Comments
Triggered auto assignment to @marcaaron ( |
This comment has been minimized.
This comment has been minimized.
@PrashantMangukiya please wait for the help wanted label to be applied before submitting a proposal. |
Unsure if this is a very high priority issue or how this feature is even supposed to work. Why are we able to deselect an attendee on the confirmation screen? Isn't that what the first screen is for? |
cc @Julesssss in case you have the answer |
@marcaaron got it, now onwards I will submit proposal after help wanted label applied. thanks. |
IIRC this was a recent change and was desired so that you could split a bill from a group, but exclude certain members from the split. I guess this bug was missed during the review, but it seems like a valid one to fix. |
I think we should just not let you deselect attendees from the confirmation screen in the global create split bill flow, right? The split bill flow inside a group doesn't have the participant selector step, so it's not an issue in that flow that the change was intended to be implemented on only. |
Yeah, I think we talked about this being missed from the PR but forgot to create an issue. That's the desired fix 👍 |
Works for me! Do we want to convert this issue, or close it and open a fresh one? |
I'm going to just create a new one, so the comments don't cause confusion. |
Closing this. It will be fixed via this alternative change. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Deselected attendee should not be displayed selected
Actual Result:
Deselected attendee displayed as selected
Workaround:
User has to deselect the attendee again.
Platform:
Where is this issue occurring?
Version Number: 1.0.98-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5231690_Recording__1041.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: