Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split bill - Deselecting an attendee in confirmation screen not retained #5242

Closed
isagoico opened this issue Sep 14, 2021 · 12 comments
Closed
Labels
Engineering Planning Changes still in the thought process Weekly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Launch the app and login
  2. Click + > Split bill
  3. Enter amount and click next
  4. Select two attendees and click next
  5. In confirmation screen deselect one attendee

Expected Result:

Deselected attendee should not be displayed selected

Actual Result:

Deselected attendee displayed as selected

Workaround:

User has to deselect the attendee again.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.98-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5231690_Recording__1041.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@PrashantMangukiya

This comment has been minimized.

@marcaaron
Copy link
Contributor

@PrashantMangukiya please wait for the help wanted label to be applied before submitting a proposal.

@marcaaron marcaaron added Weekly KSv2 and removed Daily KSv2 labels Sep 14, 2021
@marcaaron marcaaron removed their assignment Sep 14, 2021
@marcaaron marcaaron added the Planning Changes still in the thought process label Sep 14, 2021
@marcaaron
Copy link
Contributor

Unsure if this is a very high priority issue or how this feature is even supposed to work. Why are we able to deselect an attendee on the confirmation screen? Isn't that what the first screen is for?

@marcaaron
Copy link
Contributor

cc @Julesssss in case you have the answer

@PrashantMangukiya
Copy link
Contributor

@marcaaron got it, now onwards I will submit proposal after help wanted label applied. thanks.

@Julesssss
Copy link
Contributor

IIRC this was a recent change and was desired so that you could split a bill from a group, but exclude certain members from the split. I guess this bug was missed during the review, but it seems like a valid one to fix.

CC @trjExpensify

@trjExpensify
Copy link
Contributor

I think we should just not let you deselect attendees from the confirmation screen in the global create split bill flow, right?

The split bill flow inside a group doesn't have the participant selector step, so it's not an issue in that flow that the change was intended to be implemented on only.

@Julesssss
Copy link
Contributor

we should just not let you deselect attendees from the confirmation screen in the global create split bill flow

Yeah, I think we talked about this being missed from the PR but forgot to create an issue. That's the desired fix 👍

@trjExpensify
Copy link
Contributor

Works for me! Do we want to convert this issue, or close it and open a fresh one?

@Julesssss
Copy link
Contributor

I'm going to just create a new one, so the comments don't cause confusion.

@Julesssss
Copy link
Contributor

Closing this. It will be fixed via this alternative change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Planning Changes still in the thought process Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants