[Hold for payment 04-17-2024][$500] Web - Split bill - Split bill shortcut directs to 404 page after splitting a bill with one account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.59-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Click on FAB and select Request money
2. Select manual > enter any valid amount and continue
3. Click on Split on any one participant and click on Add to split
4. Click on Split {currency} {amount}
5. Click on FAB and click on the split bill shortcut

Expected Result:

Split bill shortcut should open

Actual Result:

Hmm... it's not here page opens

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435487_1712058302059.35253.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01356e4f802ce02d01
• Upwork Job ID: 1775206920005824512
• Last Price Increase: 2024-04-02
• Automatic offers:
• jjcoffee | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kbecciv]

We think that this bug might be related to #vip-split

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the split bill shortcut after splitting bill with one user leads to not found page.

What is the root cause of that problem?

When we open the split bill from the shortcut, the canCreateRequest condition will be false.

App/src/pages/iou/request/IOURequestStartPage.js

Line 116 in d7161ae

const isAllowedToCreateRequest = _.isEmpty(report.reportID) || ReportUtils.canCreateRequest(report, policy, iouType);

And that's because getMoneyRequestOptions doesn't include the split bill option for 1:1 DM.

App/src/libs/ReportUtils.ts

Lines 4989 to 4995 in d7161ae

	function canCreateRequest(report: OnyxEntry<Report>, policy: OnyxEntry<Policy>, iouType: (typeof CONST.IOU.TYPE)[keyof typeof CONST.IOU.TYPE]): boolean {
	const participantAccountIDs = report?.participantAccountIDs ?? [];
	if (!canUserPerformWriteAction(report)) {
	return false;
	}
	return getMoneyRequestOptions(report, policy, participantAccountIDs).includes(iouType);
	}

App/src/libs/ReportUtils.ts

Lines 4802 to 4809 in d7161ae

	if (
	(isChatRoom(report) && otherParticipants.length > 0) ||
	(isDM(report) && hasMultipleOtherParticipants) ||
	(isGroupChat(report) && otherParticipants.length > 0) ||
	(isPolicyExpenseChat(report) && report?.isOwnPolicyExpenseChat)
	) {
	options = [CONST.IOU.TYPE.SPLIT];
	}

That's why you can't see the split bill option from composer + menu, but you can still split with one user.

What changes do you think we should make in order to solve the problem?

Split bill with one user is totally valid, so I think we can start showing the split bill option for 1:1 DM too by removing the hasMultipleOtherParticipants conditions (or replacing it with otherParticipants.length > 0).

What alternative solutions did you explore? (Optional)

If we don't want to show the split bill option in the composer + menu but still allow it from the shortcut, then we can:

1. Add a new param to canCreateRequest whether to include a split bill for 1:1 DM or not and pass true for the money request page.
   OR
2. Add a new param to the money request page indicating the user is coming from the shortcut and always allow the user to create a request.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01356e4f802ce02d01

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill shortcut directs to 404 page after splitting a bill with one account

What is the root cause of that problem?

The IOURequestStartPage checks isAllowedToCreateRequest is true to display the FullPageNotFoundView

App/src/pages/iou/request/IOURequestStartPage.js

Line 151 in ee5ab95

<FullPageNotFoundView shouldShow={!IOUUtils.isValidMoneyRequestType(iouType) || !isAllowedToCreateRequest}>

The issue here is within isAllowedToCreateRequest

App/src/pages/iou/request/IOURequestStartPage.js

Line 116 in ee5ab95

const isAllowedToCreateRequest = _.isEmpty(report.reportID) || ReportUtils.canCreateRequest(report, policy, iouType);

as mentioned on the comment:

// Allow the user to create the request if we are creating the request in global menu or the report can create the request

So isAllowedToCreateRequest uses ReportUtils.canCreateRequest to check if we are creating the request in global menu. But we are not checking if we are creatring the request from the shortcut.

What changes do you think we should make in order to solve the problem?

We need to check if we are creatring the request from the shortcut.

Inside IOURequestStartPage we need to subscribe to Onyx quickAction

export  default  withOnyx({
// ...
+ quickAction: {
+   key: ONYXKEYS.NVP_QUICK_ACTION_GLOBAL_CREATE,
+ },
})(IOURequestStartPage);

Add quickAction?.action === "splitManual" to isAllowedToCreateRequest

const  isAllowedToCreateRequest  =  _.isEmpty(report.reportID) ||  ReportUtils.canCreateRequest(report, policy, iouType) ||  quickAction?.action  ===  "splitManual";

POC video:

20240402_213028.mp4

[lschurr]

Hi @jjcoffee - Could you take a look at the proposals on this one?

[jjcoffee]

Looks like we have an inconsistency here as @bernhardoj's proposal points out. We can create a split with a single user from the FAB, but it doesn't show as an option in a 1:1 chat (from the composer + menu). I would say it makes sense to fix up that consistency, so I'd go with the main solution.

I'm not 100% whether there might be some reason for keeping the Split Bill option out of 1:1 DMs, so asking on Slack just in case!

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jjcoffee]

Confirmed on Slack that Split bill should be present on 1:1 DMs.

[NikkiWines]

Thanks for double checking @jjcoffee. Agreed that @bernhardoj's proposal looks good 👍

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @jjcoffee

[jjcoffee]

PR hit production last week (2024-04-10), so payment should be due tomorrow!

[lschurr]

Thanks for the bump @jjcoffee!

[lschurr]

Payment summary:

• Contributor: @bernhardoj $500 (to be paid in Upwork)
• Contributor+: @jjcoffee $500 (to be paid in Upwork)

[lschurr]

Paid!