Taxes - Tax rate and tax amount take some time to show up in transaction thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an employee of Collect workspace that has taxes.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create a manual request with tax.
4. Go to transaction thread immediately after the request is created.

Expected Result:

Tax rate and tax amount will instantly show up in transaction thread.

Actual Result:

Tax rate and tax amount take some time to show up in transaction thread.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437960_1712235526985.bandicam_2024-04-04_20-55-53-264.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013d484f5c32510e05
• Upwork Job ID: 1775993187810840576
• Last Price Increase: 2024-04-04

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[MonilBhavsar]

Not a blocker, i think
We'll be fixing as a regression from #33927

[alitoshmatov]

This is related to offline updates which was not on scope of mentioned PR, and is going to be handled separately, ref: #33927 (comment)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013d484f5c32510e05

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MonilBhavsar]

This is related to offline updates which was not on scope of mentioned PR, and is going to be handled separately, ref:

@alitoshmatov I don't think this is related to offline in any case. This looks an issue with rendering

[MonilBhavsar]

Okay, I think this is fixed with this change https://github.com/Expensify/App/pull/39638/files#diff-eec4675b6213eb7b4c8826a7b0a536ee7455e6a5580476ef0f9c8964e5deea81R163

@kbecciv can we please retest and confirm. Thank you!

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

[MonilBhavsar]

Waiting for confirming from QA team (cc @kbecciv)
If reproducible, Eto Olei will be taking a look

[lschurr]

Asked for a retest here: https://expensify.slack.com/archives/C9YU7BX5M/p1712590740591719

[kavimuru]

@lschurr issue is fixed now.
https://github.com/Expensify/App/assets/43996225/32d39438-ccfd-4346-a36e-5b404108d506

@MonilBhavsar #39804 which was closed as dupe of #39615 still repro. Can we reopen that issue?

[MonilBhavsar]

Thank you for confirming @kbecciv!
We can close this issue then

---

#39804 is really a duplicate of #39615
Once #39615 is fixed, #39804 will also be fixed. They have the same root cause - data not being updated optimistically. As a result, there is some delay as data is being returned by server.