[QBO] "must categorize all expenses" toggle is off and Tags are not imported

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.71-4
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Found when validating PR : #41513
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: Log into New Expensify using an account that is on the accounting beta list

1. Go to categories page. Check that you see default categories
2. Go to More Features page > Enable Tags feature
3. Go to Tags page. Check that you see nothing
4. Create a tag. Make sure you see the newly created tag.
5. Go to workspace settings page -> More Features -> Enable Accounting
6. Go to Accounting page -> Connect to QBO
7. Go to the Categories page and check that you see the imported categories > Click Settings button the categories page
8. Go to to the Accounting page -> Import
9. Go to the Tags

Expected Result:

Step 7. "must categorize all expenses" toggle is on
Step 8. Customers (or locations or classes) are imported as tags
Step 9. You see some tags (you should not see the tag you created before)

Actual Result:

Step 7. "must categorize all expenses" toggle is off and locked
Step 8. Customers (or locations or classes) are Not imported
Step 9. You see the tag you created on step 4

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6474708_1715166353268.41513.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[youssef-lr]

cc @hayata-suenaga @aldo-expensify, is this a blocker? taking a look at the code it seems expected here that the toggle will be disable if we're connected to an accounting system

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Line 51 in e0b6a06

disabled={!policy?.areCategoriesEnabled || !hasEnabledOptions || isConnectedToAccounting}

[marcaaron]

I think the QBO stuff is behind a beta, no? Let's remove the blocker.

[hayata-suenaga]

I tried to reproduce the three issues reported here, but I couldn't.

Step 7. "must categorize all expenses" toggle is off and locked

The toggle is on and locked as expected.

Step 8. Customers (or locations or classes) are Not imported

The classes and customers are imported as expected.

Step 9. You see the tag you created on step 4

I couldn't see the tag I manually created after connecting to accounting software

[kavimuru]

The bug is partly fixed. The toggle part is still repro ('Members must categorize all spend' toggle still off and locked)

41513.v2.mp4

[hayata-suenaga]

@kavimuru

I just realized that when you click Settings button on the Tags page, the Not-Found page is displayed for a while. Is this issue being tracked somewhere else?

[trjExpensify]

On Tags import:

1. Support for MultiTags import isn't done yet and I think that's probably messing up importing and displaying the tag lists imported: Add missing multi tag view #41351
2. The Tags menu item isn't appearing in the LHN when you connect to QBO, but it should be because Customers and Classes are imported by default. @hayata-suenaga @aldo-expensify I feel like I've asked about this in a number of places really, but it would be good to nail down where it's being taken care.

As for the required categories toggle, I can't repro that:

[hayata-suenaga]

The Tags menu item isn't appearing in the LHN when you connect to QBO, but it should be because Customers and Classes are imported by default. @hayata-suenaga @aldo-expensify I feel like I've asked about this in a number of places really, but it would be good to nail down where it's being taken care.

@aldo-expensify, could you confirm that, in this issue, you accounted for the situation when the default configuration already satisfies the condition below:

[DONE] When the admin choose to import Classes, Customers/Projects, or Locations, enable the Tags feature on the backend so that these entities can be imported as tags to New Expensify.

[hayata-suenaga]

For the bug (somewhat unrelated) I found while reproducing the original issue, the issue is apparently hard to reproduce.

It might have been the result of the backend fire this week. Please let me know if you encounter this issue (Not found page briefly displayed after a while) again.

[aldo-expensify]

The Tags menu item isn't appearing in the LHN when you connect to QBO, but it should be because Customers and Classes are imported by default. @hayata-suenaga @aldo-expensify I feel like I've asked about this in a number of places really, but it would be good to nail down where it's being taken care.

@aldo-expensify, could you confirm that, https://github.com/Expensify/Expensify/issues/390731, you accounted for the situation when the default configuration already satisfies the condition below:

ohh, I think initial case was not covered because I added that logic to the Auth command UpdatePolicyConnectionConfiguration, and that command is not used until the user start changing settings manually.

I think we can fix this here: https://github.com/Expensify/Web-Expensify/pull/41908

[aldo-expensify]

Testing again, I don't see that "Customers and Classes are imported by default". Do we need to correct our defaults?

Ignore this, I had a problem in dev that caused the defaults to fail to be set. We do enable Classes. Customer/Projects and Locations to be imported by default.

[trjExpensify]

We do enable Classes. Customer/Projects and Locations to be imported by default.

Just to confirm on this.. in OldDot, we enable Classes & Customer/Projects by default, but not Locations. We should maintain that consistency, is that what you're saying?

[trjExpensify]

I think we can fix this here: https://github.com/Expensify/Web-Expensify/pull/41908

Also, nice! Looking forward to getting that one fixed 👍

[aldo-expensify]

We do enable Classes. Customer/Projects and Locations to be imported by default.

Just to confirm on this.. in OldDot, we enable Classes & Customer/Projects by default, but not Locations. We should maintain that consistency, is that what you're saying?

Yes, I made a mistake, Locations is not enabled by default

[trjExpensify]

Sounds good!

[melvin-bot]

@youssef-lr, @jliexpensify Eep! 4 days overdue now. Issues have feelings too...

[youssef-lr]

Not overude. A fix has been merged

[jliexpensify]

Looks like this was deployed, @youssef-lr should we close this, or did you want Applause to re-test?

[youssef-lr]

@jliexpensify it's only been deployed to staging, we can close once it hits production.

[jliexpensify]

Ah yes, you're correct - apologies!

[melvin-bot]

@youssef-lr @jliexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[jliexpensify]

This one just hit production, so closing it out!