[$250] [CVP] New User who is submitted an IOU pays via BBA, then see’s `Approve'

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.74-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715816298574129

Action Performed:

1. As user A send a IOU request to new user
2. Click "Pay" from the new user email
3. User is taken to the IOU report
4. Select the option "Pay with expensify"
5. Select option "Business bank account"
6. This will create a workspace and moves the IOU to a workspace chat
7. Cancel the VBBA set up and navigate to the workspace chat

Expected Result:

The expense should see pay rather than approve.

Actual Result:

There is an option to approve the expense, even though it’s a brand new workspace and thus shouldn’t have approval.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

upgradeerrors.mp4

Recording.79.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cc2fb178d0dea7a3
• Upwork Job ID: 1792680301683040256
• Last Price Increase: 2024-06-10
• Automatic offers:
• DylanDylann | Reviewer | 102721547
• bernhardoj | Contributor | 102721548

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The money request preview shows approve button even though it's a new workspace which has approval disabled by default.

What is the root cause of that problem?

This has the same root cause as #39171.

We already have a condition here to not show the approve button if the approval is disabled (isOnSubmitAndClosePolicy).

App/src/libs/actions/IOU.ts

Lines 5978 to 5982 in e8ae3c5

	const isOnInstantSubmitPolicy = PolicyUtils.isInstantSubmitEnabled(policy);
	const isOnSubmitAndClosePolicy = PolicyUtils.isSubmitAndClose(policy);
	if (isOnInstantSubmitPolicy && isOnSubmitAndClosePolicy) {
	return false;
	}

However, the auto-reporting frequency needs to be instant (isOnInstantSubmitPolicy) to not show the approval button. In our case, the frequency is empty, so the condition is never met. Later after we receive the BE response, the frequency is set to instant.

What changes do you think we should make in order to solve the problem?

Remove isOnInstantSubmitPolicy condition

Or change the condition to accept either isOnInstantSubmitPolicy or isOnSubmitAndClosePolicy.
if (isOnInstantSubmitPolicy || isOnSubmitAndClosePolicy) {

We need to fix on the BE too because the next step indicating for the admin to approve it first.

What alternative solutions did you explore? (Optional)

Set autoReportingFrequency to instant optimistically when creating the workspace in createWorkspaceFromIOUPayment.
autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT,

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

This is bottom up case, so adding to collect project

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cc2fb178d0dea7a3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[DylanDylann]

This RCA and solution of this issue is similar to this one that I approved
@bernhardoj's proposal #39171 (comment). @kevinksullivan Do you think we should close this one and reopen the previous issue to save effort because both I and @bernhardoj have context about this problem?

[hoangzinh]

Do you think we should close this one and reopen #39171

I don't think we should. The previous issue is closed because that issue is not reproducible, if we re-open that issue, the reproduce steps there can't be used, also expectation.

But I'm happy to let @DylanDylann continuous review this issue as a C+.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@hoangzinh, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[hoangzinh]

cc @kevinksullivan what do you think on my comment here #42322 (comment)

[melvin-bot]

@hoangzinh @kevinksullivan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@hoangzinh, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[hoangzinh]

ping @kevinksullivan in slack https://expensify.slack.com/archives/C02NK2DQWUX/p1717148796680459

[kevinksullivan]

I agree we should just keep up with the same issue. @hoangzinh if you want to pass to @DylanDylann you can, or you can stay on as C+.

[hoangzinh]

Yes, please @kevinksullivan can you assign @DylanDylann as C+ so he can start reviewing this issue? Thanks

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@hoangzinh, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[DylanDylann]

Taking over as C+

[DylanDylann]

Hi @bernhardoj Could you reproduce this issue any mỏe?

[bernhardoj]

Yes, I can still repro it.

Screen.Recording.2024-06-11.at.23.07.47.mov

Btw, if you notice in the video, the approve button is later changed to the pay button. That's because CreateWorkspaceFromIOUPayment API sets the auto-reporting frequency to instant which will make canApproveIOU returns false.

I mentioned before in my proposal that the auto reporting frequency is weekly, so looks like the BE sends a different response this time.

I have added an alternative to set the frequency to instant optimistically. It'd be easier to test this while offline.

[DylanDylann]

@bernhardoj A bit curious, when I log in as a new user, I only see an option for payment "pay .. elsewhere"

[bernhardoj]

Ah, the pay with expensify is for USD only, the currency is always converted to my local currency, so I manually update the code to always show the pay with expensify option.

App/src/components/SettlementButton.tsx

Line 178 in 8d11d0b

const canUseWallet = !isExpenseReport && !isInvoiceReport && currency === CONST.CURRENCY.USD;

[DylanDylann]

@bernhardoj Your alternative proposal looks good to me. Let's go with @bernhardoj's proposal

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[amyevans]

Agreed we can set it optimistically to take care of this, assigning @bernhardoj and @DylanDylann

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

This PR already set the autoReportingFrequency to instant, I guess nothing to do here then.

[melvin-bot]

@amyevans @kevinksullivan @bernhardoj @DylanDylann this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[amyevans]

Okay got it, I think we should just close here then. Sorry this is the second time this has happened 😬