[HOLD for payment 2024-07-10] [$250] Workspace - Error page when navigate to Workspace Join link after leaving the workspace

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.81-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4609575&group_by=cases:section_id&group_order=asc&group_id=229065
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Login to staging.expensify.com
2. Navigate to this link - https://staging.new.expensify.com/settings/workspaces/CEFA9CA2E2CBFFC0/[email protected]
3. Click on 3-dot menu> Leave
4. Navigate to this link again - https://staging.new.expensify.com/settings/workspaces/CEFA9CA2E2CBFFC0/[email protected]

Expected Result:

User should be able to navigate to the workspace

Actual Result:

Error page when navigate to Workspace Join link after leaving the workspace

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6508578_1718048869729.Recording__3163.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0191daed4e48342857
• Upwork Job ID: 1800535491968568315
• Last Price Increase: 2024-06-25
• Automatic offers:
• allgandalf | Reviewer | 102892807
• bernhardoj | Contributor | 102892809

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The not found page is shown when we reopen the workspace join link after leaving it.

What is the root cause of that problem?

When we successfully leave from a workspace, we still keep the policy object data. It's really weird that the pending action is still delete.

App/src/libs/actions/Policy/Policy.ts

Lines 649 to 660 in 65db650

	const successData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	employeeList: {
	[sessionEmail]: null,
	},
	},
	},
	];

When we reopen the join link/page, the condition below detects that the workspace exists, thus we are navigated to the profile page.

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Lines 45 to 51 in 65db650

	if (!isEmptyObject(policy) && !policy?.isJoinRequestPending) {
	Navigation.isNavigationReady().then(() => {
	Navigation.goBack(undefined, false, true);
	Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID ?? ''));
	});
	return;
	}

The not found page will be shown if the policy/workspace has a pending action of delete, thus we see the not found page.

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 153 in 65db650

(PolicyUtils.isPendingDeletePolicy(policy) && PolicyUtils.isPendingDeletePolicy(prevPolicy))

What changes do you think we should make in order to solve the problem?

First, we should clear the policy data after successfully leaving a workspace.

const successData: OnyxUpdate[] = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
        value: null,
    },
];

Next, because not found page will be shown for pending delete workspace, we need to add a new check here to make sure the pending action is not delete so we don't get navigated to the not found workspace profile page.

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Lines 45 to 51 in 65db650

	if (!isEmptyObject(policy) && !policy?.isJoinRequestPending) {
	Navigation.isNavigationReady().then(() => {
	Navigation.goBack(undefined, false, true);
	Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID ?? ''));
	});
	return;
	}

if (!isEmptyObject(policy) && !policy?.isJoinRequestPending && !PolicyUtils.isPendingDeletePolicy(policy)) {

We can optionally check for the policy ID. Let me know if we want to do that

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0191daed4e48342857

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[isabelastisser]

@abdulrahuman5196, can you please review the proposal above? Thanks!

[melvin-bot]

@isabelastisser, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[isabelastisser]

@abdulrahuman5196 please review the proposal above. Thanks!

[isabelastisser]

@abdulrahuman5196, please provide an update. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Hi, @isabelastisser I am back now since I was OOO for couple of days as posted in slack. Will work on review today.

[abdulrahuman5196]

checking now

[abdulrahuman5196]

Navigate to this link - https://staging.new.expensify.com/settings/workspaces/CEFA9CA2E2CBFFC0/[email protected]

Hi @isabelastisser / @bernhardoj , this link is only setting the workspace as Requested, how do I generate this link or use it for testing?

[bernhardoj]

@abdulrahuman5196 I use my other account workspace invitation. So, I get my account B workspace join link, account A opens it, and account B accepts the request (in #admins room if I'm not mistaken).

[melvin-bot]

@isabelastisser @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[isabelastisser]

@abdulrahuman5196, please share an update. Thanks!

[melvin-bot]

@isabelastisser, @abdulrahuman5196 Huh... This is 4 days overdue. Who can take care of this?

[allgandalf]

sorry i didn't update here, the PR was already merged :)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix not found page shown when navigate to Workspace Join link after leaving the workspace #44524

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @allgandalf requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

@allgandalf, please complete the checklist above. Thanks!

[bernhardoj]

Just FYI, I will request the payment through ND.

[allgandalf]

• The PR that introduced the bug has been identified. Link to the PR: Add possibility to leave from workspaces and workspace expense chats #35671

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/39489/files#r1671914757

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. [User B] Copy a workspace join link that User A is not a member
2. [User A] Open the workspace join link
3. [User B] Accept the join request from #admins room
4. [User A] Leave the workspace
5. [User A] (iOS/Android) Close the app
6. [User A] Open the workspace join link again
7. Verify workspace list page is shown
8. Verify the join request is sent again

Do we agree 👍 or 👎

[bernhardoj]

Requested in ND

[isabelastisser]

Payment summary:

@bernhardoj contributor / $250 / pending in NewDot
@allgandalf C+ review / $250 / paid in Upwork

[isabelastisser]

@AndrewGable can you please review the regression test proposal? thanks!

[JmillsExpensify]

$250 approved for @bernhardoj

[isabelastisser]

@AndrewGable #43436 (comment)

[AndrewGable]

Yes, looks good

[isabelastisser]

All set!