[HOLD for payment 2024-07-24] [$500] Expense - Main chat and transaction thread with RBR are not dismissed after dismissing error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.81-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4606839
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User A and B have no chatted before
• Both accounts must be new

1. Go to staging.new.expensify.com
2. [User A] Go offline
3. [User A] Submit an expense to User B
4. [User B] Submit an expense with the same amount to User A
5. [User A] Go online
6. [User A] Go to the transaction thread with RBR
7. [User A] Dismiss the error in transaction thread

Expected Result:

Both the main chat and transaction thread with RBR will be dismissed after dismissing the error in transaction thread

Actual Result:

After dismissing the error in transaction thread, the transaction thread shows empty details. The main chat with RBR is not dismissed
When revisiting the transaction thread, the expense preview becomes skeleton

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6509384_1718112174459.20240611_211757.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ab8ed867be0c34b8
• Upwork Job ID: 1800951566974761970
• Last Price Increase: 2024-06-26
• Automatic offers:
• rojiphil | Reviewer | 102945559
• bernhardoj | Contributor | 102945563

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ab8ed867be0c34b8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[laurenreidexpensify]

Waiting for proposals

[melvin-bot]

@rojiphil, @laurenreidexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Upwork job price has been updated to $500

[laurenreidexpensify]

Increased bounty to see if we can get some proposals in

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[laurenreidexpensify]

hey @JmillsExpensify handing this one over for my parental leave K2 clear out. we're still waiting to receive proposals on this one, equally you may consider closing out if you deem lower value than I have. Thanks!

[rojiphil]

Not sure why there are no proposals yet here.
Just posted in slack here to get more eyes on this.

[rojiphil]

I assume this is because on desktop at least, you can't really have no chat selected—so we'd have to pick some chat to land them on, right?

Yes. That's right.

[arosiclair]

Cool so @bernhardoj can you test that approach?

[bernhardoj]

That works. PR is ready!

cc: @rojiphil

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Delete all linked report when clearing optimistic chat and transaction error #44923

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rojiphil] Determine if we should create a regression test for this bug.
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bernhardoj]

Payment is due today. Requested in ND.

[rojiphil]

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
• [@rojiphil] Determine if we should create a regression test for this bug. : I think we should create a regression test for this as this introduces the ux of navigation to concierge chat during error scenario of chat creation.
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Test Steps

1. Go offline
2. Submit an expense to a new user
3. From another device, send a message to the user from step 2
4. Back to the main device, go online. The chat report of the new user will have a RBR.
5. Open the chat report and press the money request preview
6. Clears the error message
7. Verify you are navigated to concierge chat
8. (small screen) Go back and verify you land on LHN
9. Verify the chat and transaction report is gone from LHN

[rojiphil]

@JmillsExpensify Checklist is done. And I have also accepted the offer.
Over to you for processing the payment. Thanks.

[JmillsExpensify]

Payment summary:

• Contributor: @bernhardoj $500
• Reviewer: @rojiphil $500

[JmillsExpensify]

Contributor paid via Upwork and regression test created. @mallenexpensify can you confirm the payment summary so I can approve in NewDot?

[mallenexpensify]

Contributor: @bernhardoj due $500 via NewDot (assigned date was a few days after eligibility date). Upwork contract cancelled.
Contributor+: @rojiphil paid $500 via Upwork.

[JmillsExpensify]

$500 approved for @bernhardoj