[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-28] Troubleshoot - There is no 'Client side logging' option

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.85-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Navigate to Settings > Troubleshoot

Expected Result:

'Client side logging' option should be available

Actual Result:

'Client side logging' option is not available

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@yuwenmemon FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[jainilparikh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Client side logging is not available on Android.

What is the root cause of that problem?

It was removed from android in this PR: #43543.

Note, there is NO reason that client-side logging should be removed from android and iOS. Clarified by muttmuure@ here: #43926 (comment)

Mainly, Bring back this file (https://github.com/Expensify/App/pull/43543/files#diff-f831be842b96b30c9b4a0737a78f4d9d0e7b9bc8378f0bff99ea3c8234229e22L1) and same for iOS (https://github.com/Expensify/App/pull/43543/files#diff-7a3d7c6bce29ae0ac91290bde365b5c5e239d131652864eef0dc0d76a91a6ad7L1).

What changes do you think we should make in order to solve the problem?

Revert the part of the PR that removes client-side android logging.

[jainilparikh]

@yuwenmemon , if this is a blocker, I can create a PR quickly.

[jayeshmangwani]

This isn't an issue; this was intentionally removed. more here.

cc: @muttmuure

[muttmuure]

hang on a minute - I think there has been some confusion, which I apologize if I caused with my comment.

The linked comment is highlighting that desktop should show whatever is available from the troubleshoot menu on desktop, not to remove the options from Android.

[muttmuure]

Android should still have all of the troubleshoot options

[jainilparikh]

@yuwenmemon @trjExpensify, this is clearly a blocker, android should have the console logging options, I can raise a PR if you approve my proposal: #43926 (comment)

[yuwenmemon]

@jayeshmangwani can you handle a revert?

[yuwenmemon]

Oh wow what a coincidence 😅

[jayeshmangwani]

I was going to tag you once PR pass the check 😃

[jayeshmangwani]

@yuwenmemon PR is ready to be merge please check it

[johnmlee101]

this is a newdot issue, not api so removing the label

[yuwenmemon]

@jayeshmangwani Can you retest on Android on staging and report back?

[jainilparikh]

@yuwenmemon, can you please explain how did you conclude that @jayeshmangwani is the right contributor to raise the PR?

IMHO, since I raised the proposal first #43926 (comment) this bug should have been assigned to me.

I didn't raise the PR simply because it's a rule to not raise PRs without approvals.

[yuwenmemon]

@jayeshmangwani Was the C+ reviewer of the PR that caused this regression and thus he fixed it as part of his responsibility to that PR. (Thank you!)

Closing as this has now been resolved.

[jayeshmangwani]

@jayeshmangwani Can you retest on Android on staging and report back?

I am not able to access Android staging, but I can confirm that on the dev environment for Android,Now we can see the Client Side logging option

Staging - No access

Android - Client side logging

client-sidde-logging-andrid.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• reverted the ClientSideLoggingToolMenu Android iOS files #43938

If no regressions arise, payment will be issued on 2024-06-28. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@yuwenmemon] The PR that introduced the bug has been identified. Link to the PR:
• [@yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@yuwenmemon] Determine if we should create a regression test for this bug.
• [@yuwenmemon] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• reverted the ClientSideLoggingToolMenu Android iOS files #43938

If no regressions arise, payment will be issued on 2024-06-28. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@yuwenmemon] The PR that introduced the bug has been identified. Link to the PR:
• [@yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@yuwenmemon] Determine if we should create a regression test for this bug.
• [@yuwenmemon] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: