[$250] Chat - No "Edit" option on comment with video attachment

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.86-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #42463

Action Performed:

1. Access the New Expensify Beta app
2. Sign into a valid account
3. Send a comment with a video attachment to any chat.
4. Click the 3 dot menu on the comment

Expected Result:

User expects to see an Edit comment option as on Web

Actual Result:

No Edit comment option is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6519526_1718897293912.No_edit_comment_option_on_Desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138b8d7dfb7321ad9
• Upwork Job ID: 1803878166972059685
• Last Price Increase: 2024-06-27

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0138b8d7dfb7321ad9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[jantznick]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User expects to see an Edit comment option as on Web

What is the root cause of that problem?

Currently editing a report is not available if the report is not an attachment per src>libs>ReportUtils.ts

/**
 * Can only edit if:
 *
 * - It was written by the current user
 * - It's an ADD_COMMENT that is not an attachment
 * - It's an expense where conditions for editability are defined in canEditMoneyRequest method
 * - It's not pending deletion
 */

What changes do you think we should make in order to solve the problem?

Modify the canEditReportAction function to not check if the report is an attachment or, possibly check if it is a video attachment depending on desired functionality across different attachment types.

What alternative solutions did you explore? (Optional)

Can modify the check to only allow editing video attachments but not for other attachments.

Also noticed an additional issue with the above fix.
When the above change is made it breaks the rendering of chat messages that include text and a video attachment to not render the video properly. This is due to the report action item single component rendering it as text, not an attachment comment fragment. This is an additional fix that will be required as part of the same PR.

[melvin-bot]

📣 @jantznick! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jantznick]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~019d41aaa9beb952fe

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[parasharrajat]

Its a new feature, Let's get this approved first internally.

[rayane-d]

@parasharrajat - Editing a comment with an attachment is an existing feature in the app, and it's working correctly on all platforms except for the desktop platform

[rayane-d]

@jantznick—Thank you for the proposal. The RCA is not correct because editing a report action is not available if the action is an attachment only (without added text) but is available if the action is a comment + attachment.
Can you please explain in your proposal why the bug is reproducible only on the desktop platform?

[jantznick]

@rayane-djouah This appears to be fixed, can you please test?

[rayane-d]

I'm able to reproduce it, and it seems that the bug is not specific to the desktop platform; I can reproduce it on the web, too.

Reproduction steps:

1. Send text + attachment action
2. Go offline
3. Edit the text + attachment action
4. Try to edit the text + attachment action another time offline
5. Notice that no edit option is available
6. Go back online
7. Notice that the edit option is available after some time

Screen.Recording.2024-06-24.at.6.09.55.PM.mov

[jantznick]

@rayane-djouah The original bug seems to be fixed on desktop and web. This bug you're mentioning now seems to be related to not being able to edit the comment due to it not having a response from the server yet after coming back online. Will that be fixed as part of this issue or a new one?

[rayane-d]

@jantznick - I could not reproduce the bug reliably using the steps from the bug report. The bug is only reproducible offline (steps) or when the Internet connection or server response is slow.

Will that be fixed as part of this issue or a new one?

We can fix this as part of this issue. Can you update your proposal?

[rayane-d]

Still looking for proposals

[jantznick]

Just so we're clear, the proposal you're looking for is completely unrelated to the original. The new issue is that while the request is being made to the server, or in offline mode there is no edit button, correct?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rayane-d]

Just so we're clear, the proposal you're looking for is completely unrelated to the original. The new issue is that while the request is being made to the server, or in offline mode there is no edit button, correct?

@slafortune - Can you please confirm if we should fix this bug that is reproducible with these steps and update the OP accordingly? Thanks!

[slafortune]

It seems that updating would have been easy enough since @jantznick already has the base work done and just needs to make some updates, though it really doesn't matter since there is only one proposal - no one will be paid on this one if it's just closed.