[HOLD for payment 2024-07-24] [$250] Compose box greyed out in offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.2-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719479861497379

Action Performed:

1. Go to staging.new.expensify.com
2. Initiate a DM with any user
3. Go offline and observe compose box

Expected Result:

Compose box not greyed out

Actual Result:

Compose box greyed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a0d7df031f9e69ed
• Upwork Job ID: 1807915148857604784
• Last Price Increase: 2024-07-08
• Automatic offers:
• dominictb | Contributor | 103099309

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Compose box greyed out

What is the root cause of that problem?

• When we create a new report, the pendingAction is add:
  

  App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

  Line 386 in 1d607ac

  pendingAction={pendingAction}

What changes do you think we should make in order to solve the problem?

• If we do not want to grey out the composer in this case, use shouldDisableOpacity in:
  

  App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

  Line 385 in 1d607ac

  <OfflineWithFeedback

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

reproduced

Screen.Recording.2024-07-01.at.4.09.31.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a0d7df031f9e69ed

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[knarah]

Hi @adelekennedy, In the reproduced video, the compose box turns grey when it loses focus and then turns green again when focused while offline. I'm not sure what the bug is in this issue. Could you clarify?

[melvin-bot]

📣 @knarah! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[knarah]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01ba397888562b9e78

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[jayeshmangwani]

If we do not want to grey out the composer in this case, use shouldDisableOpacity in

@dominictb Can you please confirm that after adding shouldDisableOpacity to OfflineWithFeedback, we are not encountering this issue #16730 (comment) on Android again?

[jayeshmangwani]

I'm not sure what the bug is in this issue. Could you clarify

To reproduce the issue: first, send a message in the chat. Then, go offline and reply in the thread to the sent message. Observe the compose box; it will look like the screenshot below.

Composer should not be greyed out; instead, it should look like the screenshot below.

[jayeshmangwani]

@dominictb If we add the shouldDisableOpacity prop, it will disable the greyed-out effect for all newly created offline chats, which I think we don't want.

[dominictb]

@dominictb If we add the shouldDisableOpacity prop, it will disable the greyed-out effect for all newly created offline chats, which I think we don't want.

@iwiznia The current bug occurs when we create a new report in offline mode and the pending action is 'add'. So should we use shouldDisableOpacity props for the composer to disable the grey-out effect? If not, we can close this bug because it is expected behavior.

[iwiznia]

So should we use shouldDisableOpacity props for the composer to disable the grey-out effect?

I think yes, because even if the report is not yet new, the composer box should be non greyed out... right @adelekennedy ?

[jayeshmangwani]

@adelekennedy We are not sure if we need to remove the composer greyed-out altogether for all the new reports created offline. Should we get consensus from the design team on this?

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[jayeshmangwani]

Yeah, we should.

Great! We can move forward with @dominictb's Proposal of adding the shouldDisableOpacity prop to OfflineWithFeedback.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

I think that makes sense to me, yeah. Curious if @trjExpensify agrees though!

Hundy p, agree! 💯

[melvin-bot]

@shawnborton @thienlnam @jayeshmangwani @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: disable opacity for report composer #45376

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jayeshmangwani] Determine if we should create a regression test for this bug.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jayeshmangwani]

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: Offline emoji suggestion opacity fix #17405
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Offline emoji suggestion opacity fix #17405 (comment)
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@jayeshmangwani] Determine if we should create a regression test for this bug. Yes
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to NewDot.
2. Initiate a DM with any user.
3. Go offline, then reply in the thread, and observe the compose box.
4. Verify that the compose box does not grey out.

Do we agree 👍 or 👎

[adelekennedy]

makes sense to me - @thienlnam to weigh in as well

[adelekennedy]

Payouts due:

• Contributor: $250 @dominictb (Upwork)
• Contributor+: $250 @jayeshmangwani (NewDot)

[adelekennedy]

https://github.com/Expensify/Expensify/issues/415255

[jayeshmangwani]

Requested $250

[JmillsExpensify]

$250 approved for @jayeshmangwani