[HOLD for payment 2021-11-04] In IOU Participants page there's absolutely no email / phone number validation message on either Split/Request pages

[Santhosh-Sellavel]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click FAB + Icon
2. New Request/Split
3. Enter Amount
4. In Participant search enter random search text ex '328sdf76sdjsdgj'

Expected Result:

There should be some validation messages like in New Chat/ New Group/ Chat list Search. Like below while search

Expected_Result.mov

Actual Result:

No such validation exists.

Simulator.Screen.Recording.-.iPhone.11.-.2021-08-17.at.18.57.53.mp4

Workaround:

Can the user still use Expensify without this being fixed? Yes
It's an Improvement

Platform:

Where is this issue occurring? All platforms

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

view this job

Suggestion

We could add similar validation like it is in other searches(New Chat, New Group) for IOU Participant pages also!

Proposal

Will propose after the triage & initial discussion.

[MelvinBot]

Triggered auto assignment to @muttmuure (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Santhosh-Sellavel]

Proposal

In here we don't pass any value headerMessage for OptionsSelector component

App/src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsRequest.js

Lines 119 to 122 in bdcafa3

	render() {
	const sections = this.getSections();
	return (
	<OptionsSelector

We can use similar logic from here

App/src/pages/NewChatPage.js

Lines 131 to 135 in bdcafa3

	const headerMessage = getHeaderMessage(
	this.state.personalDetails.length !== 0,
	Boolean(this.state.userToInvite),
	this.state.searchValue,
	);

To get headerMessage pass it on to OptionsSelector in IOUParticipantsRequest.js

Also for IOUParticipantsSplit, we can use the above code again here also

App/src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsSplit.js

Lines 208 to 216 in bdcafa3

	const sections = this.getSections(maxParticipantsReached);
	return (
	<>
	<View style={[styles.flex1, styles.w100]}>
	<Text style={[styles.formLabel, styles.pt3, styles.ph5]}>
	{this.props.translate('common.to')}
	</Text>
	<OptionsSelector
	canSelectMultipleOptions

[MelvinBot]

@muttmuure Still overdue 6 days?! Let's take care of this!

[MelvinBot]

@muttmuure Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

@muttmuure 12 days overdue now... This issue's end is nigh!

[MelvinBot]

This issue has not been updated in over 14 days. @muttmuure eroding to Weekly issue.

[muttmuure]

Sorry I was OOO - it's an interesting proposal and makes sense esp. because it uses existing functionality in the new chat/group feature.

I'm not sure what this touches on the back end so I'll defer to engineering to discuss here.

[MelvinBot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

Looks OK to me. Adding this as an external issue to move forward.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Santhosh-Sellavel]

@tgolen In case you missed proposal is already here #4690 (comment)

[Santhosh-Sellavel]

@jboniface Applied for the job!

[kadiealexander]

Hi @Santhosh-Sellavel, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

[tgolen]

It's OK, Melvin. It's on HOLD

[Santhosh-Sellavel]

Assign this issue to me @tgolen when you can, thanks!

[tgolen]

Assigned!

[jboniface]

still frozen

[parasharrajat]

I am reviewing PR for this issue and I have found a few issues which I will mention in the PR review.

[kadiealexander]

Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

[jboniface]

it looks like this is still in progress

[jboniface]

hold is lifted, this can be moved forward

[jboniface]

this is awaiting payment, not overdue

[jboniface]

paid with bonus for reporting and n6-hold