[OldDot Rules Migration] Individual expense rules

[marcaaron]

Part of the OldDot Rules Migration project

Main issue: https://github.com/Expensify/Expensify/issues/413886

Feature Description

High Level Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.ycyp9y4tlna4

Detailed Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.ore5lrt7u7r

Manual Test Steps

TBD

Automated Tests

TBD

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[WojtekBoman]

@Expensify/design

I have one question about the Billable default page. Currently we don't have a pattern in the app when we select an element from the list and we have to additionally confirm our selection by clicking a button. It causes some issues with setting the background color of the selected item. Usually we don't need to change the background color of the selected item because we close the page once we select an option. I'm wondering if we need this submit button on this page. If so, I'll try to find a solution, but if not, I'll implement it the same as other pages with SelectionList. I'm attaching a video with the current implementation and examples of other pages using SelectionList.

Screen.Recording.2024-08-20.at.17.19.50.mov

Screen.Recording.2024-08-20.at.17.19.12.mov

[WojtekBoman]

@Expensify/design @marcaaron @JmillsExpensify

Do we know what the maximum possible length of numbers that can be entered into these inputs should be?

[melvin-bot]

@marcaaron Eep! 4 days overdue now. Issues have feelings too...

[marcaaron]

I'm wondering if we need this submit button on this page.

This is a good observation. I'm wondering the same thing now. 😄

Do we know what the maximum possible length of numbers that can be entered into these inputs should be?

On the API side there is no maximum. Most people will put reasonably low values because larger values are impractical i.e. it would be the same as putting any large number after a point. If we want to impose something we could use the DISABLED_MAX_EXPENSE_VALUE, but not sure we need to do anything here tbh.

[WojtekBoman]

@Expensify/design

I have one question about the Billable default page. Currently we don't have a pattern in the app when we select an element from the list and we have to additionally confirm our selection by clicking a button. It causes some issues with setting the background color of the selected item. Usually we don't need to change the background color of the selected item because we close the page once we select an option. I'm wondering if we need this submit button on this page. If so, I'll try to find a solution, but if not, I'll implement it the same as other pages with SelectionList. I'm attaching a video with the current implementation and examples of other pages using SelectionList.

Screen.Recording.2024-08-20.at.17.19.50.mov
Screen.Recording.2024-08-20.at.17.19.12.mov

@shawnborton @dannymcclain Could you take a look at it when you have some time?

[shawnborton]

In the page you are referencing for billable default, you are right in that we probably don't need a Save button - we can just allow the selection of the list item to actually select something and change the form.

That being said, we keep running into small bugs where a selected item does not have a correct background color. So whether we save it immediately or not, we really need to make sure all selected list items use the appropriate background color. Let me know if that helps clear things up!

[melvin-bot]

This issue has not been updated in over 15 days. @marcaaron eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!