[OldDot Rules Migration] Individual expense rules #47409

WojtekBoman · 2024-08-14T12:18:53Z

Details

This PR adds a new section to the Rules Page: Individual expense rules. This section allows the user to:

update the receipt required amount
update the max expense amount
update the max expense age
enable or disable the billable mode
enable or disable eReceipts

Implementation details on how the actions listed above work can be found here

Fixed Issues

$ #47013
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Precondition: Make sure you have access to the workspaceRules beta. If you run the app locally you can modify the canUseWorkspaceRules or canUseAllBetas function in Permissions.ts to always return true.

Open the settings of any workspace.
Enable rules if they are disabled for the selected workspace. This feature can be enabled on the More Features page.
Check that the buttons in the first section work correctly in offline and online mode (check that values are updated correctly, that the correct screens are opened, etc.)

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-23.at.12.38.25.mp4

Android: mWeb Chrome

Screen.Recording.2024-08-23.at.12.43.07.mp4

iOS: Native

Screen.Recording.2024-08-23.at.11.50.35.mp4

iOS: mWeb Safari

Screen.Recording.2024-08-23.at.12.34.35.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-08-23.at.14.42.29.mov

MacOS: Desktop

Screen.Recording.2024-08-23.at.11.45.01.mov

…PENSE_VALUE

melvin-bot · 2024-08-20T14:10:09Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

BrtqKr · 2024-08-21T10:40:09Z

src/ONYXKEYS.ts

+        RULES_REQUIRED_RECEIPT_AMOUNT_FORM: 'RulesRequiredReceiptAmountForm',
+        RULES_MAX_EXPENSE_AMOUNT_FORM: 'RulesMaxExpenseAmountForm',
+        RULES_MAX_EXPENSE_AGE_FORM: 'RulesMaxExpenseAgeForm',


I've been using _MODAL_FORM in the naming - I'd suggest unifying it, but there are many cases where a standard _FORM has been applied, so it can go either way 🤷

BrtqKr · 2024-08-21T10:41:18Z

src/components/AmountForm.tsx

+    label?: string;
+
+    displayAsTextInput?: boolean;


I'll add descriptions for both in my PR

BrtqKr · 2024-08-21T10:50:38Z

src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

+            renderSubtitle={() => (
+                <Text style={[styles.flexRow, styles.alignItemsCenter, styles.w100, styles.mt2]}>
+                    <Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.rules.individualExpenseRules.subtitle')}</Text>{' '}
+                    <TextLink
+                        style={styles.link}
+                        onPress={handleOnPressCategoriesLink}
+                    >
+                        {translate('workspace.common.categories').toLowerCase()}
+                    </TextLink>{' '}
+                    <Text style={[styles.textNormal, styles.colorMuted]}>{translate('common.and')}</Text>{' '}
+                    <TextLink
+                        style={styles.link}
+                        onPress={handleOnPressTagsLink}
+                    >
+                        {translate('workspace.common.tags').toLowerCase()}
+                    </TextLink>
+                    .
+                </Text>
+            )}


I'd move this to a separate function or component

BrtqKr · 2024-08-21T10:54:12Z

src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

+                <MenuItemWithTopDescription
+                    key={translate('workspace.rules.individualExpenseRules.receiptRequiredAmount')}
+                    shouldShowRightIcon
+                    title={maxExpenseAmountNoReceiptText}
+                    description={translate('workspace.rules.individualExpenseRules.receiptRequiredAmount')}
+                    onPress={() => {
+                        Navigation.navigate(ROUTES.RULES_RECEIPT_REQUIRED_AMOUNT.getRoute(policyID));
+                    }}
+                    wrapperStyle={[styles.sectionMenuItemTopDescription]}
+                    numberOfLinesTitle={2}
+                />


In my PR moving item content to the array was more necessary, because I had a lot of nested items, but here most of the items have very similar configurations and this would benefit readability a lot because we'd avoid repeating the components and this would be easier to expand in the future

BrtqKr · 2024-08-21T10:56:12Z

src/pages/workspace/rules/RulesBillableDefaultPage.tsx

+
+    return (
+        <AccessOrNotFoundWrapper
+            policyID={route.params.policyID ?? '-1'}


is '-1' required? I think it was accepting undefined value

BrtqKr · 2024-08-21T10:57:20Z

src/pages/workspace/rules/RulesMaxExpenseAgePage.tsx

+    const {inputCallbackRef} = useAutoFocusInput();
+    const policy = usePolicy(route.params.policyID);
+
+    const defaultValue = policy?.maxExpenseAge === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAge ? '' : `${policy?.maxExpenseAge}`;


maybe maxExpenseAgeDefaultValue?

BrtqKr · 2024-08-21T10:58:17Z

src/pages/workspace/rules/RulesMaxExpenseAgePage.tsx

+        let age;
+        if (!maxExpenseAge) {
+            age = CONST.DISABLED_MAX_EXPENSE_VALUE;
+        }
+        age = parseInt(maxExpenseAge, 10);


maybe ternary?

BrtqKr · 2024-08-21T10:59:58Z

src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx

+
+type RulesReceiptRequiredAmountPageProps = StackScreenProps<SettingsNavigatorParamList, typeof SCREENS.WORKSPACE.RULES_RECEIPT_REQUIRED_AMOUNT>;
+
+function RulesReceiptRequiredAmountPage({route}: RulesReceiptRequiredAmountPageProps) {


you're using route.params.policyID in many places, can't we destructure it on the props level?

melvin-bot · 2024-08-23T12:57:55Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

WojtekBoman · 2024-08-23T13:02:31Z

@marcaaron

I have one question. When we upgrade the policy, default max expense amounts are set:

function upgradeToCorporate(policyID: string, featureName: string) {
    const policy = getPolicy(policyID);
    const optimisticData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `policy_${policyID}`,
            value: {
                isPendingUpgrade: true,
                type: CONST.POLICY.TYPE.CORPORATE,
                // HERE DEFAULTS ARE SET
                maxExpenseAge: CONST.POLICY.DEFAULT_MAX_EXPENSE_AGE,
                maxExpenseAmount: CONST.POLICY.DEFAULT_MAX_EXPENSE_AMOUNT,
                maxExpenseAmountNoReceipt: CONST.POLICY.DEFAULT_MAX_AMOUNT_NO_RECEIPT,
                glCodes: true,
                ...(PolicyUtils.isInstantSubmitEnabled(policy) && {
                    autoReporting: true,
                    autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE,
                }),
                harvesting: {
                    enabled: false,
                },
            },
        },
    ];
    
    // CONST.ts
    
      DEFAULT_MAX_EXPENSE_AGE: 90,
      DEFAULT_MAX_EXPENSE_AMOUNT: 200000,
      DEFAULT_MAX_AMOUNT_NO_RECEIPT: 2500,

Is this code still valid or should we set all these values to 10000000000?

pecanoro · 2024-08-23T14:10:10Z

src/languages/es.ts

+                receiptRequiredAmount: 'Monto requerido para recibo',
+                receiptRequiredAmountDescription: 'Requiere recibos cuando el gasto excede este monto, a menos que una regla de categoría lo anule.',


Suggested change

receiptRequiredAmount: 'Monto requerido para recibo',

receiptRequiredAmountDescription: 'Requiere recibos cuando el gasto excede este monto, a menos que una regla de categoría lo anule.',

receiptRequiredAmount: 'Cantidad requerida para los recibos',

receiptRequiredAmountDescription: 'Exige recibos cuando los gastos superen este importe, a menos que lo anule una regla de categoría.',

pecanoro · 2024-08-23T14:11:11Z

src/languages/es.ts

+                maxExpenseAmount: 'Monto máximo de gasto',
+                maxExpenseAmountDescription: 'Marca el gasto que excede este monto, a menos que una regla de categoría lo anule.',


Suggested change

maxExpenseAmount: 'Monto máximo de gasto',

maxExpenseAmountDescription: 'Marca el gasto que excede este monto, a menos que una regla de categoría lo anule.',

maxExpenseAmount: 'Importe máximo del gasto',

maxExpenseAmountDescription: 'Marca los gastos que superen este importe, a menos que una regla de categoría lo anule.',

pecanoro · 2024-08-23T14:11:39Z

src/languages/es.ts

+                maxAge: 'Edad máxima',
+                maxExpenseAge: 'Antigüedad máxima de gasto',


Suggested change

maxAge: 'Edad máxima',

maxExpenseAge: 'Antigüedad máxima de gasto',

maxAge: 'Antigüedad máxima',

maxExpenseAge: 'Antigüedad máxima de los gastos',

pecanoro · 2024-08-23T14:12:33Z

src/languages/es.ts

+                maxExpenseAmountDescription: 'Marca el gasto que excede este monto, a menos que una regla de categoría lo anule.',
+                maxAge: 'Edad máxima',
+                maxExpenseAge: 'Antigüedad máxima de gasto',
+                maxExpenseAgeDescription: 'Marca los gastos con más de un número específico de días.',


Suggested change

maxExpenseAgeDescription: 'Marca los gastos con más de un número específico de días.',

maxExpenseAgeDescription: 'Marca los gastos de más de un número determinado de días.',

pecanoro · 2024-08-23T14:13:42Z

src/languages/es.ts

+                maxExpenseAgeDays: (age: number) => `${age} ${Str.pluralize('día', 'días', age)}`,
+                billableDefault: 'Valor predeterminado facturable',
+                billableDefaultDescription:
+                    'Elige si los gastos en efectivo y con tarjeta de crédito deben ser facturables por defecto. Los gastos facturables se habilitan o deshabilitan en etiquetas',


Suggested change

'Elige si los gastos en efectivo y con tarjeta de crédito deben ser facturables por defecto. Los gastos facturables se habilitan o deshabilitan en etiquetas',

'Elige si los gastos en efectivo y con tarjeta de crédito deben ser facturables por defecto. Los gastos facturables se activan o desactivan en',

pecanoro · 2024-08-23T14:14:24Z

src/languages/es.ts

+                billableDefaultDescription:
+                    'Elige si los gastos en efectivo y con tarjeta de crédito deben ser facturables por defecto. Los gastos facturables se habilitan o deshabilitan en etiquetas',
+                billable: 'Facturable',
+                billableDescription: 'Los gastos se vuelven a facturar a los clientes con mayor frecuencia',


Suggested change

billableDescription: 'Los gastos se vuelven a facturar a los clientes con mayor frecuencia',

billableDescription: 'Los gastos se vuelven a facturar a los clientes en la mayoría de los casos',

pecanoro · 2024-08-23T14:15:21Z

src/languages/es.ts

+                billable: 'Facturable',
+                billableDescription: 'Los gastos se vuelven a facturar a los clientes con mayor frecuencia',
+                nonBillable: 'No facturable',
+                nonBillableDescription: 'Los gastos ocasionalmente se vuelven a facturar a los clientes',


Suggested change

nonBillableDescription: 'Los gastos ocasionalmente se vuelven a facturar a los clientes',

nonBillableDescription: 'Los gastos se vuelven a facturar a los clientes en ocasiones',

pecanoro · 2024-08-23T14:16:38Z

src/languages/es.ts

+                eReceiptsHint: 'El Recibos electrónicos se crean automáticamente para',
+                eReceiptsHintLink: 'la mayoría de las transacciones con crédito en USD',


Suggested change

eReceiptsHint: 'El Recibos electrónicos se crean automáticamente para',

eReceiptsHintLink: 'la mayoría de las transacciones con crédito en USD',

eReceiptsHint: 'Los recibos electrónicos se crean automáticamente',

eReceiptsHintLink: 'para la mayoría de las transacciones en USD',

shawnborton · 2024-08-23T15:47:06Z

Screenshots look pretty good to me!

marcaaron · 2024-08-23T19:37:51Z

Is this code still valid or should we set all these values to 10000000000?

@WojtekBoman What you have there appears to be correct. When the API is called to upgrade to corporate those are the default values we set.

marcaaron · 2024-08-23T23:30:59Z

src/libs/API/types.ts

+    SET_POLICY_EXPENSE_MAX_AMOUNT: 'SetPolicyExpenseMaxAmount',
+    SET_POLICY_EXPENSE_MAX_AGE: ' SetPolicyExpenseMaxAge',
+    SET_POLICY_BILLABLE_MODE: ' SetPolicyBillableMode',
+    SET_WORKSPACE_ERECEIPTS_ENABLED: 'SetWorkspaceEReceiptsEnabled',


Note to myself that I will create some issue to fix this as polish.

marcaaron · 2024-08-24T00:54:30Z

Looks great so far!

WojtekBoman · 2024-08-26T06:50:32Z

I don't have beta access right now, so I set canUseWorkspaceRules to true. However, the fields in the Individual expense rules section show default values instead of being blank, as shown in the PR screenshot:

video

The fields are editable, and everything else works well. Could this behavior be related to not having beta access? Should we be concerned about this? Thanks.

cc: @WojtekBoman @marcaaron

I mentioned it here. When we upgrade our policy, the default values for rules are set

brunovjk · 2024-08-26T10:57:59Z

@WojtekBoman What you have there appears to be correct. When the API is called to upgrade to corporate those are the default values we set.

Sorry, I missed that. I'm testing on all platforms and will fill out the checklist.

brunovjk · 2024-08-26T13:42:39Z

Excuse @WojtekBoman, what should happen when we save a 'max expense age' equal to the maximum limit? Thanks.

Screen.Recording.2024-08-26.at.10.29.55.mov

WojtekBoman · 2024-08-26T14:31:34Z

Excuse @WojtekBoman, what should happen when we save a 'max expense age' equal to the maximum limit? Thanks.

Screen.Recording.2024-08-26.at.10.29.55.mov

I asked about it here @marcaaron Could you take a look at it?

brunovjk · 2024-08-26T14:46:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

47409_android_native.mov

Android: mWeb Chrome

47409_android_web.mov

iOS: Native

47409_ios_native.mov

iOS: mWeb Safari

47409_ios_web.mov

MacOS: Chrome / Safari

47409_browser.mov

MacOS: Desktop

47409_desktop.mov

brunovjk · 2024-08-26T14:53:36Z

I can reproduce this issue in the 'receipt required amount' and 'max expense amount' fields (in native only).

47409_dupe_issue_native.mov

brunovjk

Miding those comments: #comment_1 and #comment_2 everything else LGTM.

marcaaron

LGTM

OSBotify · 2024-08-26T23:42:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-28T21:44:15Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.26-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-30T18:32:43Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Ollyws · 2025-01-16T10:03:31Z

src/components/TextInput/BaseTextInput/index.tsx

@@ -402,6 +407,17 @@ function BaseTextInput(
                                defaultValue={defaultValue}
                                markdownStyle={markdownStyle}
                            />
+                            {!!suffixCharacter && (


We missed adding suffix handling to native (#54363), so we added it in #54549

allgandalf · 2025-02-10T06:37:36Z

src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

+    const policyCurrency = policy?.outputCurrency ?? CONST.CURRENCY.USD;
+
+    const maxExpenseAmountNoReceiptText = useMemo(() => {
+        if (policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAmountNoReceipt) {


We shouldn't had returned empty string if the amount was 0, this caused #54290

WojtekBoman added 18 commits August 8, 2024 14:28

Add IndividualExpenseRulesSection

82be201

Merge branch 'rules/toggle' into rules/individual-expense-rules

7078618

Add links to categories and tags pages

f973e79

Add individual expense rules rhp screens templates

5cf7c48

Merge branch 'rules/toggle' into rules/individual-expense-rules

8e10e14

Add types for individual expense rules number forms

85e89df

Handle displaying amount form as text input

18cb8b6

Add types for individual expense rules actions

c356109

Handle setPolicyMaxExpenseAmountNoReceipt action

c61f3ca

Handle setting billable mode

57d8e9c

Rename DEFAULT_MAX_EXPENSE_AMOUNT_NO_RECEIPT const to DISABLED_MAX_EX…

d786f8f

…PENSE_VALUE

Handle setting max expense amount

fe1e10f

Handle toggling eReceipts

3e6f02e

Cleanup rules forms

7f8c373

Add suffixCharacter prop to BaseTextInput

d52c8be

Add setPolicyMaxExpenseAge and cleanup rules actions

cdde66b

Handle setting maxExpenseAge

d9aad75

Handle link to Tags page on RulesBillableDefaultPage

dc57a47

WojtekBoman changed the title ~~Rules/individual expense rules~~ [OldDot Rules Migration] Individual expense rules Aug 20, 2024

WojtekBoman added 6 commits August 21, 2024 09:49

Add maxLength to RulesMaxExpenseAgePage

f62182d

Adjust paddings on Rules pages

706eec6

Cleanup rules actions

8af85ba

Remove unused imports

60f743d

Add missing docs for policy actions

70baaf1

Refactor onSubmit in RulesMaxExpenseAgePage

d58b903

BrtqKr reviewed Aug 21, 2024

View reviewed changes

WojtekBoman added 3 commits August 21, 2024 13:18

Rename SetPolicyEReceiptsEnabled to SetWorkspaceEReceiptsEnabled

e919113

Add IndividualExpenseRulesSectionSubtitle

b9b94b0

Refactor destructuring route params on rules pages

6d7b7a1

melvin-bot bot requested review from brunovjk and removed request for a team August 23, 2024 12:57

pecanoro requested changes Aug 23, 2024

View reviewed changes

marcaaron assigned WojtekBoman Aug 23, 2024

marcaaron reviewed Aug 23, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

Fix individual expense rules es translations

3750539

brunovjk approved these changes Aug 26, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron August 26, 2024 15:26

pecanoro approved these changes Aug 26, 2024

View reviewed changes

marcaaron approved these changes Aug 26, 2024

View reviewed changes

marcaaron merged commit cc9b8b7 into Expensify:main Aug 26, 2024
17 checks passed

github-actions bot mentioned this pull request Aug 28, 2024

Deploy Checklist: New Expensify 2024-08-28 #48221

Closed

93 tasks

linhvovan29546 mentioned this pull request Dec 19, 2024

[BZ Checklist][$250] Rules - "days" is not displayed In Max expense age page #54363

Closed

8 tasks

Ollyws reviewed Jan 16, 2025

View reviewed changes

allgandalf reviewed Feb 10, 2025

View reviewed changes


		type RulesReceiptRequiredAmountPageProps = StackScreenProps<SettingsNavigatorParamList, typeof SCREENS.WORKSPACE.RULES_RECEIPT_REQUIRED_AMOUNT>;

		function RulesReceiptRequiredAmountPage({route}: RulesReceiptRequiredAmountPageProps) {

		receiptRequiredAmount: 'Monto requerido para recibo',
		receiptRequiredAmountDescription: 'Requiere recibos cuando el gasto excede este monto, a menos que una regla de categoría lo anule.',

		maxExpenseAmount: 'Monto máximo de gasto',
		maxExpenseAmountDescription: 'Marca el gasto que excede este monto, a menos que una regla de categoría lo anule.',

		maxAge: 'Edad máxima',
		maxExpenseAge: 'Antigüedad máxima de gasto',

	maxExpenseAgeDescription: 'Marca los gastos con más de un número específico de días.',
	maxExpenseAgeDescription: 'Marca los gastos de más de un número determinado de días.',

	'Elige si los gastos en efectivo y con tarjeta de crédito deben ser facturables por defecto. Los gastos facturables se habilitan o deshabilitan en etiquetas',
	'Elige si los gastos en efectivo y con tarjeta de crédito deben ser facturables por defecto. Los gastos facturables se activan o desactivan en',

	billableDescription: 'Los gastos se vuelven a facturar a los clientes con mayor frecuencia',
	billableDescription: 'Los gastos se vuelven a facturar a los clientes en la mayoría de los casos',

	nonBillableDescription: 'Los gastos ocasionalmente se vuelven a facturar a los clientes',
	nonBillableDescription: 'Los gastos se vuelven a facturar a los clientes en ocasiones',

		eReceiptsHint: 'El Recibos electrónicos se crean automáticamente para',
		eReceiptsHintLink: 'la mayoría de las transacciones con crédito en USD',

[OldDot Rules Migration] Individual expense rules #47409

[OldDot Rules Migration] Individual expense rules #47409

Conversation

WojtekBoman commented Aug 14, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 23, 2024

WojtekBoman commented Aug 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shawnborton commented Aug 23, 2024

marcaaron commented Aug 23, 2024

Choose a reason for hiding this comment

marcaaron commented Aug 24, 2024

This comment was marked as outdated.

WojtekBoman commented Aug 26, 2024

brunovjk commented Aug 26, 2024

brunovjk commented Aug 26, 2024

WojtekBoman commented Aug 26, 2024 • edited Loading

brunovjk commented Aug 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

brunovjk commented Aug 26, 2024

brunovjk left a comment

Choose a reason for hiding this comment

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 26, 2024

OSBotify commented Aug 28, 2024

OSBotify commented Aug 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WojtekBoman commented Aug 14, 2024 •

edited

Loading

WojtekBoman commented Aug 26, 2024 •

edited

Loading

brunovjk commented Aug 26, 2024 •

edited

Loading