Rules - Rules in left hand navigation does not follow the order in More features list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > More features
3. Enable all the features

Expected Result:

The features in the left hand navigation should follow the order of features in More features list
Rules should be arranged between Workflows and Categories

Actual Result:

Rules is at the end of the list in the left hand navigation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6586551_1724936172274.20240829_205227.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rules - Rules in left hand navigation does not follow the order in More features list

What is the root cause of that problem?

The rules menuItem is at the end of the list in WorkspaceInitialPage.tsx

What changes do you think we should make in order to solve the problem?

We will move the rules menuItem from here:

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 315 to 322 in e77f204

	if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED] && canUseWorkspaceRules) {
	protectedCollectPolicyMenuItems.push({
	translationKey: 'workspace.common.rules',
	icon: Expensicons.Feed,
	action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_RULES.getRoute(policyID)))),
	routeName: SCREENS.WORKSPACE.RULES,
	});
	}

to here.

[puneetlath]

Demoting since rules is under beta. cc @marcaaron

[melvin-bot]

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

[WojtekBoman]

We'll adjust this in one of our rules related PRs

[Guccio163]

Hi, I just fixed it in the #48184 PR as per @WojtekBoman 's request, it is already approved by C+ so I think it'll be soon merged 👌

Screen.Recording.2024-08-30.at.10.41.52.mov

[melvin-bot]

@puneetlath, @Guccio163 Whoops! This issue is 2 days overdue. Let's get this updated quick!