[HOLD for payment 2021-11-04] mWeb - Safari- Zoom in behavior of PDF is inconsistent

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate ro staging URL
2. Select any Chat
3. Click on add attachment
4. Upload a PDF
5. Click on the PDF preview
6. Verify you can pinch the image to zoom in and zoom out

Expected Result:

User is able to zoom in on PDF with no issues

Actual Result:

After zoom in it changes back to original size or smaller size

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web Safari

Version Number:
1.0.88.0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5210403_RPReplay_Final1629985697.mp4

Upwork Job URL: https://www.upwork.com/jobs/~0177c60d6df6abbfbb

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

It can be affected by #4769 so we should wait and see the effect.

[isagoico]

Issue reproducible during KI retests

[MelvinBot]

@AndrewGable Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[AndrewGable]

Actually - @isagoico can you check if this is still present after #4769 was deployed before we export this to Upwork? Thanks!

[isagoico]

Asked a tester to check ane issue is still reproducible in v1.0.90

[AndrewGable]

Ok then this is reproducible and should be exported to Upwork @trjExpensify - Thanks!

[trjExpensify]

Posted to Upwork here. 👍

[trjExpensify]

No applications yet.

[isagoico]

Issue reproducible during KI retests

[trjExpensify]

Still no applications.

[AndrewGable]

Yes please per the Contributing guidelines @trjExpensify will hire you when he gets the Upwork application 👍

[eVoloshchak]

Yes please per the Contributing guidelines @trjExpensify will hire you when he gets the Upwork application 👍

Applied for a job on Upwork

I have one more question:
Should we check if the app is running in mobile web in safari and apply this fix only if that is the case? Or should we use this method for all the platforms? I've tested desktop web and native android versions with this fix applied, everything works as expected, but it will probably be better from the testing perspective to apply it only for the specific platform problem occurred at.

[AndrewGable]

I'd apply the change across all platforms, then make sure it doesn't break any of the other platforms. I agree with your thoughts, we just do not like platform specific checks unless they are necessary

[eVoloshchak]

I'd apply the change across all platforms, then make sure it doesn't break any of the other platforms. I agree with your thoughts, we just do not like platform specific checks unless they are necessary

Yeah, i verified it working on other platforms.
I've submitted the PR, but there seems to be a problem with my git config, I'm working on resolving it.

[AndrewGable]

It looks like you just need to sign the CLA as prompted by CLA Bot

[eVoloshchak]

It looks like you just need to sign the CLA as prompted by CLA Bot

I've already signed the CLA when working with you previously.
The issue is, my commits are authored not by me, but by "Dev authored and Dev committed".
So there must be something wrong with my git config.
CLA Assistant Lite bot says that "Dev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA."

So I'll try to somehow link this "Dev" account to my github account, and if I cant, I'll just open a new PR with commit that has a correct author.

[trjExpensify]

Hey @eVoloshchak did you accept the offer on upwork? It still says it's pending waiting for you to accept.

[eVoloshchak]

Hey @eVoloshchak did you accept the offer on upwork? It still says it's pending waiting for you to accept.

Sorry, I'm a little new to the upwork, didn't realise there's an extra step.
I've accepted it just now.

[trjExpensify]

Awesome, that's done. Thanks!

[parasharrajat]

I will be reviewing the PR and I will let you know @AndrewGable when this is ready for final review and possibly for merge. See More

[AndrewGable]

Exciting @parasharrajat! 🎉

[eVoloshchak]

@AndrewGable, my upwork contract for this issue is due 19 october (tomorrow). Do I submit work for payment even though my PR hasn't been approved yet? Or is the contract date flexible?
I'm new to upwork so pardon me if i'm asking something obvious.

[trjExpensify]

Hey @eVoloshchak, the contract date is flexible, so need to do anything in that regard.

[eVoloshchak]

Hey @eVoloshchak, the contract date is flexible, so need to do anything in that regard.

Great, thank you

[mvtglobally]

Issue reproducible during KI retests.

[mvtglobally]

Issue not reproducible during KI retests. (First Week)

[mvtglobally]

Issue not reproducible during KI retests. (Second Week)

[trjExpensify]

Presuming this is passing the KI retests because the PR has merged, right?

[trjExpensify]

Anyhow, I've gone ahead and paid this, so I'm closing it out. 👍