Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with zoom behaviour of PDF being inconsistent in Safari mobile #5773

Closed
wants to merge 1 commit into from
Closed

Fix issue with zoom behaviour of PDF being inconsistent in Safari mobile #5773

wants to merge 1 commit into from

Conversation

eVoloshchak
Copy link
Contributor

Details

inconsistent behaviour was caused by Dimensions 'change' listener returning invalid window sizes when zooming in or out.
We've settled on using pdf container's width to determine the page width.

Fixed Issues

$ #4867

Tests

  1. run npm run web
  2. navigate to any chat that has a pdf attachment
  3. click on pdf attachment to open it
  4. zoom in as close as possible, zoom out
  5. validate that zoom is consistent and layout isn't changing

QA Steps

Same as Tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Device: iPhone X
OS: iOS 14.7.1

vert.mp4
horiz.mp4

@eVoloshchak eVoloshchak requested a review from a team as a code owner October 12, 2021 16:23
@MelvinBot MelvinBot requested review from AndrewGable and removed request for a team October 12, 2021 16:23
@github-actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Dev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@eVoloshchak
Copy link
Contributor Author

Closing this due to a problem with my git configuration, my bad.
Opened a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant