Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-18] [HOLD for payment 2024-10-17] [Direct Feeds] [Backend] Create and remove beta for direct feeds #50458

Closed
mountiny opened this issue Oct 8, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 8, 2024

This is part of the Third party workspace feeds V2 (direct connections) project.

Implement the canUseDirectFeeds beta for direct feeds and then clean it up

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 8, 2024
@mountiny mountiny self-assigned this Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 8, 2024
@mountiny mountiny added the Reviewing Has a PR in review label Oct 8, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 8, 2024
@melvin-bot melvin-bot bot changed the title [Direct Feeds] [Backend] Create and remove beta for direct feeds [HOLD for payment 2024-10-17] [Direct Feeds] [Backend] Create and remove beta for direct feeds Oct 10, 2024
Copy link

melvin-bot bot commented Oct 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 10, 2024
Copy link

melvin-bot bot commented Oct 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-17. 🎊

Copy link

melvin-bot bot commented Oct 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mountiny] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@dylanexpensify dylanexpensify moved this to Hold for Payment in [#whatsnext] #expense Oct 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Oct 21, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2024
@mountiny
Copy link
Contributor Author

Not overdue

@mountiny mountiny added the Monthly KSv2 label Oct 21, 2024
@mountiny
Copy link
Contributor Author

This can be monthly

@melvin-bot melvin-bot bot added the Overdue label Oct 29, 2024
@mountiny
Copy link
Contributor Author

not there yet

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 Monthly KSv2 labels Nov 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-10-17] [Direct Feeds] [Backend] Create and remove beta for direct feeds [HOLD for payment 2024-11-18] [HOLD for payment 2024-10-17] [Direct Feeds] [Backend] Create and remove beta for direct feeds Nov 11, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 11, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-18. 🎊

Copy link

melvin-bot bot commented Nov 11, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mountiny] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@DylanDylann
Copy link
Contributor

No need checklist

@mountiny
Copy link
Contributor Author

$125 to @DylanDylann for testing

@mountiny
Copy link
Contributor Author

Jus removing the beta so no need for checklist

@joekaufmanexpensify
Copy link
Contributor

Will do!

@DylanDylann
Copy link
Contributor

I think we can close it and handle payment later

@DylanDylann
Copy link
Contributor

I have already noted all polish issues in the third-party workspace feed that I worked on. And we can handle all payments in one after allis done

This comment was marked as outdated.

@joekaufmanexpensify
Copy link
Contributor

Works for me! Closing then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants