Payment issue for the workspace feeds clean up tasks

[mountiny]

Over the last two months, we have been cleaning up and polishing the workspace feeds, that is, Expensify cards, third-party cards, and direct feeds. @DylanDylann @allgandalf @dukenv0307 worked on the issues, and because there were many small issues, we agreed to reward them with $125 per PR reviewed unless agreed otherwise.

Creating this payment issue as they will list all the issues/ PRs they have reviewed and helped and they were not paid for them originally to simplify the payment process.

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[DylanDylann]

This is my task list:

1. [HOLD for payment 2024-11-14] [Workspace feeds] Credit Incorrectly Capitalized in Export Row #51890
2. [HOLD for payment 2024-11-14] [Workspace Feeds] Card name field does not have character limit #51899
3. [HOLD for payment 2024-11-14] [Workspace feeds] Card name subheader appearing below the field, instead of below the header #51917
4. [HOLD for payment 2024-11-14] [Workspace Feeds] Selecting "From the beginning" when assigning a card seems to just default to the current date #51863
5. [HOLD for payment 2024-11-26] [HOLD for payment 2024-11-21] [HOLD for payment 2024-11-20] [Workspace feeds] Unassigning a card offline seems to use pattern A, when the doc says it should be pattern B.  #51876
6. [HOLD for payment 2024-11-20] [Workspace Feeds] Loading Circle Displays Indefinitely When Queuing Offline Card Update #51895
7. [HOLD for payment 2024-11-20] [Workspace feeds] "Not here" message shown when trying to access card details page for cards assigned to other employees. #51914
8. [HOLD for payment 2024-11-20] [Workspace Feeds] Only showing last 4 digits of card on card details page #51912
9. [HOLD for payment 2024-11-20] [Workspace Feeds] Transaction start date in card details page is one day prior to the selected date when assigning a card #51915
10. [HOLD for payment 2024-12-05] [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" #51891
11. [Workspace feeds] We're erroneously showing an export row when "vendor bill" is selected as the export option for QBO #51887
12. [HOLD for payment 2024-11-20] [Workspace Feeds] Export Row Not Updating on Card Details Page After Selection #51880
13. [HOLD for payment 2024-12-16] [$250] [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-03] Clean up card assignment when only one member and/or card #52820
14. [HOLD for payment 2024-11-18] [HOLD for payment 2024-10-17] [Direct Feeds] [Backend] Create and remove beta for direct feeds #50458
15. [HOLD for payment 2024-11-29] [Company Cards] Update the Amex cards format #52551
16. [HOLD for payment 2024-12-03] [HOLD FOR #52893] [Company Cards] Card number is not visible in the cards table  #52915
17. [HOLD for payment 2024-12-16] [$250] Update empty state for workspace feeds #53091
18. [HOLD for payment 2024-12-16] Card assignment cleanup, multiple members down to one  #53469
19. [HOLD for payment 2024-12-03] [Company cards] Navigate to some other existing feed after removing one #52886
20. Redirect to feed after completing the bank connection #52016 (This is the PR link because there is no created issue, most of the conversation is discussed on Slack)
21. [HOLD for payment 2024-12-20] [$250] [Workspace Feeds] Auth RequestReplacementExpensifyCard returned an error when deactivating card #50394
22. [HOLD for payment 2024-12-20] [$250] Screen briefly flashes Chase feed page after connecting Amex feed and back to expensify #53510
23. [HOLD for payment 2025-01-13] Deleting a custom card feed while offline behaves unexpectedly #54379

[sakluger]

Waiting for @allgandalf and @dukenv0307 to add their issues, then I can handle payment for all of them.

[mountiny]

@DylanDylann 23 issues - 23 * 125 = $2875

[dukenv0307]

Issues I took as C+:

#51563
#51660
#51909
#51905
#51906
#53506
#53507
#54373
#54372
#54371
#54369
#52169
#54856

Issues I took as C:

#53091

[sakluger]

I've assigned the payees for better visibility. @allgandalf let us know which issues you need to be paid for, thanks!

[allgandalf]

I'll post in hour or so.... sorry for the delay

[mountiny]

Any updates?

[allgandalf]

1. [no payment] [Custom feeds] Incorrect default feed name #51570
2. [HOLD for payment 2024-11-20] [$250] Brief loading circle when accessing Company Cards page #51333
3. [$250] [HOLD for payment 2024-11-07] [3rd Party Feeds] FE: Build out report action about the assigned card #51401
4. [HOLD for payment 2024-11-11] [Workspace Feeds] Default feedname should be %bank% cards #51558
5. [$250] [Custom feeds] Feed details explanations are missing #51563
6. [HOLD for payment 2024-11-11] [Custom feeds] The freeform fields have incorrect limit #51564
7. [Custom feeds] Land on the pending feed page after creating a second feed  #51567
8. [HOLD for payment 2024-10-25] [Workspace feeds polish] SmartLimit option not showing on WorkspaceEditCardLimitTypePage #50784
9. [HOLD App#52252] [$250] [Workspace Feeds] Company Cards - Unable to remove card feed that's under review #51858
10. [HOLD for payment 2024-11-18] [Workspace feeds] Company Cards - Bank name persists between different banks in the Other card feed #51860
11. [HOLD for payment 2024-11-18] [$250] [Workspace Feeds] Missing search bar when export row has 8+ options. #51884
12. [HOLD for payment 2024-11-20] [Workspace Feeds] Loading Circle Displays Indefinitely When Queuing Offline Card Update #51895
13. [HOLD for payment 2024-11-18] [Workspace Feeds] Card name field missing on confirmation page #51908
14. [HOLD for payment 2024-11-22] [Workspace feeds] Card art on card details page looks a bit smaller than the mockups #51910
15. [HOLD for payment 2024-11-26] [Workspace Feeds] Pull the direct feed data from different place in domain_member NVP  #52251
16. [HOLD for payment 2024-11-26] [Comapny cards] Do not show the Expensify cards option if the policy is not provisioned for it #52552
17. [HOLD for payment 2024-11-29] [$250] [Workspace feeds - Direct] Search page Card filter should show card name #52554
18. [HOLD for payment 2024-12-05] [Company cards] The card name after assignment is not showing correctly #52558
19. [HOLD for payment 2024-11-29] [$250] Add a loader to the cards page while waiting for cards collection and feed settings  #52559
20. [HOLD for payment 2024-12-03] [$125] Polish updates to Amex card flow #52798
21. [HOLD for payment 2024-12-05] [Company cards] Handle company cars page reloading when changing feeds #52909
22. [HOLD for payment 2024-12-07] Clean up terms used when adding a card feed #52970
23. [HOLD for payment 2024-12-07] Amex direct feeds polish #53083
24. [HOLD for payment 2024-12-30] [$250] Android & iOS - Expensify Card - Previous data is not cleared when issuing new card #53375
25. [HOLD for payment 2024-12-19] [$250] [HOLD for payment 2024-12-16] Incorrect default feed name in feed selector  #53470
26. Assigned direct feed card is wiped after signing out and back in on mobile #53517
27. [Due for payment 2025-02-27] [HOLD for payment 2025-01-17] Handle the direct feed credentials expiration gracefully #54298 ( This one still has Part 2 pending for making code DRY)

Total payment

27 issues: 27 * 125 = $3375

[sakluger]

Wow, lots of issues! Thanks everyone - I'm preparing the payment summary now.

[sakluger]

Summarizing payment on this issue:

@DylanDylann $2875, sent offer via Upwork: https://www.upwork.com/nx/wm/offer/105678709
@allgandalf $3375, sent offer paid via Upwork: https://www.upwork.com/nx/wm/offer/105678781
@dukenv0307 $1,750 ($125 X 14 issues), please request on Newdot

[allgandalf]

Accepted thanks! 😄

[DylanDylann]

@sakluger Accepted too, ty!

[JmillsExpensify]

$1,750 approved for @dukenv0307

[sakluger]

Both Upwork contracts have been paid. Thanks everyone!

[mountiny]

Thanks for handling this and thanks everyone for helping with the projects ❤