[HOLD for payment 2024-11-26] [Workspace Feeds] Pull the direct feed data from different place in domain_member NVP

[mountiny]

Problem

Coming from here

The v1 custom feeds and the v2 direct feeds domain_member nvp are structured in different way so we need to pull the card details from different place in the NVP cardFeeds?.settings?.oAuthAccountDetails

At least getSelectedFeed function should be updated, but I see a couple more places in the code.

Solution

We need to make util methods for pulling the feed details agnostic of whether they are custom or direct feed

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[allgandalf]

can you please assign me here @mountiny 👋

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

Updates:
I've finalized the main code updates and created a Draft PR. But I still need to do a couple of small clean-ups and which is more important do intensive testing over different feeds and its states. If everything goes well I'll open the PR for the review on Monday on Tuesday (Monday was a national holiday in Poland).

[mountiny]

@VickyStash could you also try to think of adding unit tests to all these actions and methods? we are going to start requiring unit tests more often

[VickyStash]

@VickyStash could you also try to think of adding unit tests to all these actions and methods? we are going to start requiring unit tests more often

Sure, will do!

[allgandalf]

not overdue sir melvin

[allgandalf]

Update for melv, PR is in draft state #52268

[VickyStash]

The PR is ready for the review!

[VickyStash]

PR is merged!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.63-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Internal QA] [Workspace Feeds] Pull the workspace feed data from different place in domain_member NVP #52268

If no regressions arise, payment will be issued on 2024-11-26. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @isabelastisser @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

No payment required here @isabelastisser , I will be paid in bulk as part of project, I will update the checklist tomorrow

[allgandalf]

@mountiny this is a difference between V1 and V2 as we didn't have direct feed back then, this shouldn't require a checklist as no offending PR as such, we can close this one

[mountiny]

@allgandalf lets still fill it out, I believe there are boxes to capture this too

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A (There was no direct feed connection at the time of creating the util function which caused this issue, so we never configured it to fetch feed data from different places.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

No regression test, this issue is part of a project, all the tests will be provided at the end of project.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[mountiny]

Payments handled per project, we can close this now