Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-29] [Company Cards] Update the Amex cards format #52551

Closed
mountiny opened this issue Nov 14, 2024 · 9 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Nov 14, 2024

Coming from here

Lets update the Amex cards format to show as 4 digits, 6 digits, 5 digits because they are 15 digits number. This ensure they will look nice in the product.

Issue OwnerCurrent Issue Owner: @zanyrenney
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 14, 2024
@mountiny mountiny self-assigned this Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@DylanDylann
Copy link
Contributor

@mountiny I can help on this issue

@VickyStash
Copy link
Contributor

Updates:

  • Implemented updates and opened the Draft PR.

TODOs:

  • Add screenshots for mobile platforms
  • Add unit tests for maskCardNumber function.

I think the PR will be ready for the review tomorrow in the first part of the day.

@mountiny mountiny added the Reviewing Has a PR in review label Nov 14, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 15, 2024
@VickyStash
Copy link
Contributor

The PR is ready for the review!

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 19, 2024
@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 19, 2024
@garrettmknight garrettmknight added the Internal Requires API changes or must be handled by Expensify staff label Nov 19, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 22, 2024
@melvin-bot melvin-bot bot changed the title [Company Cards] Update the Amex cards format [HOLD for payment 2024-11-29] [Company Cards] Update the Amex cards format Nov 22, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 22, 2024

@DylanDylann @zanyrenney @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor Author

Seems like we are going to update the card formats again and show only the last 4 pans across the App so I dont think we need regression tests for this change yet, we will handle that in the follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants