[HOLD for payment 2024-11-29] [$250] Add a loader to the cards page while waiting for cards collection and feed settings

[JmillsExpensify]

One pattern we use extensively in other pages is a little spinner to help the user understand that we don't quite yet have all the data, and then one we do, the spinner disappears and the content shows. Here's how that looks for the categories page in the workspace editor.

All in all, we need to:

• If the user is online: Show a spinner while we wait for a 200 response from cards collection and feed settings
• If the user is offline: Don't show the spinner and show whatever data we have.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857059797769493830
• Upwork Job ID: 1857059797769493830
• Last Price Increase: 2024-11-14
• Automatic offers:
• allgandalf | Contributor | 104898980

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[narefyev91]

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857059797769493830

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[JmillsExpensify]

Removing Help Wanted since we only need C+ help on this issue.

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

this is worked on as part of the company cards project so assigning dedicated c+

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Internal QA]: Add a loader to the cards page while waiting for cards collection and feed settings #52615

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @allgandalf requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[allgandalf]

I think we can close this one, no regression test here because:

1. it's part of a project
2. and we are changing the loading spinner behaviour with

• [Workspace Feeds]: Update isLoading both for expensify and company cards #52949

[mountiny]

Agreed, we are still cleaning up the exact logic for the spinner so we can close this one, payments will be handled post-project