[HOLD for payment 2024-12-25] E2E: Improve stability of linking test

[hannojg]

The e2e test pipeline produces a false positive now once a day on average. It is always the linking test that turns out false positive.
We should investigate why that test is unstable and fix it (it could also mean that there is actually a performance problem on that screen that causes performance to fluctuate).

Examples of false positives are:

• fix: username, last 4 and limit amount are not aligned on the same line #52743 (comment)
• fix: Update second Allow location access modal on web #51709 (comment)
• Don't complete onboarding if not an invited user #52656 (comment)

Issue Owner

Current Issue Owner: @anmurali

[hannojg]

cc @kirillzyusko

[hannojg]

I am available to look into this issue so feel free to assign me (Hanno from margelo here who built the e2e pipeline) 😊

[melvin-bot]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hannojg]

Now that #53854 is merged we are monitoring to see if the stability has increased.

However, there are current build errors in the e2e pipeline which @perunt is working on fixing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.76-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Improve stability of linking test #53854

If no regressions arise, payment will be issued on 2024-12-25. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @hannojg does not require payment (Contractor)

[puneetlath]

However, there are current build errors in the e2e pipeline which @perunt is working on fixing

Is this still ongoing?

[perunt]

Is this still ongoing?

The pipeline is currently working. I'm now fixing issues here and adding new e2e tests.

Do you have anything specific you'd like me to look into?

[puneetlath]

Nothing in particular. Just wondering about the status of this issue and whether it still needs to be open.

[perunt]

We received one reaction so far, but to be honest, it looks like a valid one.
https://margelo.slack.com/archives/C05LX9D6E07/p1734057241423909
So, if we receive some issues related to that, we can reopen it. But for now, after 7 days, there have been no issues with it, so I can carefully assume that it is fixed

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @anmurali you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $250 via NewDot
• Contributor: @hannojg is from an agency-contributor and not due payment

BugZero Checklist (@anmurali)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@puneetlath, @eVoloshchak, @anmurali, @hannojg Huh... This is 4 days overdue. Who can take care of this?

[puneetlath]

Ok sounds good @perunt. I think all that's left then is for @anmurali to pay out @eVoloshchak.

[anmurali]

Payment Summary

• @eVoloshchak $250 approved via New Dot.

[JmillsExpensify]

$250 approved for @eVoloshchak