fix: mWeb - Chat - Part of the #Admins welcome message is still in english when changing language. #52159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…glish when changing language. Signed-off-by: krishna2323 <[email protected]>
melvin-bot
bot
requested review from
rushatgabhane
and removed request for
a team
|
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@rushatgabhane, I don't think we need translation confirmation because the same translation is already being used. WDTY? Line 662 in 9f97734 |
|
reviewing |
| @@ -660,7 +660,7 @@ const translations = { | |||
| beginningOfChatHistoryDomainRoomPartTwo: ' Úsalo para chatear con colegas, compartir consejos y hacer preguntas.', | |||
| beginningOfChatHistoryAdminRoomPartOne: ({workspaceName}: BeginningOfChatHistoryAdminRoomPartOneParams) => | |||
| `Este chat es con los administradores del espacio de trabajo ${workspaceName}.`, | |||
| beginningOfChatHistoryAdminRoomPartTwo: ' Use it to chat about workspace setup and more.', | |||
| beginningOfChatHistoryAdminRoomPartTwo: ' Úsalo para hablar sobre la configuración del espacio de trabajo y más.', | |||
There was a problem hiding this comment.
@Krishna2323 could you please use spanish here?
There was a problem hiding this comment.
@rushatgabhane, I'm not sure WDYM😅. Could you please explain?
There was a problem hiding this comment.
sorry, this review comment is outdated. ignore
|
@rushatgabhane bump |
|
@rushatgabhane Gentle bump on the review here, thanks. |
Reviewer Checklist
Screenshots/VideosAndroid: Native
Android: mWeb ChromeiOS: NativeEnglish
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
|
rushatgabhane
approved these changes
Nov 21, 2024
techievivek
approved these changes
Nov 21, 2024
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
Just a translation PR, shouldn't impact the performance in any way. Going to remove the blocker lable. |
techievivek
removed
the
DeployBlockerCash
|
Yes, was a false positive and can be ignored as of: |
75 tasks
|
🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.66-0 🚀
|
8 tasks
8 tasks
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.66-8 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #51577
PROPOSAL: #51577 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop