[HOLD for payment 2024-12-07] Clean up terms used when adding a card feed

[joekaufmanexpensify]

@JmillsExpensify and I were chatting and are thinking how we refer to adding a card feed could be more consistent and less jargony. Here are some screenshots highlighting use of a bunch of different terms to refer to the same thing:

Let's clean this up. Specifically:

• Let's update the button to add a new feed from Add company cards to Add cards (on both the empty state and feed selector).
• Let's change the header on the feed selector from Select card feed to Select cards (also when selecting a feed to assign a card from the workspace member profile).
• Let's change the header when adding a card feed from Add card feed to Add cards.

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

Likely going to be someone from callstack who takes this. Discussing!

[joekaufmanexpensify]

@VickyStash mind commenting so i can assign you?

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[joekaufmanexpensify]

TY!

[VickyStash]

The PR has been opened for the review!

[joekaufmanexpensify]

@VickyStash one more minor change. Could we also change Learn more about the connection methods to Learn more about the options and remove the extraneous period?

[VickyStash]

Sure, done: #53054 (comment)

[joekaufmanexpensify]

TY!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Clean up terms used when adding a card feed #53054

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @puneetlath @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: We changed the wordings after discussing on slack, So this bug was expected till now

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A (We changed the expected text later on slack)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
  N/A (This was part of a project, tests will be added at the end)

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[allgandalf]

@puneetlath let's close this one, I will be paid in bulk at the end of the project

[puneetlath]

Sounds good. Closing.