[$250] Category - On deleting a category, full category list moves

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.68-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause Internal Team

Action Performed:

1. Launch app in both mweb and android
2. Go to workspace settings
3. Tap category
4. Open last category from the list
5. Delete the category

Expected Result:

On deleting a category, full category list must not move.

Actual Result:

On deleting a category, full category list moves in android but not in mweb.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6679383_1732819702957.az_recorder_20241129_000941.mp4

Bug6679383_1732821765430.az_recorder_20241129_005046.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021864244368136739648
• Upwork Job ID: 1864244368136739648
• Last Price Increase: 2024-12-11
• Automatic offers:
• neonbhai | Contributor | 105310664

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On deleting a category, full category list moves in android but not in mweb.

What is the root cause of that problem?

In some conditions, in deleteCategory, navigateBack is called before data is merged into Onyx:

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Lines 122 to 126 in 03639a9

	const deleteCategory = () => {
	Category.deleteWorkspaceCategories(policyID, [categoryName]);
	setDeleteCategoryConfirmModalVisible(false);
	navigateBack();
	};

When navigating back, category list still hold the data before deleting, then updated with new value after onyx data is updated, which causes list move.

Similar problem appears in TagSettingsPage:

Screen.Recording.2024-11-29.at.06.44.33.mov

And possibly from Distance Rate Page, Tax page, and Report Fields page as well.

What changes do you think we should make in order to solve the problem?

Wrap navigateBack inside InteractionManager.runAfterInteractions

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Lines 122 to 126 in 03639a9

	const deleteCategory = () => {
	Category.deleteWorkspaceCategories(policyID, [categoryName]);
	setDeleteCategoryConfirmModalVisible(false);
	navigateBack();
	};

    const deleteCategory = () => {
        Category.deleteWorkspaceCategories(policyID, [categoryName]);
        setDeleteCategoryConfirmModalVisible(false);
        InteractionManager.runAfterInteractions(() => {
            navigateBack();
        });
    };

Apply the same for other pages mention in RCA.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On deleting a category, full category list moves

What is the root cause of that problem?

This happens as the navigation action runs before the Onyx update occurs:

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Lines 122 to 126 in 03639a9

	const deleteCategory = () => {
	Category.deleteWorkspaceCategories(policyID, [categoryName]);
	setDeleteCategoryConfirmModalVisible(false);
	navigateBack();
	};

What changes do you think we should make in order to solve the problem?

We will wrap the Navigation in Navigation.setNavigationActionToMicrotaskQueue to make sure it runs after the Onyx update:

const deleteCategory = () => {
    setDeleteCategoryConfirmModalVisible(false);
    Navigation.setNavigationActionToMicrotaskQueue(navigateBack);
}

We will check and fix delete behaviour in similar lists.

Result:

Before

Screen.Recording.2024-11-29.at.5.42.45.AM.mov

After

Screen.Recording.2024-11-29.at.5.45.25.AM.mov

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Pretty small "bug" though I'll open it up to the community in the name of polish.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021864244368136739648

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[melvin-bot]

@JmillsExpensify, @getusha Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Awaiting proposal reviews.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[getusha]

Reviewing

[getusha]

This looks a pretty small issue but @neonbhai's proposal looks good to me if we decide to fix it.
🎀 👀 🎀 C+ Reviewed!

[melvin-bot]

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[neonbhai]

Thank you for assigning! Raising PR soon

[melvin-bot]

@JmillsExpensify @carlosmiceli @neonbhai @getusha this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[carlosmiceli]

@neonbhai any updates?

[melvin-bot]

@JmillsExpensify, @carlosmiceli, @neonbhai, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[carlosmiceli]

Same as last week, waiting for updates from @neonbhai

[neonbhai]

Apologies for the delay here 🙇

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @carlosmiceli, @neonbhai, @getusha eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[carlosmiceli]

This is still being worked on and is awaiting a review from @getusha