[HOLD for payment 2025-01-28] Create Expense Part 2 - Clean up

[grgia]

Part 2 of #53656

Issue for cleaning up references to the old flow/beta flag.

@JKobrynski

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

[JKobrynski]

I started working on this issue today, PR should be ready early next week.

[JKobrynski]

I've made some progress on it today, I might be able to publish a PR tomorrow.

[JKobrynski]

The PR is ready for review!

[JKobrynski]

I'm still waiting for the PR to be reviewed

[JKobrynski]

PR is waiting for final review

[JKobrynski]

The PR is waiting to be reviewed and merged.

[JKobrynski]

Update:

The PR was approved by @mananjadhav and is now waiting for @grgia 's green light to merge it in its current form

[JKobrynski]

Update:

Some more changes were requested by @grgia, there is also some minor merge conflict. I will be addressing both tomorrow.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[JKobrynski]

Update:

@grgia requested one more change on the PR, I am going to work on it tomorrow.

[mananjadhav]

@JKobrynski any updates on the small change requested by @grgia ?

[JKobrynski]

Update:

PR was updated with fixes to related issues. It's waiting for another round of review!

[mananjadhav]

Reviewed and left a few test cases to cover

[JKobrynski]

Update:

All reported issues have been fixed. There were also some related eslint problems, I fixed them too.

[JKobrynski]

Update:

I updated the PR, fixed conflicts and lint errors. It was merged.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create Expense Part 2 - Clean up #54201

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @JKobrynski does not require payment (Contractor)

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[grgia]

Assigning BZ for @mananjadhav payment @dylanexpensify

[dylanexpensify]

Nice one! Paying tomorrow!

[dylanexpensify]

Payment summary:

Contributor+: @mananjadhav $250 via NewDot

Please apply/request!

[mananjadhav]

@grgia @dylanexpensify I was wondering if we could bump the payout for this particular PR a bit. This required more effort in testing than I expected and went through several iterations.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mananjadhav owed $250 via NewDot
• Contributor: @JKobrynski is from an agency-contributor and not due payment

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[mananjadhav]

@grgia @dylanexpensify In case you missed my previous comment

[dylanexpensify]

Payment summary:

Contributor+: @mananjadhav $500 via NewDot

Please apply/request!

[mananjadhav]

Thanks @dylanexpensify and @grgia. Appreciate it.

[garrettmknight]

$500 approved for @mananjadhav