[HOLD for payment 2025-01-28] [$250] Offline indicator is not displayed at the bottom in the Get physical card page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.77-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Go to workspace with enable Expensify Card
2. Assign a physical card to a member
3. Login with the member who gets assigned card in step 2
4. Go to Settings -> Wallet -> Assigned Cards
5. Click on the Get Physical card button
6. Go to offline

Expected Result:

Offline indicator should be displayed at the bottom

Actual Result:

Offline indicator is not displayed at the bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-12-20.at.11.01.27.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021874229543926888067
• Upwork Job ID: 1874229543926888067
• Last Price Increase: 2024-12-31
• Automatic offers:
• DylanDylann | Reviewer | 105629975
• daledah | Contributor | 105629977

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline indicator is not displayed at the bottom in the Get physical card page

What is the root cause of that problem?

We are setting shouldShowOfflineIndicator={false} here

App/src/pages/settings/Wallet/Card/BaseGetPhysicalCard.tsx

Line 187 in 653af04

shouldShowOfflineIndicator={false}

What changes do you think we should make in order to solve the problem?

Simply we can remove this line

App/src/pages/settings/Wallet/Card/BaseGetPhysicalCard.tsx

Line 187 in 653af04

shouldShowOfflineIndicator={false}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[DylanDylann]

@anmurali I reported this bug, could I take over this issue as C+?

[melvin-bot]

@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@anmurali Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021874229543926888067

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[DylanDylann]

@daledah's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@anmurali @marcaaron @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[daledah]

@marcaaron please assign me as comment here

[melvin-bot]

@anmurali, @marcaaron, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

[DylanDylann]

It seems @youssef-lr also be OOO

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix offline indicator is not displayed at the bottom in the Get physical card page #55146

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment automatic offer (Reviewer)
• @daledah requires payment automatic offer (Contributor)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

@DylanDylann @anmurali @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: feat(expensify-card): add get physical card button and routes #28453 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Login into an account that was assigned an Expensify Card and hasn't filled in contact detail information
2. Go to Settings -> Wallet -> Assigned Cards
3. Click on the Get Physical card button
4. Go offline
5. Verify that: In small screens, the offline indicator is shown

Do we agree 👍 or 👎

[melvin-bot]

@youssef-lr, @anmurali, @DylanDylann, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@youssef-lr, @anmurali, @DylanDylann, @daledah 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[anmurali]

Paid @DylanDylann and @daledah and added the regression test

[DylanDylann]

Let's close this one

[melvin-bot]

@youssef-lr, @anmurali, @DylanDylann, @daledah Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@youssef-lr, @anmurali, @DylanDylann, @daledah 6 days overdue. This is scarier than being forced to listen to Vogon poetry!